From owner-freebsd-current Mon Mar 17 12:43:31 2003 Delivered-To: freebsd-current@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 55F8A37B401; Mon, 17 Mar 2003 12:43:30 -0800 (PST) Received: from rwcrmhc52.attbi.com (rwcrmhc52.attbi.com [216.148.227.88]) by mx1.FreeBSD.org (Postfix) with ESMTP id 6FD2C43F3F; Mon, 17 Mar 2003 12:43:29 -0800 (PST) (envelope-from crist.clark@attbi.com) Received: from blossom.cjclark.org (12-234-89-252.client.attbi.com[12.234.89.252]) by rwcrmhc52.attbi.com (rwcrmhc52) with ESMTP id <20030317204329052004kcofe>; Mon, 17 Mar 2003 20:43:29 +0000 Received: from blossom.cjclark.org (localhost. [127.0.0.1]) by blossom.cjclark.org (8.12.6/8.12.3) with ESMTP id h2HKhSeq099043; Mon, 17 Mar 2003 12:43:28 -0800 (PST) (envelope-from crist.clark@attbi.com) Received: (from cjc@localhost) by blossom.cjclark.org (8.12.6/8.12.6/Submit) id h2HKhK8l099042; Mon, 17 Mar 2003 12:43:20 -0800 (PST) X-Authentication-Warning: blossom.cjclark.org: cjc set sender to crist.clark@attbi.com using -f Date: Mon, 17 Mar 2003 12:43:19 -0800 From: "Crist J. Clark" To: "David O'Brien" , current@FreeBSD.org Subject: Re: Create linker.hints at boot Message-ID: <20030317204319.GA98963@blossom.cjclark.org> Reply-To: cjclark@alum.mit.edu References: <20030315000920.GA69495@blossom.cjclark.org> <20030315032742.3AE132A7EA@canning.wemm.org> <20030317082834.GC24317@blossom.cjclark.org> <20030317171112.GA32128@dragon.nuxi.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20030317171112.GA32128@dragon.nuxi.com> User-Agent: Mutt/1.4i X-URL: http://people.freebsd.org/~cjc/ Sender: owner-freebsd-current@FreeBSD.ORG Precedence: bulk List-ID: List-Archive: (Web Archive) List-Help: (List Instructions) List-Subscribe: List-Unsubscribe: X-Loop: FreeBSD.ORG On Mon, Mar 17, 2003 at 09:11:12AM -0800, David O'Brien wrote: > On Mon, Mar 17, 2003 at 12:28:34AM -0800, Crist J. Clark wrote: > > +kldxref_start () { > > + if [ -z "$kldxref_module_path" ]; then > > + MODULE_PATHS=`sysctl -n kern.module_path` > > + else > > + MODULE_PATHS="$kldxref_module_path" > > + fi > > Please change the logic to positive logic: > > if [ -n "$kldxref_module_path" ]; then > MODULE_PATHS="$kldxref_module_path" > else > MODULE_PATHS=`sysctl -n kern.module_path` > fi Is there a technical reason for that or is it just a "style" issue? -- Crist J. Clark | cjclark@alum.mit.edu | cjclark@jhu.edu http://people.freebsd.org/~cjc/ | cjc@freebsd.org To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-current" in the body of the message