Skip site navigation (1)Skip section navigation (2)
Date:      Thu, 12 Sep 2019 15:09:29 +0000
From:      Brooks Davis <brooks@freebsd.org>
To:        Tobias Kortkamp <tobik@freebsd.org>
Cc:        Brooks Davis <brooks@freebsd.org>, ports-committers@freebsd.org, svn-ports-all@freebsd.org, svn-ports-head@freebsd.org
Subject:   Re: svn commit: r511300 - head/devel/llvm80
Message-ID:  <20190912150929.GA93439@spindle.one-eyed-alien.net>
In-Reply-To: <20190912143153.GA17860@urd.tobik.me>
References:  <201909061104.x86B4iD1058199@repo.freebsd.org> <20190912132706.GA52963@urd.tobik.me> <20190912141801.GI41333@spindle.one-eyed-alien.net> <20190912143153.GA17860@urd.tobik.me>

next in thread | previous in thread | raw e-mail | index | archive | help

--UlVJffcvxoiEqYs2
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Thu, Sep 12, 2019 at 04:31:53PM +0200, Tobias Kortkamp wrote:
> On Thu, Sep 12, 2019 at 02:18:01PM +0000, Brooks Davis wrote:
> > On Thu, Sep 12, 2019 at 03:27:06PM +0200, Tobias Kortkamp wrote:
> > > On Fri, Sep 06, 2019 at 11:04:44AM +0000, Brooks Davis wrote:
> > > > Author: brooks
> > > > Date: Fri Sep  6 11:04:44 2019
> > > > New Revision: 511300
> > > > URL: https://svnweb.freebsd.org/changeset/ports/511300
> > > >=20
> > > > Log:
> > > >   Assorted build improvements:
> > > >  =20
> > > >    - Add a build conflict for commonmark-cmark-* when DOCS are enab=
led.
> > > >      This prevents a failure later on in the build. [0]
> > > >  =20
> > > >    - Add a new option BE_AMDGPU which can be used to enable the AMD=
GPU
> > > >      backed used by mesa when BE_NATIVE or BE_FREEBSD is set.  Enab=
le this
> > > >      option by default to limit later surprises. [1]
> > > >  =20
> > > >    - New option PYCLANG to add python binding for clang. [2]
> > > >  =20
> > > >   PR:		239636 [0], 230789 [1], 239990 [2]
> > > >   Submitted by:	chardon.frederic@gmail.com [2]
> > > >   Sponsored by:	DARPA, AFRL
> > > >=20
> > > > Modified:
> > > >   head/devel/llvm80/Makefile
> > > >   head/devel/llvm80/pkg-plist
> > > >=20
> > > > [...]
> > > > +.if ${PORT_OPTIONS:MPYCLANG}
> > > > +PYCLANG_PATTERN=3D	(clang\/(__init__|cindex|enumerations).py$)
> > > > +.endif
> > >=20
> > > Is the $ in PYCLANG_PATTERN significant?  make ignores it and the
> > > pattern might be wrong when used in build-plist.
> > >=20
> > > $ make -C devel/llvm80 -V PYCLANG_PATTERN
> > > (clang\/(__init__|cindex|enumerations).py)
> >=20
> > It does its job today and generates the right plist...  Do you have a
> > specific problem to report?  The patterns are necessarily a bit adhoc.
>=20
> Nothing more than what I already said.  It has broken a couple of
> my ports tools.  If it is clear that the $ does not do anything in
> PYCLANG_PATTERN then everything is ok here.

Ah, sorry, I misread your first message.  It does look like it is harmlessly
being removed and doesn't matter at this point.  It should be "$$" and
should be moved to the end.  I'll do that at some point.

-- Brooks

--UlVJffcvxoiEqYs2
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQEcBAEBAgAGBQJdel+oAAoJEKzQXbSebgfAN9cIAJjL66PanvLUYHSujvuFFpUg
4npWWHPRte60NS5+6rET7ehcht8WINIpEuMWXqbzfM51y6pdc6yuhSnTc82nU1a3
T3yMRLmyauuM3EtxlC4PCGrdIIIwHu7IeJR+Z8zPHdIT9z4fLFtkcP1ByacVjPd5
nljGAlG5Ic7i2VFpA+4g4NYH5ixn2FSmgqfJjvADCTSjHPuesOO49vNaStNY1FBA
JusVV3mwrwtlf2e53KPf3hhzkVl8AnMoVCn2bK0a7Ijfb57A8t1TjgTPUeGwv36N
z+5AvJf17yv36Vf8+FHaCsTg3Q36hrdxaeDeisTOj1muQNpeu34aBfWikg7mD9E=
=Q2Lc
-----END PGP SIGNATURE-----

--UlVJffcvxoiEqYs2--



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20190912150929.GA93439>