From owner-freebsd-hackers  Sun Feb 25  5:16:29 2001
Delivered-To: freebsd-hackers@freebsd.org
Received: from critter.freebsd.dk (flutter.freebsd.dk [212.242.40.147])
	by hub.freebsd.org (Postfix) with ESMTP
	id 9088537B491; Sun, 25 Feb 2001 05:16:25 -0800 (PST)
	(envelope-from phk@critter.freebsd.dk)
Received: from critter (localhost [127.0.0.1])
	by critter.freebsd.dk (8.11.1/8.11.1) with ESMTP id f1PDGaM13718;
	Sun, 25 Feb 2001 14:16:37 +0100 (CET)
	(envelope-from phk@critter.freebsd.dk)
To: Dima Dorfman <dima@unixfreak.org>
Cc: Robert Watson <rwatson@FreeBSD.ORG>, freebsd-hackers@FreeBSD.ORG
Subject: Re: Listing configured md(4) devices 
In-Reply-To: Your message of "Sat, 24 Feb 2001 16:42:58 PST."
             <20010225004258.0F01E3E09@bazooka.unixfreak.org> 
Date: Sun, 25 Feb 2001 14:16:36 +0100
Message-ID: <13716.983106996@critter>
From: Poul-Henning Kamp <phk@critter.freebsd.dk>
Sender: owner-freebsd-hackers@FreeBSD.ORG
Precedence: bulk
X-Loop: FreeBSD.ORG


I think my commit to md yesterday torpedoed your patch, because one
part of it rej'ected.  I applied the .rej by hand and found a
few nits here and there.

I change the list function extensively, because the "512" size of
the array were not picked from where it should come, <sys/disklabel.h>,
because it is under #ifdef _KERNEL there, so instead I did a list
based sorting instead.

Thanks!

In message <20010225004258.0F01E3E09@bazooka.unixfreak.org>, Dima Dorfman write
s:
>> The "md" problem should really be solved by adding
>> 	#define MD_NAME	"md"
>> to <sys/mdioctl.h> and using this in both the driver and the mdconfig
>> program.
>> 
>> Can I get you to incorporate that in your patch ?
>
>Certainly!  The updated patch is at
>http://www.unixfreak.org/~dima/home/md-list4.diff (it's getting a
>little big, so I thought I'd not attach it here).  The changes include,
>
>  - "md" (and variants thereof) -> MD_NAME,
>  - "mdctl" (and variants thereof) -> MDCTL_NAME (for consistency), and
>  - update the mdconfig(8) manual page to mention the -l option.
>
>Thanks
>
>					Dima Dorfman
>					dima@unixfreak.org
>
>To Unsubscribe: send mail to majordomo@FreeBSD.org
>with "unsubscribe freebsd-hackers" in the body of the message
>

--
Poul-Henning Kamp       | UNIX since Zilog Zeus 3.20
phk@FreeBSD.ORG         | TCP/IP since RFC 956
FreeBSD committer       | BSD since 4.3-tahoe    
Never attribute to malice what can adequately be explained by incompetence.

To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe freebsd-hackers" in the body of the message