From owner-freebsd-testing@FreeBSD.ORG Thu Jan 23 22:26:58 2014 Return-Path: Delivered-To: freebsd-testing@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id 054EE32B; Thu, 23 Jan 2014 22:26:58 +0000 (UTC) Received: from co1outboundpool.messaging.microsoft.com (co1ehsobe006.messaging.microsoft.com [216.32.180.189]) (using TLSv1 with cipher AES128-SHA (128/128 bits)) (No client certificate requested) by mx1.freebsd.org (Postfix) with ESMTPS id B009A1337; Thu, 23 Jan 2014 22:26:57 +0000 (UTC) Received: from mail178-co1-R.bigfish.com (10.243.78.243) by CO1EHSOBE036.bigfish.com (10.243.66.101) with Microsoft SMTP Server id 14.1.225.22; Thu, 23 Jan 2014 22:11:47 +0000 Received: from mail178-co1 (localhost [127.0.0.1]) by mail178-co1-R.bigfish.com (Postfix) with ESMTP id EA4ACD002A3; Thu, 23 Jan 2014 22:11:46 +0000 (UTC) X-Forefront-Antispam-Report: CIP:66.129.239.11; KIP:(null); UIP:(null); IPV:NLI; H:P-EMF02-SAC.jnpr.net; RD:none; EFVD:NLI X-SpamScore: 2 X-BigFish: VPS2(zz1432Izz1f42h208ch1ee6h1de0h1fdah2073h2146h1202h1e76h2189h1d1ah1d2ah21bch1fc6h1082kz8dhz1de097hz31h2a8h839hd25hf0ah1288h12a5h12a9h12bdh12e5h137ah139eh13b6h1441h14ddh1504h1537h162dh1631h1758h1898h18e1h1946h19b5h1ad9h1b0ah1b2fh1b88h224fh1fb3h1d0ch1d2eh1d3fh1de2h1dfeh1dffh1e23h1fe8h1ff5h2218h2216h226dh22d0h24afh2327h2336h2381h2438h2461h2487h24ach24d7h1155h) Received-SPF: softfail (mail178-co1: transitioning domain of juniper.net does not designate 66.129.239.11 as permitted sender) client-ip=66.129.239.11; envelope-from=sjg@juniper.net; helo=P-EMF02-SAC.jnpr.net ; SAC.jnpr.net ; Received: from mail178-co1 (localhost.localdomain [127.0.0.1]) by mail178-co1 (MessageSwitch) id 1390515105242841_25588; Thu, 23 Jan 2014 22:11:45 +0000 (UTC) Received: from CO1EHSMHS017.bigfish.com (unknown [10.243.78.251]) by mail178-co1.bigfish.com (Postfix) with ESMTP id 365D1500047; Thu, 23 Jan 2014 22:11:45 +0000 (UTC) Received: from P-EMF02-SAC.jnpr.net (66.129.239.11) by CO1EHSMHS017.bigfish.com (10.243.66.27) with Microsoft SMTP Server (TLS) id 14.16.227.3; Thu, 23 Jan 2014 22:11:44 +0000 Received: from magenta.juniper.net (172.17.27.123) by P-EMF02-SAC.jnpr.net (172.24.192.21) with Microsoft SMTP Server (TLS) id 14.3.146.0; Thu, 23 Jan 2014 14:11:43 -0800 Received: from chaos.jnpr.net (chaos.jnpr.net [172.24.29.229]) by magenta.juniper.net (8.11.3/8.11.3) with ESMTP id s0NMBgL86536; Thu, 23 Jan 2014 14:11:42 -0800 (PST) (envelope-from sjg@juniper.net) Received: from chaos.jnpr.net (localhost [127.0.0.1]) by chaos.jnpr.net (Postfix) with ESMTP id 814FC5807E; Thu, 23 Jan 2014 14:11:42 -0800 (PST) To: Garrett Cooper Subject: Re: Makefile.inc1.patch In-Reply-To: <8D80A156-F649-4CA1-846A-DBAE9CC30627@gmail.com> References: <4A3E3984-73D3-4441-97A7-D58679EFF978@gmail.com> <9775878D-91AB-4BE4-ADFA-32D8DB582AA6@gmail.com> <20140123210308.0E1D65807E@chaos.jnpr.net> <20140123215430.4B7B15807E@chaos.jnpr.net> <8D80A156-F649-4CA1-846A-DBAE9CC30627@gmail.com> Comments: In-reply-to: Garrett Cooper message dated "Thu, 23 Jan 2014 14:01:07 -0800." From: "Simon J. Gerraty" X-Mailer: MH-E 7.82+cvs; nmh 1.3; GNU Emacs 22.3.1 Date: Thu, 23 Jan 2014 14:11:42 -0800 Message-ID: <20140123221142.814FC5807E@chaos.jnpr.net> MIME-Version: 1.0 Content-Type: text/plain X-OriginatorOrg: juniper.net X-FOPE-CONNECTOR: Id%0$Dn%*$RO%0$TLS%0$FQDN%$TlsDn% Cc: "freebsd-testing@freebsd.org" , brooks@freebsd.org X-BeenThere: freebsd-testing@freebsd.org X-Mailman-Version: 2.1.17 Precedence: list List-Id: Testing on FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 23 Jan 2014 22:26:58 -0000 >> For options.mk I allow MK_* to already be set and WITHOUT_* to take >> precedence over WITH_*. I also allow makefiles to have their own = >lists >> of options - separate the policy from the mechanism. > >Would that fix this case though? I imagine it would make fixing it easier. >> I guess you could even allow a per-knob setting as to which takes >> precedence.=20 > >You mean override the default so WITH_* overrides WITHOUT_*? Yes - I expect that would be rare, but worth it for completness. The important thing is a simple precidence rule. >> By simply allowing WITHOUT_* to overrule WITH_*, the Makefile.inc1 = >usage >> would be greatly simplified. > >Maybe=85 the -DNO_* logic is a bit messy=85 NO_* always wins, it allows a makefile to say "I don't care what you want I cannot do that". Most places you see -DNO_* used could be -DWITHOUT_* if the semantics were not broken as previously described. NO_* should be mainly for makefiles to set - like NO_MAN= (i don't got no man page man) >Curious to see what you have in mind :).. Look at contrib/bmake/Makefile --sjg