From owner-freebsd-current Sat Jun 3 13:26:52 1995 Return-Path: current-owner Received: (from majordom@localhost) by freefall.cdrom.com (8.6.10/8.6.6) id NAA22324 for current-outgoing; Sat, 3 Jun 1995 13:26:52 -0700 Received: from gndrsh.aac.dev.com (gndrsh.aac.dev.com [198.145.92.241]) by freefall.cdrom.com (8.6.10/8.6.6) with ESMTP id NAA22315 for ; Sat, 3 Jun 1995 13:26:49 -0700 Received: (from rgrimes@localhost) by gndrsh.aac.dev.com (8.6.11/8.6.9) id NAA16847; Sat, 3 Jun 1995 13:26:26 -0700 From: "Rodney W. Grimes" Message-Id: <199506032026.NAA16847@gndrsh.aac.dev.com> Subject: Re: Some Makefiles incorrectly set LDADD To: roberto@keltia.freenix.fr Date: Sat, 3 Jun 1995 13:26:25 -0700 (PDT) Cc: freebsd-current@FreeBSD.ORG In-Reply-To: <199506032015.WAA13762@keltia.frmug.fr.net> from "Ollivier Robert" at Jun 3, 95 10:15:48 pm X-Mailer: ELM [version 2.4 PL24] MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Content-Length: 900 Sender: current-owner@FreeBSD.ORG Precedence: bulk > > Some programs incorrectly set LDADD with "=" and not "+=" in the Makefile. > I found this when attempting to replace BSD malloc by Doug Lea's malloc. > > Examples: > > date/Makefile:LDADD= -lutil > mv/Makefile:LDADD= -lutil > ps/Makefile:LDADD= -lm -lkvm > rcp/Makefile:LDADD= -lkrb -ldes > sh/Makefile:LDADD= -ll -ledit -ltermcap ^^^ LDADD should not be set with a += in a Makefile unless that Makefile has mutliple LDADD lines with in it. > Why is there no "+=" ? Is this intentional ? gndrsh# cd /usr/src gndrsh# vi `kfind -l LDADD+=` Look at a bunch of them a notice that we seem to be very inconsistent here, but the ones I look at may have LDADD's in ../Makefile.inc that I did not check for. -- Rod Grimes rgrimes@gndrsh.aac.dev.com Accurate Automation Company Custom computers for FreeBSD