From owner-svn-src-all@FreeBSD.ORG  Sun Nov 16 05:24:25 2014
Return-Path: <owner-svn-src-all@FreeBSD.ORG>
Delivered-To: svn-src-all@freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [8.8.178.115])
 (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))
 (No client certificate requested)
 by hub.freebsd.org (Postfix) with ESMTPS id D8FDC9EA;
 Sun, 16 Nov 2014 05:24:25 +0000 (UTC)
Received: from elvis.mu.org (elvis.mu.org [192.203.228.196])
 by mx1.freebsd.org (Postfix) with ESMTP id C4A4E9A3;
 Sun, 16 Nov 2014 05:24:25 +0000 (UTC)
Received: from AlfredMacbookAir.local (c-76-21-10-192.hsd1.ca.comcast.net
 [76.21.10.192])
 by elvis.mu.org (Postfix) with ESMTPSA id EA0F5341F84E;
 Sat, 15 Nov 2014 21:24:24 -0800 (PST)
Message-ID: <54683508.3030104@freebsd.org>
Date: Sat, 15 Nov 2014 21:24:24 -0800
From: Alfred Perlstein <alfred@freebsd.org>
Organization: FreeBSD
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.10;
 rv:24.0) Gecko/20100101 Thunderbird/24.6.0
MIME-Version: 1.0
To: Garrett Cooper <yaneurabeya@gmail.com>
Subject: Re: svn commit: r274573 - head/contrib/netbsd-tests/lib/libpthread
References: <201411160508.sAG58JdG055637@svn.freebsd.org>
 <546833FE.9060904@freebsd.org>
 <45B1482F-352E-4874-8A89-1EC225A32E93@gmail.com>
In-Reply-To: <45B1482F-352E-4874-8A89-1EC225A32E93@gmail.com>
Content-Type: text/plain; charset=windows-1252; format=flowed
Content-Transfer-Encoding: 8bit
Cc: svn-src-head@freebsd.org, svn-src-all@freebsd.org,
 src-committers@freebsd.org, Garrett Cooper <ngie@FreeBSD.org>
X-BeenThere: svn-src-all@freebsd.org
X-Mailman-Version: 2.1.18-1
Precedence: list
List-Id: "SVN commit messages for the entire src tree \(except for &quot;
 user&quot; and &quot; projects&quot; \)" <svn-src-all.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/options/svn-src-all>,
 <mailto:svn-src-all-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/svn-src-all/>
List-Post: <mailto:svn-src-all@freebsd.org>
List-Help: <mailto:svn-src-all-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/svn-src-all>,
 <mailto:svn-src-all-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Sun, 16 Nov 2014 05:24:26 -0000


On 11/15/14, 9:22 PM, Garrett Cooper wrote:
> On Nov 15, 2014, at 21:19, Alfred Perlstein <alfred@freebsd.org> wrote:
>
>> This looks easy enough to fix under _thr_find_thread() in libthread.
>>
>> Any interest in fixing it?
> Yes, if it’s POSIXly correct and doesn’t break everything else.
>
>> Might be worth hacking _thr_find_thread() to take an ERRNO to return based on NULL until we chase down all the paths into it just in case EINVAL is a valid ptr.
> K. Thanks for the hint!
>
>> Also, just wondering what happens on other platforms, does it elicit a crash?  Ie. is NULL a safe value to pass in on other platforms?
> I wish I knew what happened on !x86 platforms… I honestly don’t have access to ARM/MIPS/PowerPC, so I can’t say :/.
>
> Thanks!

Oh, I meant Linux and Solaris, or even other BSD.

-Alfred