Date: Sat, 15 Nov 2014 21:24:24 -0800 From: Alfred Perlstein <alfred@freebsd.org> To: Garrett Cooper <yaneurabeya@gmail.com> Cc: svn-src-head@freebsd.org, svn-src-all@freebsd.org, src-committers@freebsd.org, Garrett Cooper <ngie@FreeBSD.org> Subject: Re: svn commit: r274573 - head/contrib/netbsd-tests/lib/libpthread Message-ID: <54683508.3030104@freebsd.org> In-Reply-To: <45B1482F-352E-4874-8A89-1EC225A32E93@gmail.com> References: <201411160508.sAG58JdG055637@svn.freebsd.org> <546833FE.9060904@freebsd.org> <45B1482F-352E-4874-8A89-1EC225A32E93@gmail.com>
next in thread | previous in thread | raw e-mail | index | archive | help
On 11/15/14, 9:22 PM, Garrett Cooper wrote: > On Nov 15, 2014, at 21:19, Alfred Perlstein <alfred@freebsd.org> wrote: > >> This looks easy enough to fix under _thr_find_thread() in libthread. >> >> Any interest in fixing it? > Yes, if it’s POSIXly correct and doesn’t break everything else. > >> Might be worth hacking _thr_find_thread() to take an ERRNO to return based on NULL until we chase down all the paths into it just in case EINVAL is a valid ptr. > K. Thanks for the hint! > >> Also, just wondering what happens on other platforms, does it elicit a crash? Ie. is NULL a safe value to pass in on other platforms? > I wish I knew what happened on !x86 platforms… I honestly don’t have access to ARM/MIPS/PowerPC, so I can’t say :/. > > Thanks! Oh, I meant Linux and Solaris, or even other BSD. -Alfred
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?54683508.3030104>