Date: Wed, 7 Jul 2021 09:00:45 +0200 From: Mathieu Arnold <mat@freebsd.org> To: =?utf-8?B?TG/Dr2M=?= Bartoletti <lbartoletti@freebsd.org> Cc: Christoph Moench-Tegeder <cmt@burggraben.net>, ports-committers@freebsd.org, dev-commits-ports-all@freebsd.org, dev-commits-ports-main@freebsd.org Subject: Re: git: be86c4fe23e0 - main - misc/qtchooser: remove Message-ID: <20210707070045.zrtfkdkblrbxesri@aching.in.mat.cc> In-Reply-To: <2569fab0-d643-e22a-0d3a-2e4df497c75f@FreeBSD.org> References: <202107041732.164HW8HQ076467@gitrepo.freebsd.org> <YOIoFS9WMLRdgUhk@elch.exwg.net> <2569fab0-d643-e22a-0d3a-2e4df497c75f@FreeBSD.org>
next in thread | previous in thread | raw e-mail | index | archive | help
--4md2ixvavszwspc4 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Mon, Jul 05, 2021 at 09:08:15AM +0200, Lo=EFc Bartoletti wrote: > Hello, >=20 > Le 04/07/2021 =E0 23:28, Christoph Moench-Tegeder a =E9crit=A0: > > ## Lo=EFc Bartoletti (lbartoletti@FreeBSD.org): > > This: > >=20 > > > misc/qtchooser: remove > > Does more than it says on the label: > Indeed, removing a tool like this one cannot be done without patching (ma= ny) > other ports. > >=20 > > > --- a/cad/freecad/Makefile > > > +++ b/cad/freecad/Makefile > > > -USES=3D dos2unix compiler:c++11-lib cmake gl eigen:3 fortran jpeg \ > > > +USES=3D dos2unix compiler:c++17-lang cmake gl eigen:3 fortran jpeg \ > > > + -DBUILD_ENABLE_CXX_STD=3DC++17 > Sorry, this line is not needed to build cad/freecad without qtchooser. >=20 > I added it during my tests, because I saw that it was necessary to reduce > some warnings, but it's not useful for this change. >=20 > > I'd appricate knowing why these additional changes happen - it reduces > > annoyances on my side when these changes interfere with other patches > > I've lined up (yeah, I should just commit faster, but sometimes live > > happens). >=20 > We have communicated in the past, publicly or directly with those affecte= d, > like you, for this kind of improvement. >=20 > Although this initiative has been public for several months, it may not h= ave > been visible. >=20 > I will ensure better communication for the next times. I think the problem Christoph is pointing out is that the commit says "remove misc/qtchooser" and you are changing which compiler is needed in cad/freecad, which has absolutely nothing to do with removing misc/qtchooser. It is either a mistake and should not have been committed, or it should have been committed in a separate commit, that would say why you are changing the compiler needed. Also, it feels like you're trying to commit stuff under the hood hoping nobody will notice. --=20 Mathieu Arnold --4md2ixvavszwspc4 Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQKTBAABCgB9FiEEVhwchfRfuV0unqO5KesJApEdfgIFAmDlURhfFIAAAAAALgAo aXNzdWVyLWZwckBub3RhdGlvbnMub3BlbnBncC5maWZ0aGhvcnNlbWFuLm5ldDU2 MUMxQzg1RjQ1RkI5NUQyRTlFQTNCOTI5RUIwOTAyOTExRDdFMDIACgkQKesJApEd fgJrag/+KliG5IcqiEnbqcHTHJrQ5/2qboI4mGMlVk0YV5PMu4oE7FdKekO6CTlI G3QzCbXPbldA2ZcRgtet4tG23C3TautB6ocRrwJ/TlB24HFOe7mx+HBMLZtNlgiA w1pz30Na3kXyAKUAQw/tC5wiaZ9v+mV86Lsou/L581ZqxrKaoIfF76lkT63AF2tp XI5tdOj2wdF2YS7RCoWxH3mrBtjC0USVjpaw2FWPDnWZ7pj59UEAfhbz11cN/XQM L4Wq5P1Lbx1/z4BbL6Z7Oz4BW8vvaUJ0pR9onKKtZ1K0TItadsJhc/dR1wLI539E zSG9BBxl8RGSWaIq87MOJYI3x1DVqBLb3a2OtbiNk0R5dTbyQ0EAywthJwxAP8Rg hAq/NE5Nfw9prJXtK3N5yg/BFtRrzAuWb0CJiKYZK/oBTrOG6QnDWIZdC0yc2QOS 4n6xUZteeGWAKFUItfrqgpj+61/w7/cDeEgRbBmxe9qZpErCkl6XO76EpJlmZQbC 0flvpdfE/fcM2m6HA+g3CiqiSmcHiHQcS34FbZGtDxZwDSUQi+ITgYOFy3gK3zbK 2Jh4BCrSfIzHgYlVDv3fzSRGpJKu7GO9CfNeabliJ3HizDQTzO22EV/vTQb7xF84 exax7cCFdaQkfU8JFJvDxvhrsUltLiJoCY7WmBDRzsujZnjEtlk= =Vt+k -----END PGP SIGNATURE----- --4md2ixvavszwspc4--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20210707070045.zrtfkdkblrbxesri>