Date: Fri, 13 Jul 2012 01:21:27 +0000 From: exxo@FreeBSD.org To: svn-soc-all@FreeBSD.org Subject: socsvn commit: r239326 - in soc2012/exxo: . patches Message-ID: <20120713012127.7FEA8106566C@hub.freebsd.org>
next in thread | raw e-mail | index | archive | help
Author: exxo Date: Fri Jul 13 01:21:25 2012 New Revision: 239326 URL: http://svnweb.FreeBSD.org/socsvn/?view=rev&rev=239326 Log: Adding newkey.patch and updating notes Added: soc2012/exxo/patches/newkey.patch Deleted: soc2012/exxo/patches/openssl-1.0.1c-getaddrinfo.patch Modified: soc2012/exxo/bugnotes.txt soc2012/exxo/softnotes.txt Modified: soc2012/exxo/bugnotes.txt ============================================================================== --- soc2012/exxo/bugnotes.txt Fri Jul 13 00:54:52 2012 (r239325) +++ soc2012/exxo/bugnotes.txt Fri Jul 13 01:21:25 2012 (r239326) @@ -12,3 +12,12 @@ WHERE b_sock.c:705 in BIO_get_accept_socket() DESCRIPTION requesting an IPv6 listening of an host without AAAA record fallback to IPv4 AFFECTS all hosts supporting IPv4 only + + +<usr.bin/newkey> + + TYPE programming error + WHERE newkey.c:133 in main() + DESCRIPTION if host2netname() came to fail, the buff `name' is left uninitialized. + Thus it possibly leads to a sigsev when displayed at line 137. + AFFECTS * Added: soc2012/exxo/patches/newkey.patch ============================================================================== --- /dev/null 00:00:00 1970 (empty, because file is newly added) +++ soc2012/exxo/patches/newkey.patch Fri Jul 13 01:21:25 2012 (r239326) @@ -0,0 +1,23 @@ +Index: freebsd-head/usr.bin/newkey/newkey.c +=================================================================== +--- freebsd-head/usr.bin/newkey/newkey.c (revision 239313) ++++ freebsd-head/usr.bin/newkey/newkey.c (working copy) +@@ -125,13 +125,15 @@ main(int argc, char *argv[]) + (void)user2netname(name, (int)pw->pw_uid, (char *)NULL); + } else { + #ifdef undef +- h = gethostbyname(argv[2]); ++ h = gethostbyname(argv[2]); /* If ever turned on, this needs to be IPv6 ready. */ + if (h == NULL) + errx(1, "unknown host: %s", argv[1]); +- (void)host2netname(name, h->h_name, (char *)NULL); ++ status = host2netname(name, h->h_name, (char *)NULL); + #else +- (void)host2netname(name, argv[2], (char *)NULL); ++ status = host2netname(name, argv[2], (char *)NULL); + #endif ++ if (status == FALSE) ++ errx(1, "unable to generate netname"); + } + + (void)printf("Adding new key for %s.\n", name); Modified: soc2012/exxo/softnotes.txt ============================================================================== --- soc2012/exxo/softnotes.txt Fri Jul 13 00:54:52 2012 (r239325) +++ soc2012/exxo/softnotes.txt Fri Jul 13 01:21:25 2012 (r239326) @@ -1,15 +1,15 @@ openssl-1.0.1c FIXED (patch provided. Be aware of some TODO parts, Bio connect is not concerned by this patch) contrib/cvs FIXED (patch updated) usr.bin/who OK (software dependant, utmpx fixed it) -usr.bin/rusers -usr.bin/bluetooth usr.bin/systat FIXED (patch provided. systat now supports IPv6 when using ignore/display/show netstat commands) -usr.bin/rup -usr.bin/quota FIXED -usr.bin/newkey +usr.bin/quota FIXED (patch provided. quota should now work correctly on NFSv6 shares) +usr.bin/newkey OK (the address lookup is not used anymore) usr.bin/ypwhich usr.bin/getent usr.bin/talk +usr.bin/rusers +usr.bin/rup +usr.bin/bluetooth contrib/bsnmp contrib/amd contrib/ntp
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20120713012127.7FEA8106566C>