From owner-svn-ports-head@FreeBSD.ORG Thu Apr 9 16:13:32 2015 Return-Path: Delivered-To: svn-ports-head@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [8.8.178.115]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id CA44D41C for ; Thu, 9 Apr 2015 16:13:32 +0000 (UTC) Received: from freefall.freebsd.org (freefall.freebsd.org [IPv6:2001:1900:2254:206c::16:87]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id A56A2F95 for ; Thu, 9 Apr 2015 16:13:32 +0000 (UTC) Received: from freefall.freebsd.org (localhost [127.0.0.1]) by freefall.freebsd.org (8.14.9/8.14.9) with ESMTP id t39GDWoG009309 for ; Thu, 9 Apr 2015 16:13:32 GMT (envelope-from bdrewery@freefall.freebsd.org) Received: (from bdrewery@localhost) by freefall.freebsd.org (8.14.9/8.14.9/Submit) id t39GDWqM009307 for svn-ports-head@freebsd.org; Thu, 9 Apr 2015 16:13:32 GMT (envelope-from bdrewery) Received: (qmail 14448 invoked from network); 9 Apr 2015 11:13:28 -0500 Received: from unknown (HELO ?10.10.1.139?) (freebsd@shatow.net@10.10.1.139) by sweb.xzibition.com with ESMTPA; 9 Apr 2015 11:13:28 -0500 Message-ID: <5526A52E.4090801@FreeBSD.org> Date: Thu, 09 Apr 2015 11:13:34 -0500 From: Bryan Drewery Organization: FreeBSD User-Agent: Mozilla/5.0 (Windows NT 6.3; WOW64; rv:31.0) Gecko/20100101 Thunderbird/31.6.0 MIME-Version: 1.0 To: Alexey Dokuchaev Subject: Re: svn commit: r383191 - head/Mk References: <201504040535.t345ZJ9M028396@svn.freebsd.org> <20150408194202.GA45809@hades.panopticon> <5525A9C1.5010003@FreeBSD.org> <20150408232144.GX21982@hades.panopticon> <5525D48E.5090305@FreeBSD.org> <20150409110221.GB45809@hades.panopticon> <55269785.7030307@FreeBSD.org> <20150409153856.GA31951@FreeBSD.org> <55269FE4.2030208@FreeBSD.org> <20150409160330.GB31951@FreeBSD.org> In-Reply-To: <20150409160330.GB31951@FreeBSD.org> OpenPGP: id=F9173CB2C3AAEA7A5C8A1F0935D771BB6E4697CF; url=http://www.shatow.net/bryan/bryan2.asc Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="e0D42hdeJ7R9pwsih5b71Mcr6AK7NlwO6" Cc: svn-ports-head@freebsd.org, svn-ports-all@freebsd.org, Dmitry Marakasov , ports-committers@freebsd.org X-BeenThere: svn-ports-head@freebsd.org X-Mailman-Version: 2.1.18-1 Precedence: list List-Id: SVN commit messages for the ports tree for head List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 09 Apr 2015 16:13:33 -0000 This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --e0D42hdeJ7R9pwsih5b71Mcr6AK7NlwO6 Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: quoted-printable On 4/9/2015 11:03 AM, Alexey Dokuchaev wrote: > On Thu, Apr 09, 2015 at 10:51:00AM -0500, Bryan Drewery wrote: >> On 4/9/2015 10:38 AM, Alexey Dokuchaev wrote: >>> I'm personally heavily relying on ability to set OSVERSION to arbitra= ry >>> value on per-port basis; it is very helpful to test the logic of some= >>> complicated port (e.g. x11/nvidia-driver) to make sure you got all th= ese >>> checks right. Now since r369644 (also by you) I have to comment that= >>> harness code from Mk/bsd.port.mk out. >>> >>> I was actually surprised that I have to do it, since log message talk= s >>> only about "OSVERSION or UNAME_r is improperly set when building in a= >>> jail/chroot", but in reality I cannot do a "make OSVERSION=3Dxxx" eve= n when >>> building locally. [...] >> >> Read the commit log again for r369644. Setting one var and not the oth= er >> leads to incorrect behavior in many ports. You must have them matching= =2E >> It is not just about jails/chroots. >=20 > I've (re)read it and understand what you're trying to accomplish; my po= int > here is not to *build* things against custom OSVERSION, but just check = if > some variables are set correctly, e.g. "make -V FOO OSVERSION=3Dxxx" is= what > I miss. Is there a way to allow it again somehow? >=20 > ./danfe >=20 I understand what you're trying to do and I agree it would be useful if it worked. Validating port logic (such as whether EXTRA_PATCHES has something) based on OSVERSION is very useful. I'll think about how to fix it. --=20 Regards, Bryan Drewery --e0D42hdeJ7R9pwsih5b71Mcr6AK7NlwO6 Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQEcBAEBAgAGBQJVJqUuAAoJEDXXcbtuRpfPK8wIAMB5cI2UFB6qiLo/I7nXB57v 1d0GY934YHrA+lGtdFFdHU1rhu/3zjB1zQiSfOht/derd62BBuF0SSmdAPD1Wdcw RP3y1SpNWfFAFKIGijmgj5FJNh9x93Vm22UJQsUWN72ktBB75AthXB1SAZ7FrQPw xJv3Pnru3cTpMYOt2HhO76pmnGDgod4ZRnHSgr2ja/N/2b35hsuGeeM7gP3V+h9F amRYKjsFGIswKMRWMkvmJkGQOKQ3/SBlu826V7dioOhhlDUvG1Zy+fUckovdIMnx /FdGOvks9IDYfsGC2Hi84Mz17c+O6z2jo/8SR7X4+N37BCxN5MwHpYVDU3zKeq4= =6/rC -----END PGP SIGNATURE----- --e0D42hdeJ7R9pwsih5b71Mcr6AK7NlwO6--