From owner-freebsd-current Sun Mar 2 5:19:22 2003 Delivered-To: freebsd-current@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 9277B37B401; Sun, 2 Mar 2003 05:19:21 -0800 (PST) Received: from storm.FreeBSD.org.uk (storm.FreeBSD.org.uk [194.242.157.42]) by mx1.FreeBSD.org (Postfix) with ESMTP id A830A43F93; Sun, 2 Mar 2003 05:19:20 -0800 (PST) (envelope-from mark@grondar.org) Received: from storm.FreeBSD.org.uk (Ugrondar@localhost [127.0.0.1]) by storm.FreeBSD.org.uk (8.12.6/8.12.6) with ESMTP id h22DJJTp033053; Sun, 2 Mar 2003 13:19:19 GMT (envelope-from mark@grondar.org) Received: (from Ugrondar@localhost) by storm.FreeBSD.org.uk (8.12.7/8.12.6/Submit) with UUCP id h22DJJ43033052; Sun, 2 Mar 2003 13:19:19 GMT X-Authentication-Warning: storm.FreeBSD.org.uk: Ugrondar set sender to mark@grondar.org using -f Received: from grondar.org (localhost [127.0.0.1]) by grimreaper.grondar.org (8.12.7/8.12.7) with ESMTP id h22DIlIg052357; Sun, 2 Mar 2003 13:18:47 GMT (envelope-from mark@grondar.org) From: Mark Murray Message-Id: <200303021318.h22DIlIg052357@grimreaper.grondar.org> To: Dag-Erling Smorgrav Cc: Jens Rehsack , Juli Mallett , current@FreeBSD.ORG Subject: Re: PATCH: type errors in src-tree In-Reply-To: Your message of "Sun, 02 Mar 2003 13:08:48 +0100." Date: Sun, 02 Mar 2003 13:18:47 +0000 Sender: owner-freebsd-current@FreeBSD.ORG Precedence: bulk List-ID: List-Archive: (Web Archive) List-Help: (List Instructions) List-Subscribe: List-Unsubscribe: X-Loop: FreeBSD.ORG Dag-Erling Smorgrav writes: > Jens Rehsack writes: > > Of course. Very often in ilmid.c the type caddr_t was used, and nearly > > the same count of 'const char *'s was used. I've searched the include > > files for caddr_t (core address) and found it defined as 'char *', so > > I decided to used commonly caddr_t - maybe later I check which of them > > could be changed into 'c_caddr_t' for being const. But You can of > > couse replace all 'caddr_t' which 'char *'. > > This is wrong. caddr_t should be uniersally replaced with void *. I'm currently doing this for kicks (Well, actually because it kills a botload of warnings, lint and otherwise). Once make world is working again, I'll put up a patch. My approach is to typedef caddr_t to void*, and then fix the errors this causes. So far, they are all no-brainers; mainly function prototypes that are inconsistent with their definitions. There are a few places where caddr_t is assumed to point to char. M -- Mark Murray iumop ap!sdn w,I idlaH To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-current" in the body of the message