From owner-freebsd-i386@FreeBSD.ORG  Mon Sep 11 13:32:00 2006
Return-Path: <owner-freebsd-i386@FreeBSD.ORG>
X-Original-To: freebsd-i386@freebsd.org
Delivered-To: freebsd-i386@freebsd.org
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP id 06A9316A403;
	Mon, 11 Sep 2006 13:32:00 +0000 (UTC)
	(envelope-from hselasky@c2i.net)
Received: from swip.net (mailfe03.swip.net [212.247.154.65])
	by mx1.FreeBSD.org (Postfix) with ESMTP id 23AF843D53;
	Mon, 11 Sep 2006 13:31:58 +0000 (GMT)
	(envelope-from hselasky@c2i.net)
X-T2-Posting-ID: gvlK0tOCzrqh9CPROFOFPw==
X-Cloudmark-Score: 0.000000 []
Received: from [193.216.120.90] (HELO [10.0.0.249])
	by mailfe03.swip.net (CommuniGate Pro SMTP 5.0.8)
	with ESMTP id 283753659; Mon, 11 Sep 2006 15:31:56 +0200
From: Hans Petter Selasky <hselasky@c2i.net>
To: Remko Lodder <remko@freebsd.org>
Date: Mon, 11 Sep 2006 15:32:11 +0200
User-Agent: KMail/1.7
References: <200609111217.k8BCH9aI074992@freefall.freebsd.org>
In-Reply-To: <200609111217.k8BCH9aI074992@freefall.freebsd.org>
MIME-Version: 1.0
Content-Type: text/plain;
  charset="iso-8859-1"
Content-Transfer-Encoding: 7bit
Content-Disposition: inline
Message-Id: <200609111532.12005.hselasky@c2i.net>
Cc: freebsd-i386@freebsd.org
Subject: Re: i386/46113: [bus] [patch] busspace bugs in parameter checking
X-BeenThere: freebsd-i386@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: I386-specific issues for FreeBSD <freebsd-i386.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-i386>,
	<mailto:freebsd-i386-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-i386>
List-Post: <mailto:freebsd-i386@freebsd.org>
List-Help: <mailto:freebsd-i386-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-i386>,
	<mailto:freebsd-i386-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Mon, 11 Sep 2006 13:32:00 -0000

On Monday 11 September 2006 14:17, Remko Lodder wrote:
> Synopsis: [bus] [patch] busspace bugs in parameter checking
>
> State-Changed-From-To: open->feedback
> State-Changed-By: remko
> State-Changed-When: Mon Sep 11 12:16:49 UTC 2006
> State-Changed-Why:
> Hello,
>
> can you tell me whether this had been resolved or not
> already? Thanks!
>
>
> Responsible-Changed-From-To: freebsd-i386->remko
> Responsible-Changed-By: remko
> Responsible-Changed-When: Mon Sep 11 12:16:49 UTC 2006
> Responsible-Changed-Why:
> grab the pr
>
> http://www.freebsd.org/cgi/query-pr.cgi?pr=46113

Last time this was discussed, it ended something like this:

If the code currently never calls these functions with "count == 0", 
then assume it is an optimization to not check for "count == 0".

The isssue has not been resolved, rather worked around, by having:

if (count != 0) {
  bus_space_xxxx(....);
}

in the drivers in question.

--HPS