Date: Wed, 29 Mar 2017 21:56:52 +0200 From: Matthew Rezny <rezny@freebsd.org> To: Jan Beich <jbeich@freebsd.org> Cc: ports-committers@freebsd.org, svn-ports-all@freebsd.org, svn-ports-head@freebsd.org Subject: Re: svn commit: r437215 - in head/graphics: gbm libEGL libGL libglapi Message-ID: <1824022.AbFPd1OJUh@workstation.reztek> In-Reply-To: <h92c-ezt0-wny@FreeBSD.org> References: <201703291657.v2TGvrpM076369@repo.freebsd.org> <h92c-ezt0-wny@FreeBSD.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On Wednesday 29 March 2017 19:51:55 Jan Beich wrote:
> Matthew Rezny <rezny@FreeBSD.org> writes:
> > - @${REINPLACE_CMD} -e 's|x86_64|amd64|' \
> > + @${REINPLACE_CMD} -e 's|x86_64|amd64|' -e 's|\\S\*//|[:space:]* //|' \
>
> [:space:] is invalid character class thus treated as a list of characters.
> \S corresponds to [^[:space:]], while \s to [[:space:]].
>
> $ man pcrepattern | col -b | fgrep -m1 \\S
> \S any character that is not a white space character
>
> This may break build given -march, etc. are no longer stripped.
I wish that information had been presented when I said "I guess it should have
been [:space:] instead of [:graph:] in the replacement." after you stated
[:graph:] was plain incorrect, although it is what had been previously
suggested to me and did seem to be working.
To be sure there is no misunderstanding now, would you consider this correct?
@${REINPLACE_CMD} -e 's|x86_64|amd64|' -e 's|\\S\*//|[^[:space:]]* //|' \
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?1824022.AbFPd1OJUh>