From owner-svn-src-head@FreeBSD.ORG Sun Feb 2 22:40:44 2014 Return-Path: Delivered-To: svn-src-head@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id 4754A79C; Sun, 2 Feb 2014 22:40:44 +0000 (UTC) Received: from mail-gw12.york.ac.uk (mail-gw12.york.ac.uk [144.32.129.162]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.freebsd.org (Postfix) with ESMTPS id 078F616C4; Sun, 2 Feb 2014 22:40:43 +0000 (UTC) Received: from ury.york.ac.uk ([144.32.64.162]:44454) by mail-gw12.york.ac.uk with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.76) (envelope-from ) id 1WA5cw-00008D-JG; Sun, 02 Feb 2014 22:34:58 +0000 Date: Sun, 2 Feb 2014 22:34:58 +0000 (GMT) From: Gavin Atkinson X-X-Sender: gavin@ury.york.ac.uk To: John Baldwin Subject: Re: svn commit: r261216 - head/sys/dev/pccbb In-Reply-To: <201401271949.s0RJnr7t067977@svn.freebsd.org> Message-ID: References: <201401271949.s0RJnr7t067977@svn.freebsd.org> User-Agent: Alpine 2.00 (BSF 1167 2008-08-23) MIME-Version: 1.0 Content-Type: MULTIPART/MIXED; BOUNDARY="830102327-1676614541-1391380498=:33534" Cc: svn-src-head@freebsd.org, svn-src-all@freebsd.org, src-committers@freebsd.org, imp@freebsd.org X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.17 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 02 Feb 2014 22:40:44 -0000 This message is in MIME format. The first part should be readable text, while the remaining parts are likely unreadable without MIME-aware tools. --830102327-1676614541-1391380498=:33534 Content-Type: TEXT/PLAIN; charset=US-ASCII On Mon, 27 Jan 2014, John Baldwin wrote: > Author: jhb > Date: Mon Jan 27 19:49:52 2014 > New Revision: 261216 > URL: http://svnweb.freebsd.org/changeset/base/261216 > > Log: > Explicitly enable I/O and memory decoding in the bridge's command register > when activating an I/O or memory window on the CardBus bridge. This fixes some, but not all of my machines. One in particular, a Toshiba M5 laptop, remains broken by r254263 even with this change. Specificaly, the laptop does not notice when a card is inserted. The attached minimal patch gets things working again, though I don't know if is the correct fix or if a more involved fix is required. dmesg before and after that patch: http://people.freebsd.org/~gavin/m5-dmesg-before.txt http://people.freebsd.org/~gavin/m5-dmesg-after.txt The only difference is the cbb register dump, the one bit that I am setting in the patch. Thanks, Gavin --830102327-1676614541-1391380498=:33534 Content-Type: TEXT/PLAIN; charset=US-ASCII; name=m5-diff-minimal Content-Transfer-Encoding: BASE64 Content-ID: Content-Description: Content-Disposition: attachment; filename=m5-diff-minimal SW5kZXg6IC91c3Ivc3JjL3N5cy9kZXYvcGNjYmIvcGNjYmJfcGNpLmMNCj09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT0NCi0tLSAvdXNyL3NyYy9zeXMvZGV2L3Bj Y2JiL3BjY2JiX3BjaS5jCShyZXZpc2lvbiAyNjEzNTIpDQorKysgL3Vzci9z cmMvc3lzL2Rldi9wY2NiYi9wY2NiYl9wY2kuYwkod29ya2luZyBjb3B5KQ0K QEAgLTQ3Miw2ICs0NzIsNyBAQA0KIA0KIAkvKiBFbmFibGUgbWVtb3J5IGFj Y2VzcyAqLw0KIAlwY2lfZW5hYmxlX2J1c21hc3RlcihzYy0+ZGV2KTsNCisJ UENJX01BU0tfQ09ORklHKHNjLT5kZXYsIFBDSVJfQ09NTUFORCwgfCBQQ0lN X0NNRF9QT1JURU4sIDIpOw0KIA0KIAkvKiBkaXNhYmxlIExlZ2FjeSBJTyAq Lw0KIAlzd2l0Y2ggKHNjLT5jaGlwc2V0KSB7DQo= --830102327-1676614541-1391380498=:33534--