From owner-freebsd-current@freebsd.org Wed Apr 4 17:23:33 2018 Return-Path: Delivered-To: freebsd-current@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id C2A6EF9E6A6 for ; Wed, 4 Apr 2018 17:23:33 +0000 (UTC) (envelope-from agapon@gmail.com) Received: from mail-wr0-f178.google.com (mail-wr0-f178.google.com [209.85.128.178]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 36C308712E for ; Wed, 4 Apr 2018 17:23:33 +0000 (UTC) (envelope-from agapon@gmail.com) Received: by mail-wr0-f178.google.com with SMTP id 80so23993687wrb.2 for ; Wed, 04 Apr 2018 10:23:33 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:openpgp:autocrypt :message-id:date:user-agent:mime-version:in-reply-to :content-language:content-transfer-encoding; bh=jL/tF5COeU9t9NUO3v5ifZZ91JPzgCTQgusGyLT8cEg=; b=Ph6MsUTTryV1mLMsdC1IujoQX5acH74gw98iaMsVXr+OQYkOAeXu4uusutnkOxfw81 W6MDlLGt/lvmFWDn7LdIJTyCRlTCSEgYRPgcNqDPuIy5LPi7yuOnkZuc4FoZMUr8zKGn ZsgzTVCbnXLcCMkeY/5drmbIIhE/UjvvUgx/400G/xxzPp1sK8BzaXvE0pTiVg6HAQJ4 YoHkNdURuAFB399PIMS9RUFXdf48N2J8AgfewG9fWoXkZSicstM+Q9eC6TLC0SB5nA2q DC1qw/JfFvNDQodWcWSZBW6a1QHSp+xLqk/zaqRrBXhxULNgkq1P/liLGMOJ957BNG0A J5mw== X-Gm-Message-State: ALQs6tC0E/2jA15NMFHi0qKgw+71PSjs8gzUMzRxtcb4TXfyk/MFVDlq zTlWIOpRVyZ9g9A+yCLEW2Ie/R/s X-Google-Smtp-Source: AIpwx49a1kodAlkAU+QKtP5AowuxH2gyqNIup0V2zfOtkmc0e8Kz+FgO2U801tO5erFDEm3PdXcRSQ== X-Received: by 2002:a19:d2c1:: with SMTP id j184-v6mr6474183lfg.62.1522862220942; Wed, 04 Apr 2018 10:17:00 -0700 (PDT) Received: from [192.168.0.88] (east.meadow.volia.net. [93.72.151.96]) by smtp.googlemail.com with ESMTPSA id 63-v6sm1097278lfr.61.2018.04.04.10.16.59 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Wed, 04 Apr 2018 10:17:00 -0700 (PDT) Subject: Re: Strange ARC/Swap/CPU on yesterday's -CURRENT To: Mark Millard Cc: freebsd-current@freebsd.org References: <20180317103915.081ca2dd@thor.intern.walstatt.dynvpn.de> From: Andriy Gapon Openpgp: preference=signencrypt Autocrypt: addr=avg@FreeBSD.org; prefer-encrypt=mutual; keydata= xsFNBFm4LIgBEADNB/3lT7f15UKeQ52xCFQx/GqHkSxEdVyLFZTmY3KyNPQGBtyvVyBfprJ7 mAeXZWfhat6cKNRAGZcL5EmewdQuUfQfBdYmKjbw3a9GFDsDNuhDA2QwFt8BmkiVMRYyvI7l N0eVzszWCUgdc3qqM6qqcgBaqsVmJluwpvwp4ZBXmch5BgDDDb1MPO8AZ2QZfIQmplkj8Y6Z AiNMknkmgaekIINSJX8IzRzKD5WwMsin70psE8dpL/iBsA2cpJGzWMObVTtCxeDKlBCNqM1i gTXta1ukdUT7JgLEFZk9ceYQQMJJtUwzWu1UHfZn0Fs29HTqawfWPSZVbulbrnu5q55R4PlQ /xURkWQUTyDpqUvb4JK371zhepXiXDwrrpnyyZABm3SFLkk2bHlheeKU6Yql4pcmSVym1AS4 dV8y0oHAfdlSCF6tpOPf2+K9nW1CFA8b/tw4oJBTtfZ1kxXOMdyZU5fiG7xb1qDgpQKgHUX8 7Rd2T1UVLVeuhYlXNw2F+a2ucY+cMoqz3LtpksUiBppJhw099gEXehcN2JbUZ2TueJdt1FdS ztnZmsHUXLxrRBtGwqnFL7GSd6snpGIKuuL305iaOGODbb9c7ne1JqBbkw1wh8ci6vvwGlzx rexzimRaBzJxlkjNfMx8WpCvYebGMydNoeEtkWldtjTNVsUAtQARAQABzR5BbmRyaXkgR2Fw b24gPGF2Z0BGcmVlQlNELm9yZz7CwZQEEwEIAD4WIQS+LEO7ngQnXA4Bjr538m7TUc1yjwUC WbgsiAIbIwUJBaOagAULCQgHAgYVCAkKCwIEFgIDAQIeAQIXgAAKCRB38m7TUc1yj+JAEACV l9AK/nOWAt/9cufV2fRj0hdOqB1aCshtSrwHk/exXsDa4/FkmegxXQGY+3GWX3deIyesbVRL rYdtdK0dqJyT1SBqXK1h3/at9rxr9GQA6KWOxTjUFURsU7ok/6SIlm8uLRPNKO+yq0GDjgaO LzN+xykuBA0FlhQAXJnpZLcVfPJdWv7sSHGedL5ln8P8rxR+XnmsA5TUaaPcbhTB+mG+iKFj GghASDSfGqLWFPBlX/fpXikBDZ1gvOr8nyMY9nXhgfXpq3B6QCRYKPy58ChrZ5weeJZ29b7/ QdEO8NFNWHjSD9meiLdWQaqo9Y7uUxN3wySc/YUZxtS0bhAd8zJdNPsJYG8sXgKjeBQMVGuT eCAJFEYJqbwWvIXMfVWop4+O4xB+z2YE3jAbG/9tB/GSnQdVSj3G8MS80iLS58frnt+RSEw/ psahrfh0dh6SFHttE049xYiC+cM8J27Aaf0i9RflyITq57NuJm+AHJoU9SQUkIF0nc6lfA+o JRiyRlHZHKoRQkIg4aiKaZSWjQYRl5Txl0IZUP1dSWMX4s3XTMurC/pnja45dge/4ESOtJ9R 8XuIWg45Oq6MeIWdjKddGhRj3OohsltKgkEU3eLKYtB6qRTQypHHUawCXz88uYt5e3w4V16H lCpSTZV/EVHnNe45FVBlvK7k7HFfDDkryM7BTQRZuCyIARAAlq0slcsVboY/+IUJdcbEiJRW be9HKVz4SUchq0z9MZPX/0dcnvz/gkyYA+OuM78dNS7Mbby5dTvOqfpLJfCuhaNYOhlE0wY+ 1T6Tf1f4c/uA3U/YiadukQ3+6TJuYGAdRZD5EqYFIkreARTVWg87N9g0fT9BEqLw9lJtEGDY EWUE7L++B8o4uu3LQFEYxcrb4K/WKmgtmFcm77s0IKDrfcX4doV92QTIpLiRxcOmCC/OCYuO jB1oaaqXQzZrCutXRK0L5XN1Y1PYjIrEzHMIXmCDlLYnpFkK+itlXwlE2ZQxkfMruCWdQXye syl2fynAe8hvp7Mms9qU2r2K9EcJiR5N1t1C2/kTKNUhcRv7Yd/vwusK7BqJbhlng5ZgRx0m WxdntU/JLEntz3QBsBsWM9Y9wf2V4tLv6/DuDBta781RsCB/UrU2zNuOEkSixlUiHxw1dccI 6CVlaWkkJBxmHX22GdDFrcjvwMNIbbyfQLuBq6IOh8nvu9vuItup7qemDG3Ms6TVwA7BD3j+ 3fGprtyW8Fd/RR2bW2+LWkMrqHffAr6Y6V3h5kd2G9Q8ZWpEJk+LG6Mk3fhZhmCnHhDu6CwN MeUvxXDVO+fqc3JjFm5OxhmfVeJKrbCEUJyM8ESWLoNHLqjywdZga4Q7P12g8DUQ1mRxYg/L HgZY3zfKOqcAEQEAAcLBfAQYAQgAJhYhBL4sQ7ueBCdcDgGOvnfybtNRzXKPBQJZuCyIAhsM BQkFo5qAAAoJEHfybtNRzXKPBVwQAKfFy9P7N3OsLDMB56A4Kf+ZT+d5cIx0Yiaf4n6w7m3i ImHHHk9FIetI4Xe54a2IXh4Bq5UkAGY0667eIs+Z1Ea6I2i27Sdo7DxGwq09Qnm/Y65ADvXs 3aBvokCcm7FsM1wky395m8xUos1681oV5oxgqeRI8/76qy0hD9WR65UW+HQgZRIcIjSel9vR XDaD2HLGPTTGr7u4v00UeTMs6qvPsa2PJagogrKY8RXdFtXvweQFz78NbXhluwix2Tb9ETPk LIpDrtzV73CaE2aqBG/KrboXT2C67BgFtnk7T7Y7iKq4/XvEdDWscz2wws91BOXuMMd4c/c4 OmGW9m3RBLufFrOag1q5yUS9QbFfyqL6dftJP3Zq/xe+mr7sbWbhPVCQFrH3r26mpmy841ym dwQnNcsbIGiBASBSKksOvIDYKa2Wy8htPmWFTEOPRpFXdGQ27awcjjnB42nngyCK5ukZDHi6 w0qK5DNQQCkiweevCIC6wc3p67jl1EMFY5+z+zdTPb3h7LeVnGqW0qBQl99vVFgzLxchKcl0 R/paSFgwqXCZhAKMuUHncJuynDOP7z5LirUeFI8qsBAJi1rXpQoLJTVcW72swZ42IdPiboqx NbTMiNOiE36GqMcTPfKylCbF45JNX4nF9ElM0E+Y8gi4cizJYBRr2FBJgay0b9Cp Message-ID: <1b31e36e-e84b-cc63-1422-d1e0ce2f03c8@FreeBSD.org> Date: Wed, 4 Apr 2018 20:16:58 +0300 User-Agent: Mozilla/5.0 (X11; FreeBSD amd64; rv:52.0) Gecko/20100101 Thunderbird/52.7.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit X-BeenThere: freebsd-current@freebsd.org X-Mailman-Version: 2.1.25 Precedence: list List-Id: Discussions about the use of FreeBSD-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 04 Apr 2018 17:23:34 -0000 On 01/04/2018 05:31, Mark Millard wrote: > I have a hypothesis for part of what top is > counting in the process/thread SWAP column > that might not be what one would expect. > > It appears to me that vnode-backed pages are > being re-classfied sometimes for inactive > processes, and this classification leads to > top classifying the pages as not-resident > but swapped (in that a "VN PAGER in" would > be required, in systat -vmstat terms). Not sure. To me it seems that top just uses wrong statistics to calculate the value. /* swap usage */ #define ki_swap(kip) \ ((kip)->ki_swrss > (kip)->ki_rssize ? (kip)->ki_swrss - (kip)->ki_rssize : 0) ki_rssize is the resident size of a process. ki_swrss is resident set size before last swap. Their difference is... exactly what? I cannot even meaningfully describe this value. But it is certainly _not_ the current swap utilization by the process. Here is my attempt at obtaining a more reasonable approximation of the. process swap use. But it is still wildly inaccurate. diff --git a/usr.bin/top/machine.c b/usr.bin/top/machine.c index 2d97d7f867f36..361a1542e6e16 100644 --- a/usr.bin/top/machine.c +++ b/usr.bin/top/machine.c @@ -233,12 +233,13 @@ static int carc_enabled; static int pageshift; /* log base 2 of the pagesize */ /* define pagetok in terms of pageshift */ - -#define pagetok(size) ((size) << pageshift) +#define pagetok(size) ((size) << (pageshift - LOG1024)) +#define btopage(size) ((size) >> pageshift) /* swap usage */ #define ki_swap(kip) \ - ((kip)->ki_swrss > (kip)->ki_rssize ? (kip)->ki_swrss - (kip)->ki_rssize : 0) + (btopage((kip)->ki_size) > (kip)->ki_rssize ? \ + btopage((kip)->ki_size) - (kip)->ki_rssize : 0) /* useful externals */ long percentages(int cnt, int *out, long *new, long *old, long *diffs); @@ -384,9 +385,6 @@ machine_init(struct statics *statics, char do_unames) pagesize >>= 1; } - /* we only need the amount of log(2)1024 for our conversion */ - pageshift -= LOG1024; - /* fill in the statics information */ statics->procstate_names = procstatenames; statics->cpustate_names = cpustatenames; @@ -1374,7 +1372,7 @@ static int sorted_state[] = { } while (0) #define ORDERKEY_SWAP(a, b) do { \ - int diff = (int)ki_swap(b) - (int)ki_swap(a); \ + int diff = (long)ki_swap(b) - (long)ki_swap(a); \ if (diff != 0) \ return (diff > 0 ? 1 : -1); \ } while (0) -- Andriy Gapon