From owner-svn-src-all@freebsd.org Fri Jan 26 04:52:21 2018 Return-Path: Delivered-To: svn-src-all@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id D216EEC01CC for ; Fri, 26 Jan 2018 04:52:20 +0000 (UTC) (envelope-from wlosh@bsdimp.com) Received: from mail-wm0-x22f.google.com (mail-wm0-x22f.google.com [IPv6:2a00:1450:400c:c09::22f]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 3E5F182BA8 for ; Fri, 26 Jan 2018 04:52:20 +0000 (UTC) (envelope-from wlosh@bsdimp.com) Received: by mail-wm0-x22f.google.com with SMTP id f71so18567473wmf.0 for ; Thu, 25 Jan 2018 20:52:19 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bsdimp-com.20150623.gappssmtp.com; s=20150623; h=mime-version:sender:in-reply-to:references:from:date:message-id :subject:to:cc; bh=JcoqqCfawUSJ6wbcyMxRX/0aLNWjeF5eUt0+80rSeiE=; b=O1glz+kXDEWgsQ/JJSNlUPgv2pRlnGBlCtiQWN0Ep+SXJF/jFJMuJjDp2yIwlHMhkY KmCQHoq6qxloWLeXBu0UTfPKPwAkiDlQ8J9RiPlHf5rpcELYGVnn/eUREu9zD+lrrjsx PyiwQ3FCVaS/4k9ocztSyXIiFmS801/fPc5rdeSNBoluh4txmSAYqr0OjzZD+l5hLZrC /ewBNBe+l52nic4dLDvaK3+uo32fXiiB2BFj5A43fC15kAYvf9F1k0DAUEXOyJZxu7tt IppFK7RZlI9LEAUA2AeDwIEs+C09ofgOO9SjQnoZOD/y4PIpLHH1QvlN17lGnph3i4xH DctQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:sender:in-reply-to:references:from :date:message-id:subject:to:cc; bh=JcoqqCfawUSJ6wbcyMxRX/0aLNWjeF5eUt0+80rSeiE=; b=ChUE75sKgrQOpNnrN9uudlYx651iKiEqJ7SEbnbKSGAv6FtSI9WrHQAGsb2cw+qb8+ sbWQJctYjqcaoYOW2NDZt29dG1fLPrmedZS9Ci5jqPtzAlcQ/4SXtfw2XV0MD97bj6J3 XpwGgCTaGypaXnLzySVrB0vQgvG5HUy/HGfauO7Jl1thbWuZzkFBH1ddx27WQ91Yzoxg a3dpKvaMvwswfokZmaCCOJIPDTYK5n+N/7Wvrcbv2sEK9vjBWgYQdKOXvmoUMmx/1jLV AXLGxIua6a5m8j9wB+zALzGjmGjvHvHOc+74GpOyDAZaQ4Si98kRelqNVi+CSpxFZtAR ZBew== X-Gm-Message-State: AKwxytf7eOuq+qK3D5um/5KlVCfEo+YVjgV2h1CYpUzM1u7L0WNwpPWq XjFdT5hNbGKzoY1EV1BRzjKT3Cttn8K/QLqnLWiIUA== X-Google-Smtp-Source: AH8x227/KGjrSAWL1CQQ+LAANZFJP9IDA41XPgI/ZnRhaaLTnVmqbNT376IASMmyIOrAKWNPmnKyfPRTRRvZNmuIarM= X-Received: by 10.80.170.24 with SMTP id o24mr32260411edc.258.1516942338297; Thu, 25 Jan 2018 20:52:18 -0800 (PST) MIME-Version: 1.0 Sender: wlosh@bsdimp.com Received: by 10.80.165.93 with HTTP; Thu, 25 Jan 2018 20:52:09 -0800 (PST) X-Originating-IP: [2603:300b:6:5100:18a2:a4f7:170:8dd9] In-Reply-To: <201801260440.w0Q4efhg008105@repo.freebsd.org> References: <201801260440.w0Q4efhg008105@repo.freebsd.org> From: Warner Losh Date: Thu, 25 Jan 2018 21:52:09 -0700 X-Google-Sender-Auth: ZnOEj3Y8iYf-WVFJEbhpK_5Sycc Message-ID: Subject: Re: svn commit: r328430 - head/sbin/devd To: Eitan Adler Cc: src-committers , svn-src-all@freebsd.org, svn-src-head@freebsd.org Content-Type: text/plain; charset="UTF-8" X-Content-Filtered-By: Mailman/MimeDel 2.1.25 X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.25 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 26 Jan 2018 04:52:21 -0000 On Thu, Jan 25, 2018 at 9:40 PM, Eitan Adler wrote: > Author: eadler > Date: Fri Jan 26 04:40:41 2018 > New Revision: 328430 > URL: https://svnweb.freebsd.org/changeset/base/328430 > > Log: > devd: minor nits > > - mark usage as noreturn > - config does not need a virtual destructor > Everything needs a virtual destructor... Please back that part of this out... Warner > Modified: > head/sbin/devd/devd.cc > head/sbin/devd/devd.hh > > Modified: head/sbin/devd/devd.cc > ============================================================ > ================== > --- head/sbin/devd/devd.cc Fri Jan 26 04:32:31 2018 (r328429) > +++ head/sbin/devd/devd.cc Fri Jan 26 04:40:41 2018 (r328430) > @@ -161,7 +161,7 @@ static const char *configfile = CF; > static void devdlog(int priority, const char* message, ...) > __printflike(2, 3); > static void event_loop(void); > -static void usage(void); > +static void usage(void) __dead2; > > template void > delete_and_clear(vector &v) > > Modified: head/sbin/devd/devd.hh > ============================================================ > ================== > --- head/sbin/devd/devd.hh Fri Jan 26 04:32:31 2018 (r328429) > +++ head/sbin/devd/devd.hh Fri Jan 26 04:40:41 2018 (r328430) > @@ -147,7 +147,7 @@ class config > { > public: > config() { push_var_table(); } > - virtual ~config() { reset(); } > + ~config() { reset(); } > void add_attach(int, event_proc *); > void add_detach(int, event_proc *); > void add_directory(const char *); > >