From owner-cvs-src-old@FreeBSD.ORG Wed Mar 10 13:23:51 2010 Return-Path: Delivered-To: cvs-src-old@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 935911065672 for ; Wed, 10 Mar 2010 13:23:51 +0000 (UTC) (envelope-from jhb@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [IPv6:2001:4f8:fff6::29]) by mx1.freebsd.org (Postfix) with ESMTP id 80D568FC19 for ; Wed, 10 Mar 2010 13:23:51 +0000 (UTC) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.14.3/8.14.3) with ESMTP id o2ADNp20063107 for ; Wed, 10 Mar 2010 13:23:51 GMT (envelope-from jhb@repoman.freebsd.org) Received: (from svn2cvs@localhost) by repoman.freebsd.org (8.14.3/8.14.3/Submit) id o2ADNpiH063106 for cvs-src-old@freebsd.org; Wed, 10 Mar 2010 13:23:51 GMT (envelope-from jhb@repoman.freebsd.org) Message-Id: <201003101323.o2ADNpiH063106@repoman.freebsd.org> X-Authentication-Warning: repoman.freebsd.org: svn2cvs set sender to jhb@repoman.freebsd.org using -f From: John Baldwin Date: Wed, 10 Mar 2010 13:23:25 +0000 (UTC) To: cvs-src-old@freebsd.org X-FreeBSD-CVS-Branch: HEAD Subject: cvs commit: src/lib/libc/rpc Symbol.map clnt_simple.c getnetconfig.c key_call.c mt_misc.c mt_misc.h rpc_generic.c rpc_soc.c X-BeenThere: cvs-src-old@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: **OBSOLETE** CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 10 Mar 2010 13:23:51 -0000 jhb 2010-03-10 13:23:25 UTC FreeBSD src repository Modified files: lib/libc/rpc Symbol.map clnt_simple.c getnetconfig.c key_call.c mt_misc.c mt_misc.h rpc_generic.c rpc_soc.c Log: SVN rev 204950 on 2010-03-10 13:23:25Z by jhb Use thr_once() with once_t controls to initialize various thread_key_t objects used to provide per-thread storage in the RPC code. Almost all of these used double-checking with a dedicated mutex (tsd_lock) to do this before. However, that is not always safe with more relaxed memory orders. There were also other bugs, such as one in __rpc_createrr() that caused a new key to be allocated each time __rpc_createrr() was invoked. PR: threads/144558 Reported by: Sam Robb samrobb of averesystems com (key leak) MFC after: 1 week Revision Changes Path 1.5 +0 -4 src/lib/libc/rpc/Symbol.map 1.21 +16 -6 src/lib/libc/rpc/clnt_simple.c 1.18 +15 -14 src/lib/libc/rpc/getnetconfig.c 1.18 +13 -7 src/lib/libc/rpc/key_call.c 1.8 +13 -14 src/lib/libc/rpc/mt_misc.c 1.3 +0 -1 src/lib/libc/rpc/mt_misc.h 1.15 +15 -12 src/lib/libc/rpc/rpc_generic.c 1.16 +9 -6 src/lib/libc/rpc/rpc_soc.c