From owner-freebsd-ports@FreeBSD.ORG Thu Oct 28 08:34:40 2010 Return-Path: Delivered-To: freebsd-ports@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id C2171106564A for ; Thu, 28 Oct 2010 08:34:40 +0000 (UTC) (envelope-from lupe@lupe-christoph.de) Received: from buexe.b-5.de (buexe.b-5.de [84.19.0.30]) by mx1.freebsd.org (Postfix) with ESMTP id 5394B8FC12 for ; Thu, 28 Oct 2010 08:34:39 +0000 (UTC) Received: from alanya.lupe-christoph.de (alanya.lupe-christoph.de [172.17.0.19]) by buexe.b-5.de (8.13.8/8.13.8/b-5/buexe-3.6.3) with ESMTP id o9S8NWGj012739; Thu, 28 Oct 2010 10:23:32 +0200 Received: from localhost (localhost [127.0.0.1]) by alanya.lupe-christoph.de (Postfix) with ESMTP id 0BE7F2C3BF; Thu, 28 Oct 2010 10:23:27 +0200 (CEST) X-Virus-Scanned: Debian amavisd-new at lupe-christoph.de Received: from alanya.lupe-christoph.de ([127.0.0.1]) by localhost (alanya.lupe-christoph.de [127.0.0.1]) (amavisd-new, port 10024) with LMTP id wlj++wz79uUw; Thu, 28 Oct 2010 10:23:26 +0200 (CEST) Received: by alanya.lupe-christoph.de (Postfix, from userid 1000) id 2380F2C3F4; Thu, 28 Oct 2010 10:23:26 +0200 (CEST) Date: Thu, 28 Oct 2010 10:23:26 +0200 From: Lupe Christoph To: Dag-Erling =?iso-8859-15?Q?Sm=F8rgrav?= Message-ID: <20101028082325.GB7792@lupe-christoph.de> References: <86fwvrzfpy.fsf@ds4.des.no> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-15 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <86fwvrzfpy.fsf@ds4.des.no> User-Agent: Mutt/1.5.20 (2009-06-14) Cc: "Ilya A. Arhipov" , freebsd-ports@freebsd.org Subject: Re: exception bash(and few plugins) of munin X-BeenThere: freebsd-ports@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Porting software to FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 28 Oct 2010 08:34:40 -0000 On Wednesday, 2010-10-27 at 19:51:37 +0200, Dag-Erling Smørgrav wrote: > "Ilya A. Arhipov" writes: > > Maybe exclude these plugins of Munin and bash:${PORTSDIR}/shells/bash > > of Makefiles. install bash, for these 5 plugins i think not correct, > > old version don't have these plugins There are five plugins that use "#!@@BASH@@" and one that uses "#!/bin/bash". That one is only used to test multigraphs, so it is not really important. But I believe it should be fixed in Munin 1.4.6. > I don't see the problem. The munin-node port has no DEPENDS for ports that are required for plugins, e.g. Python, because that would pull in a lot of software the user does not need because he will not use those plugins. Generally, plugins tell you if they are missing something. This will of course not work for interpreters needed to execute the plugin itself. I don't know why revision 1.30 of the port Makefile added bash, but presumably not for scripts that have a shebang of "#!/bin/bash"... This leaves only munin-check apart from some plugins. Last time I looked, munin-check did not work. Also, munin-check is part of the master, not the node. So there does not seem to be a need to DEPEND on bash for munin-node. I will ask the Munin maintainers to do something about the "#!/bin/bash". Lupe Christoph -- | It is a well-known fact in any organisation that, if you want a job | | done, you should give it to someone who is already very busy. | | Terry Pratchett, "Unseen Academicals" |