From owner-freebsd-hackers@FreeBSD.ORG Tue May 3 21:36:46 2011 Return-Path: Delivered-To: freebsd-hackers@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 91F2D1065677 for ; Tue, 3 May 2011 21:36:46 +0000 (UTC) (envelope-from jhb@freebsd.org) Received: from cyrus.watson.org (cyrus.watson.org [65.122.17.42]) by mx1.freebsd.org (Postfix) with ESMTP id 68D2C8FC08 for ; Tue, 3 May 2011 21:36:46 +0000 (UTC) Received: from bigwig.baldwin.cx (66.111.2.69.static.nyinternet.net [66.111.2.69]) by cyrus.watson.org (Postfix) with ESMTPSA id DB15746B43; Tue, 3 May 2011 17:36:45 -0400 (EDT) Received: from jhbbsd.localnet (unknown [209.249.190.124]) by bigwig.baldwin.cx (Postfix) with ESMTPSA id 767C18A01B; Tue, 3 May 2011 17:36:45 -0400 (EDT) From: John Baldwin To: "Devin Teske" Date: Tue, 3 May 2011 17:31:48 -0400 User-Agent: KMail/1.13.5 (FreeBSD/8.2-CBSD-20110325; KDE/4.5.5; amd64; ; ) References: <9B387DE4-6866-4208-A8FC-6516D651F6A5@vicor.com> <201105031701.25774.jhb@freebsd.org> <006401cc09d8$30974e30$91c5ea90$@vicor.com> In-Reply-To: <006401cc09d8$30974e30$91c5ea90$@vicor.com> MIME-Version: 1.0 Content-Type: Text/Plain; charset="iso-8859-1" Content-Transfer-Encoding: 7bit Message-Id: <201105031731.49236.jhb@freebsd.org> X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.2.6 (bigwig.baldwin.cx); Tue, 03 May 2011 17:36:45 -0400 (EDT) Cc: freebsd-hackers@freebsd.org Subject: Re: [UPDATE] New Boot-Loader Menu -- version 1.1 X-BeenThere: freebsd-hackers@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Technical Discussions relating to FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 03 May 2011 21:36:46 -0000 On Tuesday, May 03, 2011 5:22:20 pm Devin Teske wrote: > > -----Original Message----- > > From: John Baldwin [mailto:jhb@freebsd.org] > > Sent: Tuesday, May 03, 2011 2:01 PM > > To: Devin Teske > > Cc: freebsd-hackers@freebsd.org > > Subject: Re: [UPDATE] New Boot-Loader Menu -- version 1.1 > > > > On Tuesday, May 03, 2011 4:47:26 pm Devin Teske wrote: > > > > -----Original Message----- > > > > From: John Baldwin [mailto:jhb@freebsd.org] > > > > Sent: Tuesday, May 03, 2011 1:36 PM > > > > To: Devin Teske > > > > Cc: freebsd-hackers@freebsd.org > > > > Subject: Re: [UPDATE] New Boot-Loader Menu -- version 1.1 > > > > > > > > On Tuesday, May 03, 2011 4:17:23 pm Devin Teske wrote: > > > > > > -----Original Message----- > > > > > > From: John Baldwin [mailto:jhb@freebsd.org] > > > > > > Sent: Tuesday, May 03, 2011 12:20 PM > > > > > > To: Devin Teske > > > > > > Cc: freebsd-hackers@freebsd.org > > > > > > Subject: Re: [UPDATE] New Boot-Loader Menu -- version 1.1 > > > > > > > > > > > > On Tuesday, May 03, 2011 2:57:34 pm Devin Teske wrote: > > > > > > > > From: John Baldwin [mailto:jhb@freebsd.org] > > > > > > > > Sent: Tuesday, May 03, 2011 10:33 AM > > > > > > > > To: Devin Teske > > > > > > > > Cc: freebsd-hackers@freebsd.org; Olivier SMEDTS > > > > > > > > Subject: Re: [UPDATE] New Boot-Loader Menu -- version 1.1 > > > > > > > > > > > > > > > > On Tuesday, May 03, 2011 12:31:14 pm Devin Teske wrote: > > > > > > > > > > > > > > > > > > On May 3, 2011, at 4:45 AM, John Baldwin wrote: > > > > > > > > > > > > > > > > > > > On Monday, May 02, 2011 8:48:31 pm Devin Teske wrote: > > > > > > > > > > > This version (1.1) works nearly identically to the > > > > > > > > > > > standard menu that ships with FreeBSD in that it > > > > > > > > > > > detects whether ACPI is enabled (truth be told, I > > > > > > > > > > > actually re-used the > > > > "acpienabled?" > > > > > > > > > > > function verbatim from /boot/beastie.4th by Scott Long > > > > > > > > > > > and Aleksander Fafula). The ACPI detection of my boot > > > > > > > > > > > loader (version > > > > > > > > > > > 1.1 or higher) should be identical to the detection of > > > > > > > > > > > the current boot-loader. > > > > > > > > > > > > > > > > > > Ugh. By "current", I meant 8.1-RELEASE (wasn't expecting > > > > > > > > > this stuff to be different in HEAD, which it is). > > > > > > > > > > > > > > > > > > > > > > > > > > > > Err, note that the acpienabled stuff is all different in > > > > > > > > > > HEAD than in 7/8 since acpi.ko no longer exists. You > > > > > > > > > > should use the scheme from HEAD for handling ACPI > > > > > > > > > > present vs ACPI > > > > enabled/disabled. > > > > > > > > > > > > > > > > > > > > -- > > > > > > > > > > John Baldwin > > > > > > > > > > > > > > > > > > > > > > > > > > > Ok, I see the new "acpipresent?" word (which replaces the > > > "arch-i386" > > > > > > > > > environment-test). Does this imply that we're going to > > > > > > > > > support ACPI on > > > > > > > > > non-i386 platforms (or already do)? > > > > > > > > > > > > > > > > amd64 and ia64 have always supported ACPI. ia64 effectively > > > > > > > > requires > > > it. > > > > > > > > However, "hint.acpi.0.rsdp" is set by biosacpi.c in the i386 > > > > > > > > loader bits, so other platforms will not set it, so the > > > > > > > > arch-i386 test is no longer > > > > > > > needed. > > > > > > > > > > > > > > If "hint.acpi.0.rsdp" is only set in the i386 pieces, wouldn't > > > > > > > that imply that the "acpipresent?" would return FALSE on IA64? > > > > > > > > > > > > Yes. Right now the ACPI menu item is not displayed on ia64 and > > > > > > it never has been. You can't actually boot IA64 with ACPI > > > > > > disabled, so there's no reason > > > > > for it > > > > > > to be in the menu. > > > > > > > > > > This raises a concern for my menu. Unlike the current menu, which > > > > > blanks-out menuitem #2 for IA64, I've chosen instead to insert an > > > > > inoperative menuitem with the text "ACPI Support: N/A". > > > > > > > > Hmm, I think you should just leave the menu item blank or not > > > > listed. It > > > doesn't > > > > make sense to see a knob about ACPI support on a ppc box for > > > > example, and other platforms may grow platform-specific knobs in the > future > > as well. > > > > > > > > The current menu item is only blank as a hack to avoid renumbering the > > items. > > > > If you are already changing that around, then I'd just leave it out > > > > altogether unless ACPI is detected by the loader. > > > > > > > > > > I too avoid renumbering of the items. > > > > > > Having never actually booted a PPC or IA64 FreeBSD installation... is > > > it the case that the numbers displayed jump from 1 to 3 (no blank line > > > in-between 1 and 3, correct)? > > > > Actually, I think PPC/IA64, etc. do not display the ACPI menu item at all and > they > > are numbered differently from i386 and amd64. The ACPI menu item is only > > blank if ACPI is not present on i386 and amd64. > > > > You're absolutely right. I looked closer at the Forth in HEAD, and indeed you're > right. > > "arch-i386" will always allocate a #2 to ACPI, but will only display it when > "hint.acpi.0.rsdp" is set whereas non-i386 architectures will assign #2 to the > next menuitem (Safe Mode). > > I'll make a new version that mimics this behavior. > > The overall goal is to: > a. Satisfy everbody on -hackers. > b. Announce final version on -questions and -announce for broader audience. > c. Try to satisfy critical concerns. > d. Approach -core about using it in base > > Think I have a shot at (d)? Well, for (d) you just need to find a committer who is excited about it and wants to get it into the base system. core@ doesn't really do that as core@, per se. -- John Baldwin