From owner-svn-src-head@FreeBSD.ORG  Mon Jul 16 22:10:06 2012
Return-Path: <owner-svn-src-head@FreeBSD.ORG>
Delivered-To: svn-src-head@freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id 0782A106566B;
	Mon, 16 Jul 2012 22:10:06 +0000 (UTC)
	(envelope-from asmrookie@gmail.com)
Received: from mail-lb0-f182.google.com (mail-lb0-f182.google.com
	[209.85.217.182])
	by mx1.freebsd.org (Postfix) with ESMTP id 99F068FC16;
	Mon, 16 Jul 2012 22:10:04 +0000 (UTC)
Received: by lbon10 with SMTP id n10so10063515lbo.13
	for <multiple recipients>; Mon, 16 Jul 2012 15:10:03 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113;
	h=mime-version:reply-to:sender:in-reply-to:references:date
	:x-google-sender-auth:message-id:subject:from:to:cc:content-type;
	bh=brT2GhHfnd68e+lZY4eO5GeW7Bn/YhsovJ+BHS3iccc=;
	b=RIbbfuFidbd95iisNH0jBb6A7tvo6WiyS0rLskMX493beiOMzOO6y22ZU+GQWXbCLe
	vH3q9g66zcnAdMKI1seniq0YzQZhp4I8kfMj4mxfoe9ra9kFJJCVxAO+eYuL/3JX2/x7
	yQ647m3JhH+C1wNhite0geKKIpk5sl5QC1LPAUUzncrGZrsW6M1zc69ESvgMxmgVkiA4
	UtssaB6JPFP9wihGE3mgpekTYl105iiGsaYVcB7/dlWatwOPr070lReEJ3aoCaRkQWRA
	v0ag+wpfCH4eUjyaq4t2ScEh8sTyEU4Zu70x5PglU8ShGqjF8Zb9SOkpGB6HBI2Ip4it
	XubA==
MIME-Version: 1.0
Received: by 10.112.45.4 with SMTP id i4mr97134lbm.79.1342476603469; Mon, 16
	Jul 2012 15:10:03 -0700 (PDT)
Sender: asmrookie@gmail.com
Received: by 10.112.27.65 with HTTP; Mon, 16 Jul 2012 15:10:03 -0700 (PDT)
In-Reply-To: <201207162207.q6GM7UNS087234@svn.freebsd.org>
References: <201207162207.q6GM7UNS087234@svn.freebsd.org>
Date: Mon, 16 Jul 2012 23:10:03 +0100
X-Google-Sender-Auth: BKHfDTcRP7lbli-D1uUwO1hxsK4
Message-ID: <CAJ-FndA+EEr9OfoRz6+BP7sk_3+drxWx0zs4WbQhMLq9A0D_Pw@mail.gmail.com>
From: Attilio Rao <attilio@freebsd.org>
To: Christian Brueffer <brueffer@freebsd.org>, Mateusz Guzik <mjg@freebsd.org>
Content-Type: text/plain; charset=UTF-8
Cc: svn-src-head@freebsd.org, svn-src-all@freebsd.org,
	src-committers@freebsd.org
Subject: Re: svn commit: r238539 - head/sys/fs/smbfs
X-BeenThere: svn-src-head@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
Reply-To: attilio@FreeBSD.org
List-Id: SVN commit messages for the src tree for head/-current
	<svn-src-head.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/svn-src-head>,
	<mailto:svn-src-head-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/svn-src-head>
List-Post: <mailto:svn-src-head@freebsd.org>
List-Help: <mailto:svn-src-head-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/svn-src-head>,
	<mailto:svn-src-head-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Mon, 16 Jul 2012 22:10:06 -0000

2012/7/16 Christian Brueffer <brueffer@freebsd.org>:
> Author: brueffer
> Date: Mon Jul 16 22:07:29 2012
> New Revision: 238539
> URL: http://svn.freebsd.org/changeset/base/238539
>
> Log:
>   Simply error handling by moving the allocation of np down to where it is
>   actually used.  While here, improve style a little.

Too bad that the biggest bug here is still in place.
Right now smbfs inserts in the mount list half-constructed vnodes.
Maybe you are interested in fixing this?

Attilio


-- 
Peace can only be achieved by understanding - A. Einstein