From owner-freebsd-current@freebsd.org Fri Jan 24 16:57:35 2020 Return-Path: Delivered-To: freebsd-current@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id 36BDA1F5618 for ; Fri, 24 Jan 2020 16:57:35 +0000 (UTC) (envelope-from glebius@freebsd.org) Received: from mailman.nyi.freebsd.org (mailman.nyi.freebsd.org [IPv6:2610:1c1:1:606c::50:13]) by mx1.freebsd.org (Postfix) with ESMTP id 48450v0l8Vz4GS7 for ; Fri, 24 Jan 2020 16:57:35 +0000 (UTC) (envelope-from glebius@freebsd.org) Received: by mailman.nyi.freebsd.org (Postfix) id 1763A1F5617; Fri, 24 Jan 2020 16:57:35 +0000 (UTC) Delivered-To: current@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id 161391F5616 for ; Fri, 24 Jan 2020 16:57:35 +0000 (UTC) (envelope-from glebius@freebsd.org) Received: from cell.glebi.us (glebi.us [162.251.186.162]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) server-signature RSA-PSS (4096 bits) client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "cell.glebi.us", Issuer "cell.glebi.us" (not verified)) by mx1.freebsd.org (Postfix) with ESMTPS id 48450t3rqkz4GS6 for ; Fri, 24 Jan 2020 16:57:34 +0000 (UTC) (envelope-from glebius@freebsd.org) Received: from cell.glebi.us (localhost [127.0.0.1]) by cell.glebi.us (8.15.2/8.15.2) with ESMTPS id 00OGvRZi013589 (version=TLSv1.3 cipher=TLS_AES_256_GCM_SHA384 bits=256 verify=NO); Fri, 24 Jan 2020 08:57:27 -0800 (PST) (envelope-from glebius@freebsd.org) Received: (from glebius@localhost) by cell.glebi.us (8.15.2/8.15.2/Submit) id 00OGvQd9013588; Fri, 24 Jan 2020 08:57:26 -0800 (PST) (envelope-from glebius@freebsd.org) X-Authentication-Warning: cell.glebi.us: glebius set sender to glebius@freebsd.org using -f Date: Fri, 24 Jan 2020 08:57:26 -0800 From: Gleb Smirnoff To: Hans Petter Selasky Cc: Masachika ISHIZUKA , current@freebsd.org Subject: Re: panic: Assertion in_epoch(net_epoch_preempt) failed at ... src/sys/net/if.c:3694 Message-ID: <20200124165726.GN1268@FreeBSD.org> References: <3041901579770984@myt4-4d473ee472d6.qloud-c.yandex.net> <20200124.162344.1430316126325877949.ish@amail.plala.or.jp> <20200124.174103.1023461056313815929.ish@amail.plala.or.jp> <7f44262b-eab6-f02a-0168-365add2d0ad9@selasky.org> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: User-Agent: Mutt/1.12.2 (2019-09-21) X-Rspamd-Queue-Id: 48450t3rqkz4GS6 X-Spamd-Bar: - Authentication-Results: mx1.freebsd.org; none X-Spamd-Result: default: False [-1.51 / 15.00]; local_wl_from(0.00)[freebsd.org]; NEURAL_HAM_MEDIUM(-0.86)[-0.858,0]; NEURAL_HAM_LONG(-0.65)[-0.648,0]; ASN(0.00)[asn:27348, ipnet:162.251.186.0/24, country:US] X-BeenThere: freebsd-current@freebsd.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Discussions about the use of FreeBSD-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 24 Jan 2020 16:57:35 -0000 On Fri, Jan 24, 2020 at 01:18:26PM +0100, Hans Petter Selasky wrote: H> On 2020-01-24 09:59, Hans Petter Selasky wrote: H> > On 2020-01-24 09:41, Masachika ISHIZUKA wrote: H> >>>> 21.01.2020, 20:10, "Nick Hibma" : H> >>>>> That (with the return added, thanks Cy) worked like a charm. H> >>>> Got committed in r357038. H> >>>> Thank you for the report! H> >>> H> >>>    Hi. H> >>> H> >>>    My machine was panicked on r357061 with in_epoch in netisr.c. H> >>>    I can not capture screen. H> >> H> >>    Screenshot was uploaded to H> >> https://www.ish.org/files/panic-r357061.jpeg H> >> H> > H> > Looks like the WLAN subsystem needs some patches for EPOCH(). H> > H> > Gleb, did you do a "grep -r" for relevant functions before committing H> > the recent EPOCH changes? H> H> Can you try these two patches: H> https://reviews.freebsd.org/D23347 H> https://reviews.freebsd.org/D23348 You could just plug it with a one liner that adds IFF_NEEDSEPOCH in ieee80211_vap_attach(). Or fix ath, which I'm going to do in next five minutes. P.S. Answering your other email. Of course I did grep. Some things are untrivial and sometimes sweeping over all collection of drivers doesn't go smoothly. -- Gleb Smirnoff