Date: Fri, 24 Jan 2020 08:57:26 -0800 From: Gleb Smirnoff <glebius@freebsd.org> To: Hans Petter Selasky <hps@selasky.org> Cc: Masachika ISHIZUKA <ish@amail.plala.or.jp>, current@freebsd.org Subject: Re: panic: Assertion in_epoch(net_epoch_preempt) failed at ... src/sys/net/if.c:3694 Message-ID: <20200124165726.GN1268@FreeBSD.org> In-Reply-To: <ae6669a2-4822-d2fd-f227-c9c41f0a8a99@selasky.org> References: <EB09DB96-1717-4560-AFC5-52C8AEB5CC5B@van-laarhoven.org> <3041901579770984@myt4-4d473ee472d6.qloud-c.yandex.net> <20200124.162344.1430316126325877949.ish@amail.plala.or.jp> <20200124.174103.1023461056313815929.ish@amail.plala.or.jp> <7f44262b-eab6-f02a-0168-365add2d0ad9@selasky.org> <ae6669a2-4822-d2fd-f227-c9c41f0a8a99@selasky.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On Fri, Jan 24, 2020 at 01:18:26PM +0100, Hans Petter Selasky wrote: H> On 2020-01-24 09:59, Hans Petter Selasky wrote: H> > On 2020-01-24 09:41, Masachika ISHIZUKA wrote: H> >>>> 21.01.2020, 20:10, "Nick Hibma" <nick@van-laarhoven.org>: H> >>>>> That (with the return added, thanks Cy) worked like a charm. H> >>>> Got committed in r357038. H> >>>> Thank you for the report! H> >>> H> >>> Hi. H> >>> H> >>> My machine was panicked on r357061 with in_epoch in netisr.c. H> >>> I can not capture screen. H> >> H> >> Screenshot was uploaded to H> >> https://www.ish.org/files/panic-r357061.jpeg H> >> H> > H> > Looks like the WLAN subsystem needs some patches for EPOCH(). H> > H> > Gleb, did you do a "grep -r" for relevant functions before committing H> > the recent EPOCH changes? H> H> Can you try these two patches: H> https://reviews.freebsd.org/D23347 H> https://reviews.freebsd.org/D23348 You could just plug it with a one liner that adds IFF_NEEDSEPOCH in ieee80211_vap_attach(). Or fix ath, which I'm going to do in next five minutes. P.S. Answering your other email. Of course I did grep. Some things are untrivial and sometimes sweeping over all collection of drivers doesn't go smoothly. -- Gleb Smirnoff
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20200124165726.GN1268>