From owner-svn-ports-all@freebsd.org Wed Jan 25 23:31:42 2017 Return-Path: Delivered-To: svn-ports-all@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id E68DACC1212; Wed, 25 Jan 2017 23:31:42 +0000 (UTC) (envelope-from freebsd.contact@marino.st) Received: from shepard.synsport.com (mail.synsport.com [208.69.230.148]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id C4AB9C41; Wed, 25 Jan 2017 23:31:41 +0000 (UTC) (envelope-from freebsd.contact@marino.st) Received: by shepard.synsport.com (Postfix, from userid 80) id A101343BF3; Wed, 25 Jan 2017 17:30:05 -0600 (CST) To: Hiroki Sato Subject: Re: svn commit: r431473 - in head/devel/ocaml-findlib: . files MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Date: Wed, 25 Jan 2017 17:30:05 -0600 From: "John Marino (FreeBSD)" Cc: marino@freebsd.org, ports-committers@freebsd.org, svn-ports-all@freebsd.org, svn-ports-head@freebsd.org Reply-To: marino@freebsd.org Mail-Reply-To: marino@freebsd.org In-Reply-To: <20170126.061245.435464315637902019.hrs@allbsd.org> References: <201701141556.v0EFuUju035888@repo.freebsd.org> <20170126.061245.435464315637902019.hrs@allbsd.org> Message-ID: <91b9f4ff1e64a4a5a723bb1eb74338bd@secure.marino.st> X-Sender: freebsd.contact@marino.st User-Agent: Roundcube Webmail/0.9.1 X-BeenThere: svn-ports-all@freebsd.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: SVN commit messages for the ports tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 25 Jan 2017 23:31:43 -0000 On 2017-01-25 15:12, Hiroki Sato wrote: > John Marino wrote > in : > > fr> > +- tools/patch '@SITELIB@' '$(OCAML_SITELIB)' >findlib.conf > fr> > ++ tools/patch '@SITELIB@' '$(OCAML_SITELIB):$(OCAML_LIBDIR)' > fr> > >findlib.conf > fr> > + if ./tools/cmd_from_same_dir ocamlc; then \ > fr> > + echo 'ocamlc="ocamlc.opt"' >>findlib.conf; \ > fr> > + fi > fr> > fr> > fr> I think this change is the direct cause for math/ocaml-zarith > failing > fr> on all platforms. It's expecting a single directory, not a > fr> concatenated series of directories. > fr> > fr> What was this change supposed to address? > > Oh, I did not notice the multiple directory specification broke > math/ocaml-zarith. It was because some ocaml libraries use > OCAML_LIBDIR as the installation directory and findlib does not find > them on runtime. The problem is that a wrong directory is used in > some ports. I am working on fixing devel/ocaml-* ports after this > commit and eventually the change in question will be removed. I will > take care of math/ocaml-zarith, too. by the way, this change broke textproc/ocaml-pxp and x11-toolkits/ocaml-lablgtk2 too, but madpilot@ already patched that port to strip out the second path. It's possible several ocaml ports were broken by it. Thanks for taking care of ocaml-zarith, and maybe ocaml-pxp too. John