From owner-freebsd-net@freebsd.org Thu May 10 14:36:47 2018 Return-Path: Delivered-To: freebsd-net@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id A7880FCB81D for ; Thu, 10 May 2018 14:36:47 +0000 (UTC) (envelope-from bu7cher@yandex.ru) Received: from forward100p.mail.yandex.net (forward100p.mail.yandex.net [77.88.28.100]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client CN "forwards.mail.yandex.net", Issuer "Yandex CA" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 236978D403 for ; Thu, 10 May 2018 14:36:46 +0000 (UTC) (envelope-from bu7cher@yandex.ru) Received: from mxback7o.mail.yandex.net (mxback7o.mail.yandex.net [IPv6:2a02:6b8:0:1a2d::21]) by forward100p.mail.yandex.net (Yandex) with ESMTP id 26B805103D04; Thu, 10 May 2018 17:36:39 +0300 (MSK) Received: from smtp2j.mail.yandex.net (smtp2j.mail.yandex.net [2a02:6b8:0:801::ac]) by mxback7o.mail.yandex.net (nwsmtp/Yandex) with ESMTP id HRv7maPZbI-adsanJvp; Thu, 10 May 2018 17:36:39 +0300 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yandex.ru; s=mail; t=1525962999; bh=UWpDwL7Ch6hEpviLUFPpJt28ZxmzjwkigrBGdHYz+kM=; h=Subject:From:To:References:Message-ID:Date:In-Reply-To; b=A+IiCqkqhHKVupGypsl+vgxlX5GxPjnIhDSUecpl/17x/ci9MyC2P99HTnpg4l7YF AALQ/bE18LiEnUQCa2gn/wLBwsfLxkXh48+1boDSuiCH4AgPKMNZpV6YxyMhhrhbDW 89b5hWrcbSej6RGf4+2cZlJoGGlivC6NJG8DUCfs= Received: by smtp2j.mail.yandex.net (nwsmtp/Yandex) with ESMTPSA id 914db0Ijkp-acrKuICb; Thu, 10 May 2018 17:36:38 +0300 (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client certificate not present) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yandex.ru; s=mail; t=1525962998; bh=UWpDwL7Ch6hEpviLUFPpJt28ZxmzjwkigrBGdHYz+kM=; h=Subject:From:To:References:Message-ID:Date:In-Reply-To; b=pcbydl+d7uZPjcTFSb/QsSs30ASQQtAVU2kFSuKvEVb0UppasLpjnApfs25/FaFJm pmXGpLHCpISjc3pAU4Ymcd0y9ArU7KPyg3XKIbdRr0r2E3QzxzJ49gGTpWa2xhlOOs BXouOAwTIxWwzXmz/NExPt4ICXw4TDYPzXcHeU28= Authentication-Results: smtp2j.mail.yandex.net; dkim=pass header.i=@yandex.ru Subject: Re: kernel: in6_delayed_cksum: delayed m_pullup From: "Andrey V. Elsukov" To: Dries Michiels , "freebsd-net@freebsd.org" References: <5ae60f44.1c69fb81.ee4a5.1043@mx.google.com> Openpgp: id=E6591E1B41DA1516F0C9BC0001C5EA0410C8A17A Autocrypt: addr=bu7cher@yandex.ru; prefer-encrypt=mutual; keydata= xsBNBEwBF1kBCADB9sXFhBEUy8qQ4X63Y8eBatYMHGEFWN9ypS5lI3RE6qQW2EYbxNk7qUC5 21YIIS1mMFVBEfvR7J9uc7yaYgFCEb6Sce1RSO4ULN2mRKGHP3/Sl0ijZEjWHV91hY1YTHEF ZW/0GYinDf56sYpDDehaBF5wkWIo1+QK5nmj3vl0DIDCMNd7QEiWpyLVwECgLX2eOAXByT8B bCqVhJGcG6iFP7/B9Ll6uX5gb8thM9LM+ibwErDBVDGiOgvfxqidab7fdkh893IBCXa82H9N CNwnEtcgzh+BSKK5BgvPohFMgRwjti37TSxwLu63QejRGbZWSz3OK3jMOoF63tCgn7FvABEB AAHNIkFuZHJleSBWLiBFbHN1a292IDxhZUBmcmVlYnNkLm9yZz7CwHsEEwECACUCGwMGCwkI BwMCBhUIAgkKCwQWAgMBAh4BAheABQJMB/ruAhkBAAoJEAHF6gQQyKF6MLwH/3Ri/TZl9uo0 SepYWXOnxL6EaDVXDA+dLb1eLKC4PRBBjX29ttQ0KaWapiE6y5/AfzOPmRtHLrHYHjd/aiHX GMLHcYRXD+5GvdkK8iMALrZ28X0JXyuuZa8rAxWIWmCbYHNSBy2unqWgTI04Erodk90IALgM 9JeHN9sFqTM6zalrMnTzlcmel4kcjT3lyYw3vOKgoYLtsLhKZSbJoVVVlvRlGBpHFJI5AoYJ SyfXoN0rcX6k9X7Isp2K50YjqxV4v78xluh1puhwZyC0p8IShPrmrp9Oy9JkMX90o6UAXdGU KfdExJuGJfUZOFBTtNIMNIAKfMTjhpRhxONIr0emxxDOwE0ETAEXWQEIAJ2p6l9LBoqdH/0J PEFDY2t2gTvAuzz+8zs3R03dFuHcNbOwjvWCG0aOmVpAzkRa8egn5JB4sZaFUtKPYJEQ1Iu+ LUBwgvtXf4vWpzC67zs2dDuiW4LamH5p6xkTD61aHR7mCB3bg2TUjrDWn2Jt44cvoYxj3dz4 S49U1rc9ZPgD5axCNv45j72tggWlZvpefThP7xT1OlNTUqye2gAwQravXpZkl5JG4eOqJVIU X316iE3qso0iXRUtO7OseBf0PiVmk+wCahdreHOeOxK5jMhYkPKVn7z1sZiB7W2H2TojbmcK HZC22sz7Z/H36Lhg1+/RCnGzdEcjGc8oFHXHCxUAEQEAAcLAXwQYAQIACQUCTAEXWQIbDAAK CRABxeoEEMihegkYCAC3ivGYNe2taNm/4Nx5GPdzuaAJGKWksV+w9mo7dQvU+NmI2az5w8vw 98OmX7G0OV9snxMW+6cyNqBrVFTu33VVNzz9pnqNCHxGvj5dL5ltP160JV2zw2bUwJBYsgYQ WfyJJIM7l3gv5ZS3DGqaGIm9gOK1ANxfrR5PgPzvI9VxDhlr2juEVMZYAqPLEJe+SSxbwLoz BcFCNdDAyXcaAzXsx/E02YWm1hIWNRxanAe7Vlg7OL+gvLpdtrYCMg28PNqKNyrQ87LQ49O9 50IIZDOtNFeR0FGucjcLPdS9PiEqCoH7/waJxWp6ydJ+g4OYRBYNM0EmMgy1N85JJrV1mi5i Message-ID: Date: Thu, 10 May 2018 17:34:07 +0300 User-Agent: Mozilla/5.0 (X11; FreeBSD amd64; rv:52.0) Gecko/20100101 Thunderbird/52.6.0 MIME-Version: 1.0 In-Reply-To: Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="U0lLuzNwU6thpb7Si8HV35u2JwnV3rKmQ" X-BeenThere: freebsd-net@freebsd.org X-Mailman-Version: 2.1.25 Precedence: list List-Id: Networking and TCP/IP with FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 10 May 2018 14:36:47 -0000 This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --U0lLuzNwU6thpb7Si8HV35u2JwnV3rKmQ Content-Type: multipart/mixed; boundary="phJWaPev3c5prtHCArkqd18jYMryBM7T2"; protected-headers="v1" From: "Andrey V. Elsukov" To: Dries Michiels , "freebsd-net@freebsd.org" Message-ID: Subject: Re: kernel: in6_delayed_cksum: delayed m_pullup References: <5ae60f44.1c69fb81.ee4a5.1043@mx.google.com> In-Reply-To: --phJWaPev3c5prtHCArkqd18jYMryBM7T2 Content-Type: multipart/mixed; boundary="------------9E47AE9791B592152C151262" Content-Language: en-US This is a multi-part message in MIME format. --------------9E47AE9791B592152C151262 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable On 10.05.2018 17:25, Andrey V. Elsukov wrote: > On 29.04.2018 21:30, Dries Michiels wrote: >> Dear mailing list, >> >> After upgrading my FreeBSD server from source from: >> FreeBSD 11.1-STABLE (VADOS) #9 r331859: Sun Apr 1 12:09:18 CEST 2018 = >> to >> FreeBSD 11.2-PRERELEASE (VADOS) #10 r333091: Sun Apr 29 16:48:44 CEST = 2018 >> >> My /var/log/messages is getting spammed by the following notice/error:= >> Apr 29 19:51:42 vados kernel: in6_delayed_cksum: delayed m_pullup, m->= len: 48 plen 68 off 56 csum_flags=3D400 >> Apr 29 19:55:34 vados last message repeated 11 times >> Apr 29 20:11:56 vados last message repeated 10 times >> Apr 29 20:12:42 vados last message repeated 4 times >> >> Does anyone have a clue what this indicates? >> I did not have this message on my older system (r331859). >=20 > Do you use pf(4) or ipsec(4)? Also, can you try this patch? --=20 WBR, Andrey V. Elsukov --------------9E47AE9791B592152C151262 Content-Type: text/x-patch; name="in6_delayed_cksum.diff" Content-Transfer-Encoding: quoted-printable Content-Disposition: attachment; filename="in6_delayed_cksum.diff" Index: sys/netinet6/ip6_output.c =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D --- sys/netinet6/ip6_output.c (revision 333456) +++ sys/netinet6/ip6_output.c (working copy) @@ -199,18 +199,10 @@ in6_delayed_cksum(struct mbuf *m, uint32_t plen, u csum =3D 0xffff; offset +=3D m->m_pkthdr.csum_data; /* checksum offset */ =20 - if (offset + sizeof(u_short) > m->m_len) { - printf("%s: delayed m_pullup, m->len: %d plen %u off %u " - "csum_flags=3D%b\n", __func__, m->m_len, plen, offset, - (int)m->m_pkthdr.csum_flags, CSUM_BITS); - /* - * XXX this should not happen, but if it does, the correct - * behavior may be to insert the checksum in the appropriate - * next mbuf in the chain. - */ - return; - } - *(u_short *)(m->m_data + offset) =3D csum; + if (offset + sizeof(csum) > m->m_len) + m_copyback(m, offset, sizeof(csum), &csum); + else + *(u_short *)mtodo(m, offset) =3D csum; } =20 int --------------9E47AE9791B592152C151262-- --phJWaPev3c5prtHCArkqd18jYMryBM7T2-- --U0lLuzNwU6thpb7Si8HV35u2JwnV3rKmQ Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQEzBAEBCAAdFiEE5lkeG0HaFRbwybwAAcXqBBDIoXoFAlr0WF8ACgkQAcXqBBDI oXqY3Qf8DNH1cB4A0iHCq1FXiOm/KdPChgrDj8ErSqmPBnnrmfYaj7X4XbxC7Kzf /q2wVTNrmnxrMTINzORuSdWSNIAW/DRZUOH5zH/alp2hLearS/TSzvdmviPDj7Qw NwfyGnLmNPblsszqbVBbmFScOCYUIhLLCONOBJVNdRTCUGSp1MzCr0YSn0U9me7o /LYnEG1pYNxpKA00fA/i2hKIT00eavFPI+lrekIDvLb4geZLKWnFjnAbQkiiNTiD TWXpHrHnhr9AQWuOncSJ07OMN0VQ21zRDSbOqfmuADABxZSTFmijUH8SWQ3mknVV v4j8nvPByQ5sbd6Xv/Njpmz8rYjwrw== =6Vil -----END PGP SIGNATURE----- --U0lLuzNwU6thpb7Si8HV35u2JwnV3rKmQ--