From owner-svn-src-all@FreeBSD.ORG Sat May 19 13:38:15 2012 Return-Path: Delivered-To: svn-src-all@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id D838B106564A; Sat, 19 May 2012 13:38:15 +0000 (UTC) (envelope-from kostikbel@gmail.com) Received: from mail.zoral.com.ua (mx0.zoral.com.ua [91.193.166.200]) by mx1.freebsd.org (Postfix) with ESMTP id 518538FC12; Sat, 19 May 2012 13:38:14 +0000 (UTC) Received: from skuns.kiev.zoral.com.ua (localhost [127.0.0.1]) by mail.zoral.com.ua (8.14.2/8.14.2) with ESMTP id q4JDc8cT091976; Sat, 19 May 2012 16:38:08 +0300 (EEST) (envelope-from kostikbel@gmail.com) Received: from deviant.kiev.zoral.com.ua (kostik@localhost [127.0.0.1]) by deviant.kiev.zoral.com.ua (8.14.5/8.14.5) with ESMTP id q4JDc8eI099149; Sat, 19 May 2012 16:38:08 +0300 (EEST) (envelope-from kostikbel@gmail.com) Received: (from kostik@localhost) by deviant.kiev.zoral.com.ua (8.14.5/8.14.5/Submit) id q4JDc8W8099148; Sat, 19 May 2012 16:38:08 +0300 (EEST) (envelope-from kostikbel@gmail.com) X-Authentication-Warning: deviant.kiev.zoral.com.ua: kostik set sender to kostikbel@gmail.com using -f Date: Sat, 19 May 2012 16:38:08 +0300 From: Konstantin Belousov To: Gleb Kurtsou Message-ID: <20120519133808.GI2358@deviant.kiev.zoral.com.ua> References: <201205191244.q4JCiSmO022413@svn.freebsd.org> Mime-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="vDuE8pp2+RlIQOrG" Content-Disposition: inline In-Reply-To: <201205191244.q4JCiSmO022413@svn.freebsd.org> User-Agent: Mutt/1.4.2.3i X-Virus-Scanned: clamav-milter 0.95.2 at skuns.kiev.zoral.com.ua X-Virus-Status: Clean X-Spam-Status: No, score=-4.0 required=5.0 tests=ALL_TRUSTED,AWL,BAYES_00 autolearn=ham version=3.2.5 X-Spam-Checker-Version: SpamAssassin 3.2.5 (2008-06-10) on skuns.kiev.zoral.com.ua Cc: svn-src-head@freebsd.org, svn-src-all@freebsd.org, src-committers@freebsd.org Subject: Re: svn commit: r235647 - in head: include lib/libc/gen usr.sbin/cpucontrol usr.sbin/lpr/common_source usr.sbin/newsyslog X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 19 May 2012 13:38:15 -0000 --vDuE8pp2+RlIQOrG Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Sat, May 19, 2012 at 12:44:28PM +0000, Gleb Kurtsou wrote: > Author: gleb > Date: Sat May 19 12:44:27 2012 > New Revision: 235647 > URL: http://svn.freebsd.org/changeset/base/235647 >=20 > Log: > Hide DIR definition by making it an opaque struct typedef. > =20 > Introduce dirfd() libc exported symbol replacing macro with same name, > preserve _dirfd() macro for internal use. > =20 > Replace dirp->dd_fd with dirfd() call. Avoid using dirfd as variable > name to prevent shadowing global symbol. > =20 > Sponsored by: Google Summer Of Code 2011 >=20 > Added: > head/lib/libc/gen/dirfd.c (contents, props changed) > head/lib/libc/gen/gen-private.h (contents, props changed) I could agree with attribution of the gen-private.h content to 'regents of the university' in the copyright, but I very much doubt that this is right thing to do for dirfd.c. I think you should put your name, instead of university, as the copyright owner. --vDuE8pp2+RlIQOrG Content-Type: application/pgp-signature Content-Disposition: inline -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.12 (FreeBSD) iEYEARECAAYFAk+3okAACgkQC3+MBN1Mb4jcUQCfcTQ3I5WQwzlC2g8OXFotoxvR X10An23kNkiB2tLNwtPk2fZiWPQR8tYB =bLfw -----END PGP SIGNATURE----- --vDuE8pp2+RlIQOrG--