Date: Sat, 19 May 2012 16:38:08 +0300 From: Konstantin Belousov <kostikbel@gmail.com> To: Gleb Kurtsou <gleb@freebsd.org> Cc: svn-src-head@freebsd.org, svn-src-all@freebsd.org, src-committers@freebsd.org Subject: Re: svn commit: r235647 - in head: include lib/libc/gen usr.sbin/cpucontrol usr.sbin/lpr/common_source usr.sbin/newsyslog Message-ID: <20120519133808.GI2358@deviant.kiev.zoral.com.ua> In-Reply-To: <201205191244.q4JCiSmO022413@svn.freebsd.org> References: <201205191244.q4JCiSmO022413@svn.freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
--vDuE8pp2+RlIQOrG Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Sat, May 19, 2012 at 12:44:28PM +0000, Gleb Kurtsou wrote: > Author: gleb > Date: Sat May 19 12:44:27 2012 > New Revision: 235647 > URL: http://svn.freebsd.org/changeset/base/235647 >=20 > Log: > Hide DIR definition by making it an opaque struct typedef. > =20 > Introduce dirfd() libc exported symbol replacing macro with same name, > preserve _dirfd() macro for internal use. > =20 > Replace dirp->dd_fd with dirfd() call. Avoid using dirfd as variable > name to prevent shadowing global symbol. > =20 > Sponsored by: Google Summer Of Code 2011 >=20 > Added: > head/lib/libc/gen/dirfd.c (contents, props changed) > head/lib/libc/gen/gen-private.h (contents, props changed) I could agree with attribution of the gen-private.h content to 'regents of the university' in the copyright, but I very much doubt that this is right thing to do for dirfd.c. I think you should put your name, instead of university, as the copyright owner. --vDuE8pp2+RlIQOrG Content-Type: application/pgp-signature Content-Disposition: inline -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.12 (FreeBSD) iEYEARECAAYFAk+3okAACgkQC3+MBN1Mb4jcUQCfcTQ3I5WQwzlC2g8OXFotoxvR X10An23kNkiB2tLNwtPk2fZiWPQR8tYB =bLfw -----END PGP SIGNATURE----- --vDuE8pp2+RlIQOrG--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20120519133808.GI2358>