From owner-freebsd-ports Sun Apr 20 13:00:05 1997 Return-Path: Received: (from root@localhost) by freefall.freebsd.org (8.8.5/8.8.5) id NAA10219 for ports-outgoing; Sun, 20 Apr 1997 13:00:05 -0700 (PDT) Received: (from gnats@localhost) by freefall.freebsd.org (8.8.5/8.8.5) id NAA10195; Sun, 20 Apr 1997 13:00:01 -0700 (PDT) Date: Sun, 20 Apr 1997 13:00:01 -0700 (PDT) Message-Id: <199704202000.NAA10195@freefall.freebsd.org> To: freebsd-ports Cc: From: James FitzGibbon Subject: Re: ports/3361: patch for bsd.port.mk Reply-To: James FitzGibbon Sender: owner-ports@FreeBSD.ORG X-Loop: FreeBSD.org Precedence: bulk The following reply was made to PR ports/3361; it has been noted by GNATS. From: James FitzGibbon To: jhs@freebsd.org Cc: FreeBSD-gnats-submit@freebsd.org, me@freebsd.org, gj@freebsd.org, asami@freebsd.org, GNATS Management , freebsd-ports@freefall.freebsd.org Subject: Re: ports/3361: patch for bsd.port.mk Date: Sun, 20 Apr 1997 15:48:19 -0400 (EDT) On Sun, 20 Apr 1997 jhs@freebsd.org wrote: > + MASTER_SITES:= ${NEARBY_DISTFILES_SITE}/ ${MASTER_SITES} > + PATCH_SITES:= ${NEARBY_DISTFILES_SITE}/ ${MASTER_SITES} > + .endif Sounds like a good idea, but doesn't MASTER_SITE_OVERRIDE already do this ? .if !defined(MASTER_SITE_OVERRIDE) MASTER_SITES+= ${MASTER_SITE_BACKUP} PATCH_SITES+= ${MASTER_SITE_BACKUP} .else MASTER_SITES:= ${MASTER_SITE_OVERRIDE} ${MASTER_SITES} PATCH_SITES:= ${MASTER_SITE_OVERRIDE} ${PATCH_SITES} .endif ${MASTER_SITE_OVERRIDE} doesn't (as I once thought) override ${MASTER_SITES}, it just prepends the one you name to the defined list. -- j.