Date: Thu, 24 May 2018 21:00:06 +0200 From: Mathieu Arnold <mat@FreeBSD.org> To: Tijl Coosemans <tijl@FreeBSD.org> Cc: Mathieu Arnold <mat@FreeBSD.org>, ports-committers@freebsd.org, svn-ports-all@freebsd.org, svn-ports-head@freebsd.org Subject: Re: svn commit: r470615 - head Message-ID: <20180524190006.wdv22boeogetrcqg@atuin.in.mat.cc> In-Reply-To: <20180524181330.001bd99e@kalimero.tijl.coosemans.org> References: <201805221358.w4MDwYtl021212@repo.freebsd.org> <20180522160246.239217d9@kalimero.tijl.coosemans.org> <20180524124550.wxsfet7qts3zevq7@ogg.in.absolight.net> <20180524145450.3345318f@kalimero.tijl.coosemans.org> <20180524143752.7vpfnzfxwkczi6h3@ogg.in.absolight.net> <20180524181330.001bd99e@kalimero.tijl.coosemans.org>
next in thread | previous in thread | raw e-mail | index | archive | help
--htjdfvrkaoupb725
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable
On Thu, May 24, 2018 at 04:13:30PM +0000, Tijl Coosemans wrote:
> On Thu, 24 May 2018 16:37:52 +0200 Mathieu Arnold <mat@FreeBSD.org> wrote:
> > On Thu, May 24, 2018 at 02:54:50PM +0200, Tijl Coosemans wrote:
> >> On Thu, 24 May 2018 14:45:50 +0200 Mathieu Arnold <mat@FreeBSD.org> wr=
ote:
> >>> On Tue, May 22, 2018 at 04:02:46PM +0200, Tijl Coosemans wrote:
> >>>> On Tue, 22 May 2018 13:58:34 +0000 (UTC) Mathieu Arnold <mat@FreeBSD=
=2Eorg> wrote:
> >>>>> --- head/CHANGES Tue May 22 13:58:03 2018 (r470614)
> >>>>> +++ head/CHANGES Tue May 22 13:58:33 2018 (r470615)
> >>>>> @@ -152,8 +152,7 @@ AUTHOR: mat@FreeBSD.org
> >>>>> =20
> >>>>> In all the ports with Python dependencies, the *_DEPENDS entries=
MUST end
> >>>>> with the flavor so that the framework knows which to build/use. =
This is done
> >>>>> - by appending '@${PY_FLAVOR}' after the origin (or @${FLAVOR} if =
in a Python
> >>>>> - module with Python flavors, as the content will be the same). F=
or example:
> >>>>> + by appending '@${PY_FLAVOR}' after the origin. For example:
> >>>>> =20
> >>>>> RUN_DEPENDS=3D ${PYTHON_PKGNAMEPREFIX}six>0:devel/py-six@${PY_=
FLAVOR}
> >>>>=20
> >>>> There are still some dependencies under Mk/ without @${PY_FLAVOR}.
> >>>
> >>> I cannot find any, can you be less vague? (or better, just fix them.)
> >>>=20
> >>=20
> >> Some lines that look suspicious:
> >=20
> > All of those only work with Python 2.7, they all depend on a file
> > though, so they are more or less flavor independant, and will work if
> > the default is not 2.7.
>=20
> But a port like devel/py-gobject is still flavored even if it has only
> one flavor. Are you saying that in that case depending on category/port
> without @flavor is fine? I think I prefer to keep it simple and always
> require @flavor, like it says in the text above.
Mmmm, it's not that simple. Requiring the flavor is fine for Python
modules, because it'll get imported and installing the wrong version
will not work. But if a port wants to run some command that is in fact
a Python script, the flavor does not matter.
All in all, I am not sure what to do with those dependencies, the
problem is that PY_FLAVOR will only be there if USES=3Dpython is there,
and I don't have the cycles to go through all the dependencies and look
it up.
--=20
Mathieu Arnold
--htjdfvrkaoupb725
Content-Type: application/pgp-signature; name="signature.asc"
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2
iQJ8BAABCgBmBQJbBwu2XxSAAAAAAC4AKGlzc3Vlci1mcHJAbm90YXRpb25zLm9w
ZW5wZ3AuZmlmdGhob3JzZW1hbi5uZXQzQUI2OTc4OUQyRUQxMjEwNjQ0MEJBNUIz
QTQ1MTZGMzUxODNDRTQ4AAoJEDpFFvNRg85Iz0cP/0wYA6bUoNNCm7EdwI1cJUPL
zKSSn3nZvSelHGjYnCfJ+TK5/2L+ogtlpj0p762h6U9gisTLtps6Iukerj/WVpMz
Ck3kH9eKgRiYGZDgAloaH+1xDyzc6RHh8VVzyKDCWAlf4L/vN6Yj96z8bPJTHCJR
IgOxcfDsPfS0Y/GbvqjL+DFvf9G2aV0iVnUwZzVTGfFCOECeDBe24zpT3ohgALDs
4lFk+nPA3T4e5U4TzPPvpZQfM7O0ON3vZ0Q75sKPnSdCos+16xtb5zdOY3+/tliL
8AeuUfQMdXj9vhIu/026j2/sERcEjv+YsJDBfXzKYtz+kRuc/XImqPrePd2UwbEC
CckS4wbD4SqYk4X2iXnmfUdzLNOXedUHbuuPrj3xdJHjwDtSW/QP8QHaYKIODLM6
H+xi0nDU33CuBudv2KRSJ9MVJUSByPW1EMXtTvLs9pCCLUBb3bcX4RCjJwRsWJQ4
/V2HXZNJWxJk5m1pK17qPm+7mExsoI0A4hpSGbVtXMtLywM1OT2+r0m4heJpt9NV
euSk/Kia1ANg+MYkKlA1iYat8X4+93DNf4YuTZukVtm8AXvODqh/hTaTo5W8byBH
Ktpwri8x8ElxEzMgk2rxdpyghv1hDuEbZ6AEr1vYYqKIjZZ/zw3YdfAtmha/Sl+2
DYX9Q7cheD5/O29Ua0ii
=I+B6
-----END PGP SIGNATURE-----
--htjdfvrkaoupb725--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20180524190006.wdv22boeogetrcqg>