From owner-freebsd-current@FreeBSD.ORG Sun Jan 15 09:05:00 2012 Return-Path: Delivered-To: freebsd-current@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 4504E106566B; Sun, 15 Jan 2012 09:05:00 +0000 (UTC) (envelope-from conrads@cox.net) Received: from eastrmfepo201.cox.net (eastrmfepo201.cox.net [68.230.241.216]) by mx1.freebsd.org (Postfix) with ESMTP id A2DC98FC0C; Sun, 15 Jan 2012 09:04:59 +0000 (UTC) Received: from eastrmimpo110.cox.net ([68.230.241.223]) by eastrmfepo201.cox.net (InterMail vM.8.01.04.00 201-2260-137-20101110) with ESMTP id <20120115090453.OSAN4752.eastrmfepo201.cox.net@eastrmimpo110.cox.net>; Sun, 15 Jan 2012 04:04:53 -0500 Received: from serene.no-ip.org ([98.164.86.55]) by eastrmimpo110.cox.net with bizsmtp id Ml4o1i0051BeFqy02l4r0J; Sun, 15 Jan 2012 04:04:53 -0500 X-CT-Class: Clean X-CT-Score: 0.00 X-CT-RefID: str=0001.0A02020A.4F1296B5.004A,ss=1,re=0.000,fgs=0 X-CT-Spam: 0 X-Authority-Analysis: v=1.1 cv=UJAwRnj6VfZxP3vT7W4vAg8D8vrJMSfrMxq2TR8CUCY= c=1 sm=1 a=DPtQzSQXmXEA:10 a=G8Uczd0VNMoA:10 a=kj9zAlcOel0A:10 a=fdHYxQQoAueMHNSmXppgDg==:17 a=6I5d2MoRAAAA:8 a=kviXuzpPAAAA:8 a=Cy_4xEArTnYdzKXqee0A:9 a=poRS1nPzuESvmDOTuwUA:7 a=CjuIK1q_8ugA:10 a=SV7veod9ZcQA:10 a=4vB-4DCPJfMA:10 a=bWiW0wc42D0RHruK:21 a=K51dGHDKILHWUcO9:21 a=fdHYxQQoAueMHNSmXppgDg==:117 X-CM-Score: 0.00 Authentication-Results: cox.net; none Received: from cox.net (localhost [127.0.0.1]) by serene.no-ip.org (8.14.5/8.14.5) with ESMTP id q0F94j3W052733; Sun, 15 Jan 2012 03:04:45 -0600 (CST) (envelope-from conrads@cox.net) Date: Sun, 15 Jan 2012 03:04:40 -0600 From: "Conrad J. Sabatier" To: Doug Barton Message-ID: <20120115030440.16450287@cox.net> In-Reply-To: <4F129104.90805@FreeBSD.org> References: <4F114577.30201@FreeBSD.org> <4F119C40.2080503@gwdg.de> <20120115021101.11615318@cox.net> <4F129104.90805@FreeBSD.org> X-Mailer: Claws Mail 3.8.0 (GTK+ 2.24.6; amd64-portbld-freebsd10.0) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Cc: Chris Rees , freebsd-current Subject: Re: HEADS UP: set_rcvar() removed from rc.subr X-BeenThere: freebsd-current@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Discussions about the use of FreeBSD-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 15 Jan 2012 09:05:00 -0000 On Sun, 15 Jan 2012 00:40:36 -0800 Doug Barton wrote: > On 01/15/2012 00:11, Conrad J. Sabatier wrote: > > > Chris, if you're working on fixing ports' rc files > > Thanks for taking a look at this. FYI, all of the rc.d scripts that > are actually in the ports tree have already been fixed. The outliers > at this point are scripts that are included in the distfiles. Some of > those even have patches in the tree already, and they were updated in > the same sweep. > > While we certainly try to enforce == PROVIDE == $name for > scripts that are in the tree, it can't be guaranteed that this is true > for scripts that are not, so if name=foo, rcvar should be foo_enable. > > > hth, > > Doug Well, that's good news. I wasn't sure how far along the work on this had come yet. I'm amazed in retrospect at the amount of discussion that took place over this change, especially seeing as how the rcvar is hardcoded elsewhere in these scripts anyway (I mean, how else to do ": ${foo_enable=NO}" without introducing yet another level of indirection?). No wonder you were feeling a little ticked off earlier. I thought your point about the time spent editing vs. the number of times a script will actually be run was right on target. Keep up the good work! :-) Conrad -- Conrad J. Sabatier conrads@cox.net