Date: Mon, 28 Dec 2009 04:44:03 GMT From: YAMAMOTO@FreeBSD.org, Shigeru <shigeru@iij.ad.jp> To: freebsd-gnats-submit@FreeBSD.org Subject: ports/142091: [ports/textproc/docbook-410] definition mismatch between 'BUILD_DEPENDS' and 'do-install' Message-ID: <200912280444.nBS4i3Vl053223@www.freebsd.org> Resent-Message-ID: <200912280450.nBS4o06O096547@freefall.freebsd.org>
next in thread | raw e-mail | index | archive | help
>Number: 142091
>Category: ports
>Synopsis: [ports/textproc/docbook-410] definition mismatch between 'BUILD_DEPENDS' and 'do-install'
>Confidential: no
>Severity: non-critical
>Priority: low
>Responsible: freebsd-ports-bugs
>State: open
>Quarter:
>Keywords:
>Date-Required:
>Class: sw-bug
>Submitter-Id: current-users
>Arrival-Date: Mon Dec 28 04:50:00 UTC 2009
>Closed-Date:
>Last-Modified:
>Originator: YAMAMOTO, Shigeru
>Release: 9.0-CURRENT
>Organization:
>Environment:
FreeBSD mercury.iij.ad.jp 9.0-CURRENT FreeBSD 9.0-CURRENT #0: Thu Dec 24 09:31:22 JST 2009 root@XXXX:/usr/src/sys/amd64/compile/XXXX amd64
>Description:
I can not install 'ports/textproc/docbook-410' before installing 'ports/archivers/unzip'.
Because, definition 'BUILD_DEPENDS' is mismatched to doing 'do-install'.
definition 'BUILD_DEPENDS' in Makefile,
BUILD_DEPENDS= unzip:${PORTSDIR}/archivers/unzip
but, calling 'unzip' in 'do-install' is
do-install:
@${UNZIP_CMD} -a -q -o ${DISTDIR}/${DISTFILES} -d ${INSTDIR}/${PORTVERSION}
In -current, unzip is included in system binarires.('/usr/bin/unzip')
So, 'ports/archives/unzip' is not installed automatically.
>How-To-Repeat:
1) de-install 'archives/unzip'
2) make 'textproc/docbook-410'
>Fix:
I think 2 way to fix it.
1) change 'do-install' same as 'textproc/docbook-420'
Index: textproc/docbook-410/Makefile
===================================================================
RCS file: /share/cvsup/FreeBSD/current/usr/ports/textproc/docbook-410/Makefile,v
retrieving revision 1.16
diff -u -r1.16 Makefile
--- textproc/docbook-410/Makefile 1 Sep 2008 07:44:14 -0000 1.16
+++ textproc/docbook-410/Makefile 28 Dec 2009 04:42:40 -0000
@@ -42,7 +42,7 @@
@${MKDIR} ${INSTDIR}/${PORTVERSION}
do-install:
- @${UNZIP_CMD} -a -q -o ${DISTDIR}/${DISTFILES} -d ${INSTDIR}/${PORTVERSION}
+ @unzip -a -q -o ${DISTDIR}/${DISTFILES} -d ${INSTDIR}/${PORTVERSION}
@${INSTALL_DATA} ${FILESDIR}/catalog ${INSTDIR}/${PORTVERSION}/catalog
@${ECHO_CMD} "CATALOG \"${ISOCAT}\"" >> ${INSTDIR}/${PORTVERSION}/catalog
@${CHMOD} ${SHAREMODE} ${INSTDIR}/${PORTVERSION}/*
2) change 'BUILD_DEPENDS' to use '${UNZIP_CMD}'.
Index: textproc/docbook-410/Makefile
===================================================================
RCS file: /share/cvsup/FreeBSD/current/usr/ports/textproc/docbook-410/Makefile,v
retrieving revision 1.16
diff -u -r1.16 Makefile
--- textproc/docbook-410/Makefile 1 Sep 2008 07:44:14 -0000 1.16
+++ textproc/docbook-410/Makefile 28 Dec 2009 04:23:44 -0000
@@ -20,7 +20,7 @@
RUN_DEPENDS= ${ISOCAT}:${PORTSDIR}/textproc/iso8879 \
${XMLCATMGR}:${PORTSDIR}/textproc/xmlcatmgr
-BUILD_DEPENDS= unzip:${PORTSDIR}/archivers/unzip
+BUILD_DEPENDS= ${UNZIP_CMD}:${PORTSDIR}/archivers/unzip
USE_ZIP= yes
NO_MTREE= yes
>Release-Note:
>Audit-Trail:
>Unformatted:
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?200912280444.nBS4i3Vl053223>