From owner-freebsd-apache@FreeBSD.ORG Sun Aug 12 22:40:41 2012 Return-Path: Delivered-To: apache@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 2D05A106566C for ; Sun, 12 Aug 2012 22:40:41 +0000 (UTC) (envelope-from ohauer@FreeBSD.org) Received: from p578be941.dip0.t-ipconnect.de (p578be941.dip0.t-ipconnect.de [87.139.233.65]) by mx1.freebsd.org (Postfix) with ESMTP id D8AEE8FC08 for ; Sun, 12 Aug 2012 22:40:40 +0000 (UTC) Received: from [192.168.0.100] (cde1100.uni.vrs [192.168.0.100]) (Authenticated sender: ohauer) by p578be941.dip0.t-ipconnect.de (Postfix) with ESMTPSA id 69CB22087E; Mon, 13 Aug 2012 00:40:37 +0200 (CEST) Message-ID: <502830EF.40604@FreeBSD.org> Date: Mon, 13 Aug 2012 00:40:47 +0200 From: Olli Hauer User-Agent: Mozilla/5.0 (Windows NT 5.1; rv:14.0) Gecko/20120713 Thunderbird/14.0 MIME-Version: 1.0 To: "apache@FreeBSD.org" References: <50282839.6060800@FreeBSD.org> In-Reply-To: X-Enigmail-Version: 1.4.3 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Cc: Subject: Re: bsd.apache.mk rewrite / cleanup X-BeenThere: freebsd-apache@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: "apache@FreeBSD.org" List-Id: Support of apache-related ports List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 12 Aug 2012 22:40:41 -0000 On 2012-08-13 00:26, Philip M. Gollucci wrote: > Looks fine to me. Why don't we just act on removing www/apache20 and > devel/apr0. > Then committing this is simpler > Then making www/apache24 is easier > Then moving APACHE_PORT to www/apache24 is 'easier' minus the MPM change. Sounds good to me, should we update the EXPIRE date of apache20 to the end of this month (2012-08-30)? I would have the new bsd.apache.mk in place as soon as possible, therefore most of the time was spend in doing backward tests. -- olli > On Sun, Aug 12, 2012 at 6:03 PM, Olli Hauer wrote: > >> Hi all, >> >> the bsd.apache.mk script has undergone a rewrite for better support of >> options NG. >> >> changed: >> - make.conf pa-rams like WITH(OUT)_MODULES should be given in UPPER case. >> Code to convert make.conf pa-rams to UPPER case is in place >> - cleanup old constructs which are working in a sub-shell (@for ... >> ${GREP} ...) >> the parts are replaced to use make logic. >> - adjust apache20/apache22 ports for the new bsd.apache.mk. >> >> The bsd.apache.mk file should be touched again to support options NG in >> apache2x >> but those changes are only a view lines. >> >> I want to keep make.conf support the same way it works now even if apache22 >> is rewritten with options NG support. This means against new options NG >> logic >> the make.conf has priority over options set by "make config" (old >> behavior). >> To give make.conf and command line pa-rams a higher priority is needed for >> static and other special builds. >> >> I've done endless tests with the rewritten bsd.apache.mk and have not >> found any >> backward incompatible issues (except if we remove the UPPERCASE convert >> part) >> >> There is additional room for more cleanup, some comments are in the patch >> (MFC TODO). >> >> For anyone interested in review before I commit the patches >> >> http://people.freebsd.org/~ohauer/diffs/apache/bsd.apache.mk_rewrite_2012-08-12.txt >> >> -- >> olli >> _______________________________________________ >> freebsd-apache@freebsd.org mailing list >> http://lists.freebsd.org/mailman/listinfo/freebsd-apache >> To unsubscribe, send any mail to "freebsd-apache-unsubscribe@freebsd.org" >> > > >