From owner-svn-ports-head@freebsd.org Thu Jun 15 06:17:07 2017 Return-Path: Delivered-To: svn-ports-head@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 3B64CC3119D; Thu, 15 Jun 2017 06:17:07 +0000 (UTC) (envelope-from tcberner@gmail.com) Received: from mail-yb0-f169.google.com (mail-yb0-f169.google.com [209.85.213.169]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id F3D9565BBB; Thu, 15 Jun 2017 06:17:06 +0000 (UTC) (envelope-from tcberner@gmail.com) Received: by mail-yb0-f169.google.com with SMTP id f192so1333608yba.2; Wed, 14 Jun 2017 23:17:06 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=SGNswlhwx0F8/8YW5P0GpiQqmT7Oma6Jmn6eDEkyOf8=; b=MVZG3rErJo9xIrBiyBJai8M2GCUpu5FZ2jwELGXPgexWgOHOjzEx9m4W1vc4cZN4WX O+hedo70ChH5KOZr6d9SPvr3B62owvNU6EszKMoA0HVD+n70Sge8yWhbq1p9mXTo4MB3 y2p1jkv39gjSPAtvr3sY9OHDZ3KnJdNmUfP4ai1vSPtpNq975kQvb630eXXp7TKUuEdZ DStiC74biEcQeJZSRaBk+XOmfjvBM/C/LvTMR+p66T6jC7mgd+RdAaY5NO8MefkI4i5O NKKPiV6EFpZhNgHb5ffwvypPQBbHZ3hvJZgoyEJ9l4FZqoqQhesaPjpavRjLTr2ID8fo 6azg== X-Gm-Message-State: AKS2vOzPxd44w+m/EDHuWJIAKhCJ5LG7cKpHTOtf60NNmPn1IcRf3xJB s6VN4rR7h4GrtzvHVso= X-Received: by 10.37.163.69 with SMTP id d63mr2975795ybi.80.1497507420365; Wed, 14 Jun 2017 23:17:00 -0700 (PDT) Received: from mail-yw0-f181.google.com (mail-yw0-f181.google.com. [209.85.161.181]) by smtp.gmail.com with ESMTPSA id a68sm917941ywe.6.2017.06.14.23.17.00 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Wed, 14 Jun 2017 23:17:00 -0700 (PDT) Received: by mail-yw0-f181.google.com with SMTP id v7so1715643ywc.2; Wed, 14 Jun 2017 23:17:00 -0700 (PDT) X-Received: by 10.13.231.2 with SMTP id q2mr3270408ywe.330.1497507419309; Wed, 14 Jun 2017 23:16:59 -0700 (PDT) MIME-Version: 1.0 Received: by 10.129.108.150 with HTTP; Wed, 14 Jun 2017 23:16:58 -0700 (PDT) In-Reply-To: <20170615033928.GA66016@FreeBSD.org> References: <201706142018.v5EKIc8G062340@repo.freebsd.org> <20170615005515.GA26393@FreeBSD.org> <2E7EBFF9-6184-4CCA-BCAF-A3991EAF3A94@adamw.org> <20170615015635.GA78699@FreeBSD.org> <42DEC213-DF22-4BDF-9EA2-876629BA763C@adamw.org> <20170615033928.GA66016@FreeBSD.org> From: "Tobias C. Berner" Date: Thu, 15 Jun 2017 08:16:58 +0200 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: svn commit: r443599 - head/Mk To: Alexey Dokuchaev Cc: Adam Weinberger , "Tobias C. Berner" , ports-committers@freebsd.org, svn-ports-all@freebsd.org, svn-ports-head@freebsd.org Content-Type: text/plain; charset="UTF-8" X-BeenThere: svn-ports-head@freebsd.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: SVN commit messages for the ports tree for head List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 15 Jun 2017 06:17:07 -0000 Hi there You're right, this only "addressed" the trailing slash issue and not the one with the symlink, which I forgot about. I think this should be fixed in qt5-qmake itself and not in the ports framework. I'll reopen it. mfg Tobias On 15 June 2017 at 05:39, Alexey Dokuchaev wrote: > On Wed, Jun 14, 2017 at 08:54:33PM -0600, Adam Weinberger wrote: >> > On 14 Jun, 2017, at 19:56, Alexey Dokuchaev wrote: >> > ... >> > [I] was somewhat disappointed that my PR was closed as WONTFIX (works >> > as intended) with no response to analysis of the problem, no discussion >> > of the proposed solution, etc. >> > >> > All the effort was flushed down the toilet. >> > >> > Needless to say, the problem is still there until someone else trips on >> > it and opens a similar PR. >> >> Consider opening a new PR (199297 turned into a different issue) and >> attaching a patch. > > I might do so, but I'd like to hear from Tobias first regarding the way > he had handled this one. Right now I'm a bit hesitant to spend time on > crafting a patch and filing another PR just to find out it is closed as > WONTFIX later again. > >> And there probably is merit to finding out what other stuff breaks >> when WRKDIRPREFIX != realpath WRKDIRPREFIX. > > Yeah, I mention this; there seems to be low interest though. > > ./danfe