From owner-cvs-all@FreeBSD.ORG Tue Apr 27 06:12:32 2004 Return-Path: Delivered-To: cvs-all@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 51E4016A4CF for ; Tue, 27 Apr 2004 06:12:32 -0700 (PDT) Received: from mail2.speakeasy.net (mail2.speakeasy.net [216.254.0.202]) by mx1.FreeBSD.org (Postfix) with ESMTP id 15DD943D6B for ; Tue, 27 Apr 2004 06:12:32 -0700 (PDT) (envelope-from jhb@FreeBSD.org) Received: (qmail 14840 invoked from network); 27 Apr 2004 13:12:31 -0000 Received: from dsl027-160-063.atl1.dsl.speakeasy.net (HELO server.baldwin.cx) ([216.27.160.63]) (envelope-sender ) encrypted SMTP for ; 27 Apr 2004 13:12:31 -0000 Received: from slimer.baldwin.cx (slimer.baldwin.cx [192.168.0.16]) by server.baldwin.cx (8.12.11/8.12.11) with ESMTP id i3RDCT8a006851; Tue, 27 Apr 2004 09:12:29 -0400 (EDT) (envelope-from jhb@FreeBSD.org) From: John Baldwin To: Warner Losh Date: Tue, 27 Apr 2004 09:12:47 -0400 User-Agent: KMail/1.6 References: <200404260211.i3Q2Bcrt037219@repoman.freebsd.org> In-Reply-To: <200404260211.i3Q2Bcrt037219@repoman.freebsd.org> MIME-Version: 1.0 Content-Disposition: inline Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: 7bit Message-Id: <200404270912.48113.jhb@FreeBSD.org> X-Spam-Checker-Version: SpamAssassin 2.63 (2004-01-11) on server.baldwin.cx cc: cvs-src@FreeBSD.org cc: src-committers@FreeBSD.org cc: cvs-all@FreeBSD.org Subject: Re: cvs commit: src/sys/dev/acpica acpi_pci.c src/sys/dev/pci pci.c X-BeenThere: cvs-all@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the entire tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 27 Apr 2004 13:12:32 -0000 On Sunday 25 April 2004 10:11 pm, Warner Losh wrote: > imp 2004/04/25 19:11:38 PDT > > FreeBSD src repository > > Modified files: > sys/dev/acpica acpi_pci.c > sys/dev/pci pci.c > Log: > Fix two typos from PR: 65694 > > 1) In pci.c, we need to check the child device's state, not the parent > device's state. > 2) In acpi_pci.c, we have to run the power state change after the acpi > method when the old_state is > new state, not the other way around. Umm, the ACPI method may turn the power to the device off (i.e., turn off the power resource that provides power to the device), meaning that you can't access it's PCI config registers anymore. It's quite intentional to turn the device off using PCI first and ACPI second and then to turn the device on via ACPI first and then PCI second. Unfortunately, the PR number is wrong (that's some ports PR) and there are no PR's in the database with an originator that contains 'Remesov' or the text 'acpi_pci' in the text fields at least none that query-pr-summary.cgi can find. Ugh, actually, query-pr is just hosed as it thinks we have no open PRs. *sigh* > Submitted by: Dmitry Remesov > PR: 65694 > > Revision Changes Path > 1.14 +1 -1 src/sys/dev/acpica/acpi_pci.c > 1.249 +1 -1 src/sys/dev/pci/pci.c -- John Baldwin <>< http://www.FreeBSD.org/~jhb/ "Power Users Use the Power to Serve" = http://www.FreeBSD.org