Date: Sat, 1 Jul 2023 17:10:15 GMT From: Warner Losh <imp@FreeBSD.org> To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org Subject: git: c1be7151d543 - main - qlnxe: Fix too many args in call to internal_ram_wr() Message-ID: <202307011710.361HAFtp045585@gitrepo.freebsd.org>
next in thread | raw e-mail | index | archive | help
The branch main has been updated by imp: URL: https://cgit.FreeBSD.org/src/commit/?id=c1be7151d5433718821a2b61245eaf99157daa9a commit c1be7151d5433718821a2b61245eaf99157daa9a Author: Mark O'Donovan <shiftee@posteo.net> AuthorDate: 2023-07-01 17:06:50 +0000 Commit: Warner Losh <imp@FreeBSD.org> CommitDate: 2023-07-01 17:06:56 +0000 qlnxe: Fix too many args in call to internal_ram_wr() internal_ram_wr() only takes 3 args when ECORE_CONFIG_DIRECT_HWFN is defined Signed-off-by: Mark O'Donovan <shiftee@posteo.net> Reviewed by: imp Pull Request: https://github.com/freebsd/freebsd-src/pull/779 --- sys/dev/qlnx/qlnxe/qlnx_os.c | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/sys/dev/qlnx/qlnxe/qlnx_os.c b/sys/dev/qlnx/qlnxe/qlnx_os.c index 0b5dba75300b..3c788f5c0fb7 100644 --- a/sys/dev/qlnx/qlnxe/qlnx_os.c +++ b/sys/dev/qlnx/qlnxe/qlnx_os.c @@ -6602,8 +6602,13 @@ qlnx_update_rx_prod(struct ecore_hwfn *p_hwfn, struct qlnx_rx_queue *rxq) */ wmb(); - internal_ram_wr(p_hwfn, rxq->hw_rxq_prod_addr, +#ifdef ECORE_CONFIG_DIRECT_HWFN + internal_ram_wr(p_hwfn, rxq->hw_rxq_prod_addr, sizeof(rx_prods), &rx_prods.data32); +#else + internal_ram_wr(rxq->hw_rxq_prod_addr, + sizeof(rx_prods), &rx_prods.data32); +#endif /* mmiowb is needed to synchronize doorbell writes from more than one * processor. It guarantees that the write arrives to the device before
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?202307011710.361HAFtp045585>