From owner-freebsd-ports@FreeBSD.ORG Tue Mar 3 05:52:11 2009 Return-Path: Delivered-To: ports@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id AE819106566C for ; Tue, 3 Mar 2009 05:52:11 +0000 (UTC) (envelope-from lehmann@ans-netz.de) Received: from avocado.salatschuessel.net (avocado.salatschuessel.net [78.111.72.186]) by mx1.freebsd.org (Postfix) with SMTP id 00C498FC14 for ; Tue, 3 Mar 2009 05:52:10 +0000 (UTC) (envelope-from lehmann@ans-netz.de) Received: (qmail 60188 invoked by uid 89); 3 Mar 2009 05:52:09 -0000 Received: from unknown (HELO kartoffel.salatschuessel.net) (78.111.72.187) by avocado.salatschuessel.net with SMTP; 3 Mar 2009 05:52:09 -0000 Date: Tue, 3 Mar 2009 06:52:08 +0100 From: Oliver Lehmann To: Doug Barton Message-Id: <20090303065208.87200365.lehmann@ans-netz.de> In-Reply-To: <49AC5C66.70301@FreeBSD.org> References: <20090302163843.cc66c55e.lehmann@ans-netz.de> <20090302202520.eaf09b15.lehmann@ans-netz.de> <9e20d71e0903021355i3ad66b8fx14bdc3b395e311a5@mail.gmail.com> <9e20d71e0903021410i26ca8088oc2de76009b2773d2@mail.gmail.com> <49AC5C66.70301@FreeBSD.org> X-Mailer: Sylpheed 2.6.0 (GTK+ 2.14.7; amd64-portbld-freebsd7.1) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Cc: ports@freebsd.org, stable@freebsd.org, Artis Caune Subject: Re: restart a script in etc/rc.d X-BeenThere: freebsd-ports@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Porting software to FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 03 Mar 2009 05:52:12 -0000 Doug Barton wrote: > Artis Caune wrote: > > There is logic error in bacula rc.d script. It should first set > > default variables and only then use them. > > pidfile="${bacula_fd_pidfile}" > > : ${bacula_fd_pidfile="/var/run/bacula-fd.9102.pid"} > > > > If you don't set pidfile in rc.conf, pidfile is "" so it kills all bacula-fd's > > Yes, I tried to convince the OP to fix this, but he thought he had it > covered, so I'm giving him the opportunity to prove me wrong. :) Yeah this did it - Its working now. I thought you where just telling me that to have another pidfile for the 2nd start script - I missed the point that it was empty for the first one and because of that it is falling back to ps... I'll probably write a PR and commit it after aproval for PROVIDE and the pidfile setting... -- Oliver Lehmann http://www.pofo.de/ http://wishlist.ans-netz.de/