From owner-dev-commits-src-main@freebsd.org Mon Mar 22 14:47:14 2021 Return-Path: Delivered-To: dev-commits-src-main@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id 5C0C45B153A; Mon, 22 Mar 2021 14:47:14 +0000 (UTC) (envelope-from arichardson.kde@gmail.com) Received: from mail-ej1-f48.google.com (mail-ej1-f48.google.com [209.85.218.48]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "smtp.gmail.com", Issuer "GTS CA 1O1" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4F3y5G1xbmz3mRW; Mon, 22 Mar 2021 14:47:14 +0000 (UTC) (envelope-from arichardson.kde@gmail.com) Received: by mail-ej1-f48.google.com with SMTP id b7so21747748ejv.1; Mon, 22 Mar 2021 07:47:14 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=9LWRKdkKR4H6O/bmr/3BsNlhXh8kHW23A8aLYeiIloI=; b=bY7xgKd6u7/6L/FWJL1PRzWBZFIiHtQGuRnqONURAc9bNCCJALucy7zIctRdxNAme/ yy8NXryZacn6ecdPWHCAjgtSJ4pCNDkEjRBbDaUf2gZlZ8nHbPLQgsjcvUsPE+y7Nlj4 9cQt+pMh4sXsbAyOOTXbOSPPIrNypQUV55YyShcSw9PbijT1ZawsotSDiObv4h9ndftH dL91cROl4ZrMtUMF7ia2JTIDzp4W9gPqWTN+tDP2LRkyCKG7fx3Eg+enaeBtowwSGtai bclvqsoQn6T29zJDmrB2ZukeCCvBdKq8M/CRU98ceQDNH0LbiN0Te69qhj50doXHhhvF 0QPw== X-Gm-Message-State: AOAM533SejFzmOD1KVfN/GFHn6nf74fgFyrBpp5FC4MgaOB/4If5jQ4J wv8CITEFapWXJ4qK4hQMlo5FFaAu9ho= X-Google-Smtp-Source: ABdhPJwctdCAcBQGB7gT1rNjSCR124u+NQSnKgWleyDA2xY47fwoQN+xdApmz5oePYk1XiznBwOvMw== X-Received: by 2002:a17:907:3e92:: with SMTP id hs18mr113095ejc.396.1616424432731; Mon, 22 Mar 2021 07:47:12 -0700 (PDT) Received: from mail-wr1-f42.google.com (mail-wr1-f42.google.com. [209.85.221.42]) by smtp.gmail.com with ESMTPSA id ym4sm1989230ejb.100.2021.03.22.07.47.12 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 22 Mar 2021 07:47:12 -0700 (PDT) Received: by mail-wr1-f42.google.com with SMTP id j7so17321021wrd.1; Mon, 22 Mar 2021 07:47:12 -0700 (PDT) X-Received: by 2002:a5d:4281:: with SMTP id k1mr18460993wrq.374.1616424432273; Mon, 22 Mar 2021 07:47:12 -0700 (PDT) MIME-Version: 1.0 References: <202103221200.12MC0Rja055125@gitrepo.freebsd.org> In-Reply-To: From: Alexander Richardson Date: Mon, 22 Mar 2021 14:47:01 +0000 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: git: 87d65c747a43 - main - lib/msun: Allow building tests with WARNS=6 To: Kyle Evans Cc: src-committers , "" , dev-commits-src-main@freebsd.org Content-Type: text/plain; charset="UTF-8" X-Rspamd-Queue-Id: 4F3y5G1xbmz3mRW X-Spamd-Bar: ---- Authentication-Results: mx1.freebsd.org; none X-Spamd-Result: default: False [-4.00 / 15.00]; REPLY(-4.00)[]; TAGGED_FROM(0.00)[] X-BeenThere: dev-commits-src-main@freebsd.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Commit messages for the main branch of the src repository List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 22 Mar 2021 14:47:14 -0000 On Mon, 22 Mar 2021 at 14:37, Kyle Evans wrote: > > On Mon, Mar 22, 2021 at 7:01 AM Alex Richardson wrote: > > > > The branch main has been updated by arichardson: > > > > URL: https://cgit.FreeBSD.org/src/commit/?id=87d65c747a4389901c2bbbcb1ec4878b2df7b32c > > > > commit 87d65c747a4389901c2bbbcb1ec4878b2df7b32c > > Author: Alex Richardson > > AuthorDate: 2021-02-25 14:28:17 +0000 > > Commit: Alex Richardson > > CommitDate: 2021-03-22 11:55:07 +0000 > > > > lib/msun: Allow building tests with WARNS=6 > > > > The only change needed is to mark a few variables as static. > > --- > > contrib/netbsd-tests/lib/libm/t_ldexp.c | 19 +++++++++---------- > > contrib/netbsd-tests/lib/libm/t_precision.c | 4 ++-- > > contrib/netbsd-tests/lib/libm/t_round.c | 2 +- > > contrib/netbsd-tests/lib/libm/t_scalbn.c | 2 +- > > lib/msun/tests/Makefile | 2 +- > > 5 files changed, 14 insertions(+), 15 deletions(-) > > > > [... snip ...] > > diff --git a/lib/msun/tests/Makefile b/lib/msun/tests/Makefile > > index 309f49c6dddd..4ef25c0a909a 100644 > > --- a/lib/msun/tests/Makefile > > +++ b/lib/msun/tests/Makefile > > @@ -88,7 +88,7 @@ SRCS.ilogb2_test= ilogb_test.c > > > > LIBADD+= m > > > > -WARNS?= 1 > > +WARNS?= 6 > > > > # Copied from lib/msun/Makefile > > .if ${MACHINE_CPUARCH} == "i386" > > Hi, > > IMO, we should go ahead and drop this WARNS entirely now that it's the > default -- I changed it a while back so that all depths of userland > should get a natural WARNS=6 if it's undefined. > > Thanks, > > Kyle Evans Hi Kyle, I forgot that it's the default now. Will commit a change shortly to remove it. Alex