From owner-svn-ports-all@FreeBSD.ORG  Thu Apr  9 16:03:30 2015
Return-Path: <owner-svn-ports-all@FreeBSD.ORG>
Delivered-To: svn-ports-all@freebsd.org
Received: by hub.freebsd.org (Postfix, from userid 1033)
 id D8E52DC8; Thu,  9 Apr 2015 16:03:30 +0000 (UTC)
Date: Thu, 9 Apr 2015 16:03:30 +0000
From: Alexey Dokuchaev <danfe@FreeBSD.org>
To: Bryan Drewery <bdrewery@FreeBSD.org>
Subject: Re: svn commit: r383191 - head/Mk
Message-ID: <20150409160330.GB31951@FreeBSD.org>
References: <201504040535.t345ZJ9M028396@svn.freebsd.org>
 <20150408194202.GA45809@hades.panopticon>
 <5525A9C1.5010003@FreeBSD.org>
 <20150408232144.GX21982@hades.panopticon>
 <5525D48E.5090305@FreeBSD.org>
 <20150409110221.GB45809@hades.panopticon>
 <55269785.7030307@FreeBSD.org> <20150409153856.GA31951@FreeBSD.org>
 <55269FE4.2030208@FreeBSD.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <55269FE4.2030208@FreeBSD.org>
User-Agent: Mutt/1.5.23 (2014-03-12)
Cc: svn-ports-head@freebsd.org, svn-ports-all@freebsd.org,
 Dmitry Marakasov <amdmi3@amdmi3.ru>, ports-committers@freebsd.org
X-BeenThere: svn-ports-all@freebsd.org
X-Mailman-Version: 2.1.18-1
Precedence: list
List-Id: SVN commit messages for the ports tree <svn-ports-all.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/options/svn-ports-all>,
 <mailto:svn-ports-all-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/svn-ports-all/>
List-Post: <mailto:svn-ports-all@freebsd.org>
List-Help: <mailto:svn-ports-all-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/svn-ports-all>,
 <mailto:svn-ports-all-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Thu, 09 Apr 2015 16:03:30 -0000

On Thu, Apr 09, 2015 at 10:51:00AM -0500, Bryan Drewery wrote:
> On 4/9/2015 10:38 AM, Alexey Dokuchaev wrote:
> > I'm personally heavily relying on ability to set OSVERSION to arbitrary
> > value on per-port basis; it is very helpful to test the logic of some
> > complicated port (e.g. x11/nvidia-driver) to make sure you got all these
> > checks right.  Now since r369644 (also by you) I have to comment that
> > harness code from Mk/bsd.port.mk out.
> > 
> > I was actually surprised that I have to do it, since log message talks
> > only about "OSVERSION or UNAME_r is improperly set when building in a
> > jail/chroot", but in reality I cannot do a "make OSVERSION=xxx" even when
> > building locally. [...]
> 
> Read the commit log again for r369644. Setting one var and not the other
> leads to incorrect behavior in many ports. You must have them matching.
> It is not just about jails/chroots.

I've (re)read it and understand what you're trying to accomplish; my point
here is not to *build* things against custom OSVERSION, but just check if
some variables are set correctly, e.g. "make -V FOO OSVERSION=xxx" is what
I miss.  Is there a way to allow it again somehow?

./danfe