From owner-cvs-src@FreeBSD.ORG Sun Jul 3 01:10:47 2005 Return-Path: X-Original-To: cvs-src@FreeBSD.ORG Delivered-To: cvs-src@FreeBSD.ORG Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 1222716A95E; Sun, 3 Jul 2005 00:58:34 +0000 (GMT) (envelope-from ps@mu.org) Received: from elvis.mu.org (elvis.mu.org [192.203.228.196]) by mx1.FreeBSD.org (Postfix) with ESMTP id E2E504468C; Sun, 3 Jul 2005 00:42:47 +0000 (GMT) (envelope-from ps@mu.org) Received: by elvis.mu.org (Postfix, from userid 1000) id AC09F6DCD2; Sat, 2 Jul 2005 17:38:10 -0700 (PDT) X-Original-To: ps@mu.org Delivered-To: ps@mu.org Received: from mx2.freebsd.org (mx2.freebsd.org [216.136.204.119]) by elvis.mu.org (Postfix) with ESMTP id 8DC835C991 for ; Tue, 25 Jan 2005 03:10:49 -0800 (PST) Received: from hub.freebsd.org (hub.freebsd.org [216.136.204.18]) by mx2.freebsd.org (Postfix) with ESMTP id 4AEEC564E5 for ; Tue, 25 Jan 2005 11:09:53 +0000 (GMT) (envelope-from owner-src-committers@FreeBSD.org) Received: by hub.freebsd.org (Postfix) id 4AC3716A544; Tue, 25 Jan 2005 11:09:37 +0000 (GMT) Delivered-To: ps@freebsd.org Received: by hub.freebsd.org (Postfix, from userid 538) id 82A7D16A4D0; Tue, 25 Jan 2005 11:09:35 +0000 (GMT) Delivered-To: src-committers@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 7D76A16A4CE; Tue, 25 Jan 2005 11:09:34 +0000 (GMT) Received: from critter.freebsd.dk (f170.freebsd.dk [212.242.86.170]) by mx1.FreeBSD.org (Postfix) with ESMTP id D3E0D43D41; Tue, 25 Jan 2005 11:09:33 +0000 (GMT) (envelope-from phk@critter.freebsd.dk) Received: from critter.freebsd.dk (localhost [127.0.0.1]) by critter.freebsd.dk (8.13.1/8.13.1) with ESMTP id j0PB9Xao081637; Tue, 25 Jan 2005 12:09:33 +0100 (CET) (envelope-from phk@critter.freebsd.dk) To: Andrey Chernov From: "Poul-Henning Kamp" In-Reply-To: Your message of "Tue, 25 Jan 2005 14:06:48 +0300." <20050125110648.GB29791@nagual.pp.ru> Message-ID: <81636.1106651373@critter.freebsd.dk> Sender: owner-src-committers@FreeBSD.org Precedence: bulk X-Loop: FreeBSD.ORG X-Spam-Checker-Version: SpamAssassin 3.0.1 (2004-10-22) on elvis.mu.org X-Spam-Status: No, score=-2.6 required=5.0 tests=AWL,BAYES_00 autolearn=ham version=3.0.1 X-Spam-Level: Cc: cvs-src@FreeBSD.ORG, src-committers@FreeBSD.ORG, cvs-all@FreeBSD.ORG Subject: Re: cvs commit: src/sys/kern sys_generic.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Date: Sun, 03 Jul 2005 01:10:48 -0000 X-Original-Date: Tue, 25 Jan 2005 12:09:33 +0100 X-List-Received-Date: Sun, 03 Jul 2005 01:10:48 -0000 In message <20050125110648.GB29791@nagual.pp.ru>, Andrey Chernov writes: >On Tue, Jan 25, 2005 at 01:58:11PM +0300, Andrey Chernov wrote: >> What's about "invalid buffer pointers" detection, directly mentioned in >> the standard (above)? Now it is broken for zero bytes read because your >> newly inserted check takes precedence. > >The next precedence violation candidate in error detection will be: > >"[EIO] >The process is a member of a background process attempting to read from >its controlling terminal, the process is ignoring or blocking the SIGTTIN >signal, or the process group is orphaned." > >I.e. look at ERRORS section list and inspect each errno returning broken >by preliminary zero bytes check. That's another check we didn't do before to the resid==0 handling before. Now, I'm going to killfile this subject until you come up with code which real-life code which breaks because of this, OK ? Bye... -- Poul-Henning Kamp | UNIX since Zilog Zeus 3.20 phk@FreeBSD.ORG | TCP/IP since RFC 956 FreeBSD committer | BSD since 4.3-tahoe Never attribute to malice what can adequately be explained by incompetence.