Date: Fri, 12 Aug 2022 10:50:56 +0200 From: Mathieu Arnold <mat@freebsd.org> To: Neel Chauhan <nc@freebsd.org> Cc: Fernando =?utf-8?Q?Apestegu=C3=ADa?= <fernando.apesteguia@gmail.com>, "ports-committers@FreeBSD.org" <ports-committers@freebsd.org>, dev-commits-ports-all@freebsd.org, dev-commits-ports-main@freebsd.org Subject: Re: git: 5d38de488ba0 - main - devel/gindent: fix build Message-ID: <20220812085056.cdj6chb5bnowemoc@aching.in.mat.cc> In-Reply-To: <7f81101cb04541949f4c7c54505c2349@FreeBSD.org> References: <202208092050.279Ko76l093213@gitrepo.freebsd.org> <CAGwOe2aZ87cW0dNMS0Gfs=KAFS1iTTHOuRTJJXokAhn_dUWjqw@mail.gmail.com> <7f81101cb04541949f4c7c54505c2349@FreeBSD.org>
next in thread | previous in thread | raw e-mail | index | archive | help
--dzac3qen2mcxeuyb Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Thu, Aug 11, 2022 at 09:02:37AM -0700, Neel Chauhan wrote: > Hi, >=20 > Sorry for the delay. >=20 > On 2022-08-09 13:49, Fernando Apestegu=EDa wrote: > > The issue is an unused variable. Wouldn't it be better to fix that > > instead of removing -Werror? Also sending that upstream would be nice. >=20 > This patch technically came from an outside contributor. I can submit a > patch to fix this and sent it upstream. The fact that we are committers mean that we review patchs from outside contributors and fix/change them to actually fix the problems we have. If we were simply applying patches without any thought, we could be replaced by a program called patch, and we would not be needed at all. --=20 Mathieu Arnold --dzac3qen2mcxeuyb Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQGTBAABCgB9FiEEFD4jMKwz5Ud8Ywu3ecmT/A9inX0FAmL2FGRfFIAAAAAALgAo aXNzdWVyLWZwckBub3RhdGlvbnMub3BlbnBncC5maWZ0aGhvcnNlbWFuLm5ldDE0 M0UyMzMwQUMzM0U1NDc3QzYzMEJCNzc5Qzk5M0ZDMEY2MjlEN0QACgkQecmT/A9i nX3c7gf/Q8HUjgWiaq5OofPDRQN701t8PvjFGpkHccXiNPmk+4sykLGa3e1/KhsK p3eHureUDMLQIWCXWPVKDGEw5bqFaAmaMlIsVojEhLT6r5/g+cv3q0qgffPz1AX9 dS2fTLQ7EMtFaEhff7lEvdAkq1mhpKdm40+z9UzYaMTGR/OwU1zyj1iqwIWVYzUg yE+5d5QPFJrpfnOfeudYCQh9MI94Sp//zAxwMCSLUbKR92wFMTrG9r4xKGYfAJXm 6QxN0ASz0JQRzaEHgafdTHAPNaHHNYVIMw6b422IzfrP8J0mabpCn7r6d4yeEUgB d0aMiqx/81mG3R3POuT33/f7dgchOg== =U976 -----END PGP SIGNATURE----- --dzac3qen2mcxeuyb--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20220812085056.cdj6chb5bnowemoc>