From owner-freebsd-gnome@FreeBSD.ORG Wed Jun 3 22:15:08 2009 Return-Path: Delivered-To: gnome@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 7BA34106564A for ; Wed, 3 Jun 2009 22:15:08 +0000 (UTC) (envelope-from ed@hoeg.nl) Received: from palm.hoeg.nl (mx0.hoeg.nl [IPv6:2001:7b8:613:100::211]) by mx1.freebsd.org (Postfix) with ESMTP id 44B528FC0A for ; Wed, 3 Jun 2009 22:15:08 +0000 (UTC) (envelope-from ed@hoeg.nl) Received: by palm.hoeg.nl (Postfix, from userid 1000) id A7B271CF8F; Thu, 4 Jun 2009 00:15:07 +0200 (CEST) Date: Thu, 4 Jun 2009 00:15:07 +0200 From: Ed Schouten To: gnome@FreeBSD.org Message-ID: <20090603221507.GC48776@hoeg.nl> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="fwVzdwcpG0LlK9IO" Content-Disposition: inline User-Agent: Mutt/1.5.19 (2009-01-05) Cc: Subject: [Patch] Build libiconv with USE_CSTD=gnu89 X-BeenThere: freebsd-gnome@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: GNOME for FreeBSD -- porting and maintaining List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 03 Jun 2009 22:15:08 -0000 --fwVzdwcpG0LlK9IO Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Hi all, Pav just added support to the Ports tree to easily specify the C standard in the port makefiles. Even though the compiler in our base system uses -std=3Dgnu89 by default, this behaviour could change in the future. Other compilers (like Clang) already use ISO C99 by default. In most cases this won't matter, but there are some subtleties. One of the ports that really requires the C standard to be set to gnu89, is libiconv. The problem is that this port uses GNU-style inlining, which is only enabled when building C89 code. I propose the following patch: --- converters/libiconv/Makefile +++ converters/libiconv/Makefile @@ -17,6 +17,7 @@ =20 USE_AUTOTOOLS=3D libtool:15 GNU_CONFIGURE=3D yes +USE_CSTD=3D gnu89 USE_GNOME=3D gnometarget LIBTOOLFILES=3D configure libcharset/configure CONFIGURE_ARGS=3D --enable-static \ It shouldn't change the behaviour of the port when using GCC, but allows us Clang folks to build libiconv out of the box. Erwin ran an experimental ports build with Clang on pointyhat and according to numbers, libiconv's failure caused it to skip compilation of 9600 other ports... Any comments? --=20 Ed Schouten WWW: http://80386.nl/ --fwVzdwcpG0LlK9IO Content-Type: application/pgp-signature Content-Disposition: inline -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.9 (FreeBSD) iEYEARECAAYFAkom9esACgkQ52SDGA2eCwUpYACfcYoT3bBlEZaY2QkUNyLnS5Nt RKIAnRkEa5vTGBTbTj2JDiElVjrjrgRO =y1j7 -----END PGP SIGNATURE----- --fwVzdwcpG0LlK9IO--