From owner-svn-src-all@FreeBSD.ORG Mon Sep 23 11:41:30 2013 Return-Path: Delivered-To: svn-src-all@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTP id 9EA328F4; Mon, 23 Sep 2013 11:41:30 +0000 (UTC) (envelope-from davide.italiano@gmail.com) Received: from mail-vc0-x231.google.com (mail-vc0-x231.google.com [IPv6:2607:f8b0:400c:c03::231]) (using TLSv1 with cipher ECDHE-RSA-RC4-SHA (128/128 bits)) (No client certificate requested) by mx1.freebsd.org (Postfix) with ESMTPS id 0FA06255A; Mon, 23 Sep 2013 11:41:29 +0000 (UTC) Received: by mail-vc0-f177.google.com with SMTP id hv10so2024839vcb.36 for ; Mon, 23 Sep 2013 04:41:29 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:sender:in-reply-to:references:date:message-id:subject :from:to:cc:content-type; bh=XIKKrqhATFr/D2j9yWNfJ+eDOpr16CtGIfG6AkNf9pY=; b=Djhzxyexj3FIX5ttmRHfNRvy4nkKEE5m0xOtMzE6oH7Lt17ZIo+BsSEJV9md6pzAIB Uy8WufE4VkytEXguBwDarLPTWl6pkR8hXR6Fm6qKfMv9KfIqQ0un2dlWwiafGW8fVKhk FHM9U4WUuWyTdaeIDt3CjgujCUWzRpvESn57emGaf5/5zjML++A961CJnQdTrjntm1rv +ayWJvkphnZqzcWputxqcyPdCDQDv1UtJr1ttYeafuYNN4nx+OMxxdXg60mHaFgUDNx+ vL/dfyo78TRBMJaTF5YtGHurPVmxPuVnRbcB6d1epRHL29ZsWoAZwLiE2w9CnHaL/qlt ST7w== MIME-Version: 1.0 X-Received: by 10.220.169.203 with SMTP id a11mr231699vcz.26.1379936489084; Mon, 23 Sep 2013 04:41:29 -0700 (PDT) Sender: davide.italiano@gmail.com Received: by 10.220.65.132 with HTTP; Mon, 23 Sep 2013 04:41:29 -0700 (PDT) In-Reply-To: <523FEA6B.6020402@FreeBSD.org> References: <201309100146.r8A1kmri091170@svn.freebsd.org> <523FEA6B.6020402@FreeBSD.org> Date: Mon, 23 Sep 2013 13:41:29 +0200 X-Google-Sender-Auth: d5563D4OnQ0gJpoEMWEWHxfz5XQ Message-ID: Subject: Re: svn commit: r255437 - in head: cddl/contrib/opensolaris/lib/libzpool/common cddl/contrib/opensolaris/lib/libzpool/common/sys sys/cddl/compat/opensolaris/sys sys/cddl/contrib/opensolaris/uts/common/... From: Davide Italiano To: Andriy Gapon Content-Type: text/plain; charset=ISO-8859-1 Cc: svn-src-head@freebsd.org, svn-src-all@freebsd.org, src-committers@freebsd.org, Xin LI X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 23 Sep 2013 11:41:30 -0000 On Mon, Sep 23, 2013 at 9:14 AM, Andriy Gapon wrote: > on 10/09/2013 15:03 Davide Italiano said the following: >> The Illumos cv_timedwait_hires() doesn't use 'res' argument so if you >> want to be consistent with their behaviour you should pass '0' as >> precision argument to cv_timedwait_sbt(). > > As far as I can see, illumos does use the resolution. > > -- > Andriy Gapon Hmm, it looks like I was looking at the wrong version of cv_timedwait_sbt() (the one in lib/libzpool/common/kernel.c), thanks for noticing. That said, I'm not still sure there's an 1:1 mapping between our precision concept and their (but I might be wrong here), and I think gethrestime is not suitable for the amount of precision required. -- Davide "There are no solved problems; there are only problems that are more or less solved" -- Henri Poincare