From owner-cvs-all@FreeBSD.ORG  Fri May  2 15:19:01 2003
Return-Path: <owner-cvs-all@FreeBSD.ORG>
Delivered-To: cvs-all@freebsd.org
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP id 69B9D37B404
	for <cvs-all@FreeBSD.org>; Fri,  2 May 2003 15:19:01 -0700 (PDT)
Received: from rootlabs.com (root.org [67.118.192.226])
	by mx1.FreeBSD.org (Postfix) with SMTP id 1017D43FE9
	for <cvs-all@FreeBSD.org>; Fri,  2 May 2003 15:18:59 -0700 (PDT)
	(envelope-from nate@rootlabs.com)
Received: (qmail 96528 invoked by uid 1000); 2 May 2003 22:19:01 -0000
Date: Fri, 2 May 2003 15:19:01 -0700 (PDT)
From: Nate Lawson <nate@root.org>
To: Prafulla Deuskar <pdeuskar@FreeBSD.org>
In-Reply-To: <20030502211722.9366F37B427@hub.freebsd.org>
Message-ID: <Pine.BSF.4.21.0305021516490.96473-100000@root.org>
MIME-Version: 1.0
Content-Type: TEXT/PLAIN; charset=US-ASCII
cc: cvs-src@FreeBSD.org
cc: src-committers@FreeBSD.org
cc: cvs-all@FreeBSD.org
Subject: Re: cvs commit: src/sys/dev/em if_em.c if_em.h if_em_hw.cif_em_hw.h
 if_em_osdep.h
X-BeenThere: cvs-all@freebsd.org
X-Mailman-Version: 2.1.1
Precedence: list
List-Id: CVS commit messages for the entire tree <cvs-all.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/cvs-all>,
	<mailto:cvs-all-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/cvs-all>
List-Post: <mailto:cvs-all@freebsd.org>
List-Help: <mailto:cvs-all-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/cvs-all>,
	<mailto:cvs-all-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Fri, 02 May 2003 22:19:02 -0000

On Fri, 2 May 2003, Prafulla Deuskar wrote:
>   Modified files:
>     sys/dev/em           if_em.c if_em.h if_em_hw.c if_em_hw.h 
>                          if_em_osdep.h 
>   Log:
>   - Bus DMA'fy the driver
>   - Use htole* macros where appropriate so that the driver could work on non-x86 architectures
>   - Use m_getcl() instead of MGETHDR/MCLGET macros
>   Submitted by:   sam (Sam Leffler)
>   
>   Revision  Changes    Path
>   1.23      +428 -235  src/sys/dev/em/if_em.c
>   1.14      +30 -1     src/sys/dev/em/if_em.h

In if_em.c, there are a huge number of whitespace changes intermixed with
the other changes.  It would help us review the changes better if you did
these in two separate commits (whitespace first).

>   1.8       +0 -0      src/sys/dev/em/if_em_hw.c
>   1.9       +0 -0      src/sys/dev/em/if_em_hw.h
>   1.11      +0 -0      src/sys/dev/em/if_em_osdep.h

It's also helpful to only commit files that you are making changes to.

Thanks,
-Nate