From owner-svn-src-head@FreeBSD.ORG  Sun Sep 14 08:59:41 2014
Return-Path: <owner-svn-src-head@FreeBSD.ORG>
Delivered-To: svn-src-head@freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [8.8.178.115])
 (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits))
 (No client certificate requested)
 by hub.freebsd.org (Postfix) with ESMTPS id 7D389322;
 Sun, 14 Sep 2014 08:59:41 +0000 (UTC)
Received: from mail.turbocat.net (mail.turbocat.net
 [IPv6:2a01:4f8:d16:4514::2])
 (using TLSv1.1 with cipher ECDHE-RSA-AES256-SHA (256/256 bits))
 (Client did not present a certificate)
 by mx1.freebsd.org (Postfix) with ESMTPS id 3E4139F3;
 Sun, 14 Sep 2014 08:59:41 +0000 (UTC)
Received: from laptop015.home.selasky.org
 (cm-176.74.213.204.customer.telag.net [176.74.213.204])
 (using TLSv1 with cipher ECDHE-RSA-AES128-SHA (128/128 bits))
 (No client certificate requested)
 by mail.turbocat.net (Postfix) with ESMTPSA id 75C7E1FE027;
 Sun, 14 Sep 2014 10:59:38 +0200 (CEST)
Message-ID: <541558EF.2090700@selasky.org>
Date: Sun, 14 Sep 2014 10:59:27 +0200
From: Hans Petter Selasky <hps@selasky.org>
User-Agent: Mozilla/5.0 (X11; FreeBSD amd64;
 rv:24.0) Gecko/20100101 Thunderbird/24.1.0
MIME-Version: 1.0
To: Rick Macklem <rmacklem@uoguelph.ca>
Subject: Re: svn commit: r271504 - in head/sys: dev/oce dev/vmware/vmxnet3
 dev/xen/netfront net netinet ofed/drivers/net/mlx4
References: <597691144.35887030.1410644742707.JavaMail.root@uoguelph.ca>
In-Reply-To: <597691144.35887030.1410644742707.JavaMail.root@uoguelph.ca>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
Cc: svn-src-head@freebsd.org, svn-src-all@freebsd.org,
 src-committers@freebsd.org, Adrian Chadd <adrian@freebsd.org>
X-BeenThere: svn-src-head@freebsd.org
X-Mailman-Version: 2.1.18-1
Precedence: list
List-Id: SVN commit messages for the src tree for head/-current
 <svn-src-head.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/options/svn-src-head>,
 <mailto:svn-src-head-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/svn-src-head/>
List-Post: <mailto:svn-src-head@freebsd.org>
List-Help: <mailto:svn-src-head-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/svn-src-head>,
 <mailto:svn-src-head-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Sun, 14 Sep 2014 08:59:41 -0000

On 09/13/14 23:45, Rick Macklem wrote:
> Hans Petter Selasky wrote:
>> On 09/13/14 18:54, Adrian Chadd wrote:
>>> Hi,
>>>
>>> Just for the record:
>>>
>>> * I'm glad you're tackling the TSO config stuff;
>>> * I'm not glad you're trying to pack it into a u_int rather than
>>> creating a new structure and adding fields for it.
>>>
>>> I appreciate that you're trying to rush this in before 10.1, but
>>> this
>>> is exactly why things shouldn't be rushed in before release
>>> deadlines.
>>> :)
>>>
>>> I'd really like to see this be broken out as a structure and the
>>> bit
>>> shifting games for what really shouldn't be packed into a u_int
>>> fixed.
>>> Otherwise this is going to be deadweight that has to persist past
>>> 11.0.
>>>
>>
>> Hi Adrian,
>>
>> I can make that change for -current, making the new structure and
>> such.
>> This change was intended for 10 where there is only one u_int for
>> this
>> information. Or do you want me to change that in 10 too?
>>
>> --HPS
>>
>>
>>
> Btw, your patch calls sbsndptr() in tcp_output(), which advances
> sb_sndptroff and sb_sndptr by the length.
> Then it loops around and reduces the length for the case where
> there are too many mbufs in the chain.
>

Right, though this patch would need to understand segment lengths too 
and not only count them.

--HPS