From owner-svn-src-head@freebsd.org Thu Sep 26 20:08:27 2019 Return-Path: Delivered-To: svn-src-head@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id 5B50F132EE4; Thu, 26 Sep 2019 20:08:27 +0000 (UTC) (envelope-from cy.schubert@cschubert.com) Received: from smtp-out-no.shaw.ca (smtp-out-no.shaw.ca [64.59.134.12]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client CN "Client", Issuer "CA" (not verified)) by mx1.freebsd.org (Postfix) with ESMTPS id 46fQwT6TNwz3Pht; Thu, 26 Sep 2019 20:08:25 +0000 (UTC) (envelope-from cy.schubert@cschubert.com) Received: from spqr.komquats.com ([70.67.125.17]) by shaw.ca with ESMTPA id Da3nixy7gUIS2Da3piLRxb; Thu, 26 Sep 2019 14:08:23 -0600 X-Authority-Analysis: v=2.3 cv=N41X6F1B c=1 sm=1 tr=0 a=VFtTW3WuZNDh6VkGe7fA3g==:117 a=VFtTW3WuZNDh6VkGe7fA3g==:17 a=kj9zAlcOel0A:10 a=J70Eh1EUuV4A:10 a=ZLGELXoPAAAA:8 a=pGLkceISAAAA:8 a=7Qk2ozbKAAAA:8 a=6I5d2MoRAAAA:8 a=dcyhuPvDAAAA:20 a=YxBL1-UpAAAA:8 a=VoPBE_-ZxDEe_ZgKJXAA:9 a=0FOF6Mua-JtfXzO1:21 a=MEIUBk5u1Ak215Ym:21 a=CjuIK1q_8ugA:10 a=CFiPc5v16LZhaT-MVE1c:22 a=1lyxoWkJIXJV6VJUPhuM:22 a=IjZwj45LgO3ly-622nXo:22 a=Ia-lj3WSrqcvXOmTRaiG:22 Received: from slippy.cwsent.com (slippy8 [10.2.2.6]) by spqr.komquats.com (Postfix) with ESMTPS id B1613B2F; Thu, 26 Sep 2019 13:08:17 -0700 (PDT) Received: from slippy.cwsent.com (localhost [127.0.0.1]) by slippy.cwsent.com (8.15.2/8.15.2) with ESMTP id x8QK8HuE008939; Thu, 26 Sep 2019 13:08:17 -0700 (PDT) (envelope-from Cy.Schubert@cschubert.com) Received: from slippy (cy@localhost) by slippy.cwsent.com (8.15.2/8.15.2/Submit) with ESMTP id x8QK8GPB008931; Thu, 26 Sep 2019 13:08:16 -0700 (PDT) (envelope-from Cy.Schubert@cschubert.com) Message-Id: <201909262008.x8QK8GPB008931@slippy.cwsent.com> X-Authentication-Warning: slippy.cwsent.com: cy owned process doing -bs X-Mailer: exmh version 2.9.0 11/07/2018 with nmh-1.7.1 Reply-to: Cy Schubert From: Cy Schubert X-os: FreeBSD X-Sender: cy@cwsent.com X-URL: http://www.cschubert.com/ To: "Josh Paetzel" cc: "Warner Losh" , "Ryan Stone" , "Niclas Zeising" , "Charlie Li" , "Kyle Evans" , svn-src-head , "Charlie Li via svn-src-all" , "Gleb Smirnoff" , src-committers , "FreeBSD X11 mailing list" Subject: Re: svn commit: r352707 - in head/sys: conf kern net sys In-reply-to: <6f50f518-0f8e-4e82-a9e9-b9db14cdb648@www.fastmail.com> References: <201909251826.x8PIQVUN095257@repo.freebsd.org> <605f210b-cce2-d842-cc0c-53b76ef7dbd5@vishwin.info> <1681db78-6a0c-55cf-1e01-65e06f145975@vishwin.info> <18644033-d01e-1bc7-02eb-42999033d8fd@freebsd.org> <6f50f518-0f8e-4e82-a9e9-b9db14cdb648@www.fastmail.com> Comments: In-reply-to "Josh Paetzel" message dated "Thu, 26 Sep 2019 14:50:23 -0500." Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-CMAE-Envelope: MS4wfPBmFdxWv6ddqKhneUxKsXreYloAmtKvlqoUEFdWX9nQ/lpiAplUDMT0Unv8xUmTEGISyfEbWpjq5kVtd+dfMe9Cm6bE8+nHQb2xTaOr5aNX+J8EOfCn HJUQrRtHCQFIY9rqoo/sCaQx6FI1u8j+HVU9AEhjLq7twKgeuQffflkyM/FMlaUa6xedLWZ/lfXzzKJHG4k7dSoGty/vDBX6nJETEbcbxapuvs+OTxLPHki3 bckURZCDReOUgxVN17X0uuyZDHhmHwnjV71y35jAXZaBilTA+MRBhzlnZU5nXdUPj3pj7N1ADd8/VJVfiXC15Fetp7EIjukIH97Xv9tGxwXdnMcdZ1o8kTO4 2O0ag4groyu9JD5blRBwaV18HeYuPWfdKuyZjRP0sdZkQFKeVCfqTk4I73fQfWYC24Ca8aoSh69GZhyZGL64qHSvpP59Naz09y2N+JJpZcEnthlJN29uniPs ec1O5uBY9NwG61mK X-Rspamd-Queue-Id: 46fQwT6TNwz3Pht X-Spamd-Bar: -- Authentication-Results: mx1.freebsd.org; dkim=none; spf=none (mx1.freebsd.org: domain of cy.schubert@cschubert.com has no SPF policy when checking 64.59.134.12) smtp.mailfrom=cy.schubert@cschubert.com X-Spamd-Result: default: False [-2.49 / 15.00]; RCVD_VIA_SMTP_AUTH(0.00)[]; HAS_REPLYTO(0.00)[Cy.Schubert@cschubert.com]; MV_CASE(0.50)[]; HAS_XAW(0.00)[]; TO_DN_ALL(0.00)[]; RCPT_COUNT_SEVEN(0.00)[11]; RECEIVED_SPAMHAUS_PBL(0.00)[17.125.67.70.khpj7ygk5idzvmvt5x4ziurxhy.zen.dq.spamhaus.net : 127.0.0.11]; FROM_EQ_ENVFROM(0.00)[]; R_DKIM_NA(0.00)[]; ASN(0.00)[asn:6327, ipnet:64.59.128.0/20, country:CA]; MIME_TRACE(0.00)[0:+]; ARC_NA(0.00)[]; NEURAL_HAM_MEDIUM(-1.00)[-0.999,0]; RCVD_COUNT_FIVE(0.00)[5]; REPLYTO_EQ_FROM(0.00)[]; RCVD_TLS_LAST(0.00)[]; FROM_HAS_DN(0.00)[]; NEURAL_HAM_LONG(-1.00)[-1.000,0]; TAGGED_RCPT(0.00)[freebsd]; IP_SCORE(-2.39)[ip: (-6.41), ipnet: 64.59.128.0/20(-3.07), asn: 6327(-2.39), country: CA(-0.09)]; MIME_GOOD(-0.10)[text/plain]; TO_MATCH_ENVRCPT_SOME(0.00)[]; RCVD_IN_DNSWL_NONE(0.00)[12.134.59.64.list.dnswl.org : 127.0.5.0]; R_SPF_NA(0.00)[]; RWL_MAILSPIKE_POSSIBLE(0.00)[12.134.59.64.rep.mailspike.net : 127.0.0.17]; SUSPICIOUS_RECIPS(1.50)[] X-Mailman-Approved-At: Sat, 12 Oct 2019 23:41:31 +0000 X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Date: Thu, 26 Sep 2019 20:08:27 -0000 X-Original-Date: Thu, 26 Sep 2019 13:08:16 -0700 X-List-Received-Date: Thu, 26 Sep 2019 20:08:27 -0000 In message <6f50f518-0f8e-4e82-a9e9-b9db14cdb648@www.fastmail.com>, "Josh Paetz el" writes: > > > On Thu, Sep 26, 2019, at 12:34 PM, Warner Losh wrote: > > Kinda my point exactly... > > > > Warner > > > > On Thu, Sep 26, 2019 at 11:25 AM Ryan Stone wrote: > >> We also shouldn't have ifdef's that change the size of a kernel > >> structure that's part of the KBI. Isn't struct epoch_tracker part of > >> the KBI? > >> > >> On Thu, Sep 26, 2019 at 12:46 PM Warner Losh wrote: > >> > > >> > But we shouldn't be including opt_foo.h files in sys/*.h files. That's > the root cause of trouble here. > >> > > >> > Warner > >> > > >> > On Thu, Sep 26, 2019 at 9:11 AM Niclas Zeising wr > ote: > >> >> > >> >> On 2019-09-26 17:03, Charlie Li via freebsd-x11 wrote: > >> >> > Kyle Evans wrote: > >> >> >> On Thu, Sep 26, 2019 at 9:49 AM Charlie Li wrote: > >> >> >>> This breaks building the drm-kmod ports, as the build cannot find > >> >> >>> opt_epoch.h (drm-devel-kmod example shown, drm-current-kmod dies t > he > >> >> >>> exact same way): > >> >> >>> > >> >> >>> --- linux_anon_inodes.o --- > >> >> >>> cc -O2 -pipe -fno-strict-aliasing -include > >> >> >>> /wrkdirs/usr/ports/graphics/drm-devel-kmod/work/kms-drm-dc414a9/dr > ivers/gpu/drm/drm_os_config.h > >> >> >>> '-DKBUILD_MODNAME="linuxkpi_gplv2"' -Werror -D_KERNEL -DKLD_MODULE > >> >> >>> -nostdinc > >> >> >>> -I/wrkdirs/usr/ports/graphics/drm-devel-kmod/work/kms-drm-dc414a9/ > include -I/wrkdirs/usr/ports/graphics/drm-devel-kmod/work/kms-drm-dc414a9/lin > uxkpi/dummy/include > >> >> >>> -I/wrkdirs/usr/ports/graphics/drm-devel-kmod/work/kms-drm-dc414a9/ > linuxkpi/gplv2/include > >> >> >>> -I/usr/src/sys/compat/linuxkpi/common/include -I. -I/usr/src/sys > >> >> >>> -I/usr/src/sys/contrib/ck/include -fno-common -fno-omit-frame-poin > ter > >> >> >>> -mno-omit-leaf-frame-pointer > >> >> >>> -fdebug-prefix-map=./machine=/usr/src/sys/amd64/include > >> >> >>> -fdebug-prefix-map=./x86=/usr/src/sys/x86/include -MD > >> >> >>> -MF.depend.linux_anon_inodes.o -MTlinux_anon_inodes.o -mcmodel=ker > nel > >> >> >>> -mno-red-zone -mno-mmx -mno-sse -msoft-float > >> >> >>> -fno-asynchronous-unwind-tables -ffreestanding -fwrapv -fstack-pro > tector > >> >> >>> -Wall -Wredundant-decls -Wnested-externs -Wstrict-prototypes > >> >> >>> -Wmissing-prototypes -Wpointer-arith -Wcast-qual -Wundef > >> >> >>> -Wno-pointer-sign -D__printf__=__freebsd_kprintf__ > >> >> >>> -Wmissing-include-dirs -fdiagnostics-show-option -Wno-unknown-prag > mas > >> >> >>> -Wno-error-tautological-compare -Wno-error-empty-body > >> >> >>> -Wno-error-parentheses-equality -Wno-error-unused-function > >> >> >>> -Wno-error-pointer-sign -Wno-error-shift-negative-value > >> >> >>> -Wno-address-of-packed-member -Wno-format-zero-length -Wno-pointer > -arith > >> >> >>> -mno-aes -mno-avx -std=iso9899:1999 -c > >> >> >>> /wrkdirs/usr/ports/graphics/drm-devel-kmod/work/kms-drm-dc414a9/li > nuxkpi/gplv2/src/linux_anon_inodes.c > >> >> >>> -o linux_anon_inodes.o > >> >> >>> In file included from > >> >> >>> /wrkdirs/usr/ports/graphics/drm-devel-kmod/work/kms-drm-dc414a9/li > nuxkpi/gplv2/src/linux_anon_inodes.c:12: > >> >> >>> In file included from > >> >> >>> /wrkdirs/usr/ports/graphics/drm-devel-kmod/work/kms-drm-dc414a9/li > nuxkpi/gplv2/include/linux/anon_inodes.h:4: > >> >> >>> In file included from > >> >> >>> /wrkdirs/usr/ports/graphics/drm-devel-kmod/work/kms-drm-dc414a9/li > nuxkpi/gplv2/include/linux/fs.h:6: > >> >> >>> In file included from > >> >> >>> /wrkdirs/usr/ports/graphics/drm-devel-kmod/work/kms-drm-dc414a9/li > nuxkpi/gplv2/include/linux/shrinker.h:5: > >> >> >>> In file included from > >> >> >>> /usr/src/sys/compat/linuxkpi/common/include/linux/list.h:56: > >> >> >>> In file included from /usr/src/sys/net/if_var.h:83: > >> >> >>> /usr/src/sys/sys/epoch.h:44:10: fatal error: 'opt_epoch.h' file no > t found > >> >> >>> #include "opt_epoch.h" > >> >> >>> ^~~~~~~~~~~~~ > >> >> >>> --- linux_anon_inodefs.o --- > >> >> >>> In file included from > >> >> >>> /wrkdirs/usr/ports/graphics/drm-devel-kmod/work/kms-drm-dc414a9/li > nuxkpi/gplv2/src/linux_anon_inodefs.c:45: > >> >> >>> In file included from > >> >> >>> /wrkdirs/usr/ports/graphics/drm-devel-kmod/work/kms-drm-dc414a9/li > nuxkpi/gplv2/include/linux/debugfs.h:18: > >> >> >>> In file included from > >> >> >>> /wrkdirs/usr/ports/graphics/drm-devel-kmod/work/kms-drm-dc414a9/li > nuxkpi/gplv2/include/linux/fs.h:6: > >> >> >>> In file included from > >> >> >>> /wrkdirs/usr/ports/graphics/drm-devel-kmod/work/kms-drm-dc414a9/li > nuxkpi/gplv2/include/linux/shrinker.h:5: > >> >> >>> In file included from > >> >> >>> /usr/src/sys/compat/linuxkpi/common/include/linux/list.h:56: > >> >> >>> In file included from /usr/src/sys/net/if_var.h:83: > >> >> >>> /usr/src/sys/sys/epoch.h:44:10: fatal error: 'opt_epoch.h' file no > t found > >> >> >>> #include "opt_epoch.h" > >> >> >>> ^~~~~~~~~~~~~ > >> >> >>> --- linux_anon_inodes.o --- > >> >> >>> 1 error generated. > >> >> >>> *** [linux_anon_inodes.o] Error code 1 > >> >> >>> > >> >> >>> make[2]: stopped in > >> >> >>> /wrkdirs/usr/ports/graphics/drm-devel-kmod/work/kms-drm-dc414a9/li > nuxkpi > >> >> >>> --- linux_anon_inodefs.o --- > >> >> >>> 1 error generated. > >> >> >>> *** [linux_anon_inodefs.o] Error code 1 > >> >> >>> > >> >> >>> Interestingly enough, does not happen when drm-current-kmod is bui > lt as > >> >> >>> part of buildkernel (using an existing installed package with SOUR > CE on). > >> >> >>> > >> >> >> > >> >> >> FWIW, johalun noticed this yesterday and addressed it here: > >> >> >> https://github.com/FreeBSDDesktop/kms-drm/commit/b486949e7e9f0cfe8d > ac5f0ac7fe1a660300981d > >> >> >> > >> >> > Ah, of course I would miss these commits in the kms-drm repo, > >> >> > considering that I watch them roll in. Will wait for the updated > >> >> > snapshots in ports. > >> >> > > >> >> > >> >> I'll get to updating the ports as soon as I can. > >> >> Regards > >> >> -- > >> >> Niclas Zeising > >> >> _______________________________________________ > >> >> freebsd-x11@freebsd.org mailing list > >> >> https://lists.freebsd.org/mailman/listinfo/freebsd-x11 > >> >> To unsubscribe, send any mail to "freebsd-x11-unsubscribe@freebsd.org" > > This commit broke emulators/open-vm-tools (which builds an out of tree if_vmx > ) > > Should I chase a fix for it or wait for this to get resolved in src? virtualbox-ose-kmod: --- VBoxNetFlt-freebsd.o --- In file included from VBoxNetFlt-freebsd.c:51: In file included from /usr/src/sys/net/if_var.h:83: /usr/src/sys/sys/epoch.h:44:10: fatal error: 'opt_epoch.h' file not found #include "opt_epoch.h" ^~~~~~~~~~~~~ 1 error generated. *** [VBoxNetFlt-freebsd.o] Error code 1 -- Cheers, Cy Schubert FreeBSD UNIX: Web: http://www.FreeBSD.org The need of the many outweighs the greed of the few.