Date: Sat, 13 Jul 2002 16:44:24 +0200 (CEST) From: Alexander Leidinger <Alexander@Leidinger.net> To: cyrille.lefevre@laposte.net Cc: dwcjr@inethouston.net, freebsd-ports@FreeBSD.ORG Subject: Re: ports/39606: Updated port: audio/lame (3.92) Message-ID: <200207131444.g6DEiOxQ098924@Magelan.Leidinger.net> In-Reply-To: <20020713140358.GA35227@gits.dyndns.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On 13 Jul, Cyrille Lefevre wrote:
> message resent due to mta misconfigation.
>
> On Thu, Jul 11, 2002 at 04:53:41AM +0200, Cyrille Lefevre wrote:
>> On Tue, Jul 09, 2002 at 11:13:41PM +0200, Alexander Leidinger wrote:
[...]
>> > [recent vorbis support]
>> > Are you willing to produce patches for configure.in/Makefile.am ...
>> what kind of patch ? vorbis rules already exists and there is
>> nothing to do w/ the fact that you NEED the vorbis sources
>> to build lame w/ vorbis support... this is absolutly non-standard.
>> except if you want something like --with-vorbis-prefix-src= ?
Yes, and an explanation for the user why this is the case.
>> also, from version to version vorbis change ther "internal" API
>> which is used by libmp3lame/vorbis_interface.c which need to be
>> adapted everytime to seek vorbis. not my fault.
The FreeBSD ports tree is the only user of the vorbis part of lame. At
least your patches are responsible that it actually works with a recent
vorbis. Actually it isn't really supported by the LAME dev team and it
may vanish into the attic if nobody shows interest in keeping it up to
date.
>> [about the current version w/o SSE, gogo asm nor vorbis]
>> make test give me this on my machine (P200)...
I was only interested in a make test of the non default code paths
(FFTSSE, FFTFPU), I expect either a lot of differences with them, or no
major speedup.
[...]
>> cmp -l testcase.new.mp3 ./testcase.mp3 | wc -l
>> 5
>> where `cmp -l testcase.new.mp3 ./testcase.mp3' is :
>> 78 100 112
>> 103 200 212
>> 128 300 312
>> 191 110 12
>> 192 13 351
Small differences are normal. It depends on the used compiler, the
options for the compiler, ...
>> Index: Makefile
>> ===================================================================
>> RCS file: /home/ncvs/ports/audio/lame/Makefile,v
>> retrieving revision 1.21
>> diff -u -r1.21 Makefile
>> --- Makefile 22 Apr 2002 01:22:48 -0000 1.21
>> +++ Makefile 11 Jul 2002 02:29:01 -0000
[...]
>> +.if !defined(WITHOUT_VORBIS)
>> +LIB_DEPENDS= vorbis.1:${PORTSDIR}/audio/libvorbis
Do we really need vorbis support in LAME? The support was intended to
have a command line utility at a time where vorbis hadn't a good command
line utility.
>> +USE_GMAKE= yes
It doesn't neet gmake.
>> +install-la:
>> + @${INSTALL_SCRIPT} ${WRKSRC}/libmp3lame/libmp3lame.la ${PREFIX}/lib
We don't need the .la file.
Bye,
Alexander.
--
If Bill Gates had a dime for every time a Windows box crashed...
...Oh, wait a minute, he already does.
http://www.Leidinger.net Alexander @ Leidinger.net
GPG fingerprint = C518 BC70 E67F 143F BE91 3365 79E2 9C60 B006 3FE7
To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe freebsd-ports" in the body of the message
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?200207131444.g6DEiOxQ098924>