From owner-svn-src-all@freebsd.org Thu Apr 19 15:40:59 2018 Return-Path: Delivered-To: svn-src-all@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 2F6CAF8590C; Thu, 19 Apr 2018 15:40:59 +0000 (UTC) (envelope-from freebsd@pdx.rh.CN85.dnsmgr.net) Received: from pdx.rh.CN85.dnsmgr.net (br1.CN84in.dnsmgr.net [69.59.192.140]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 6D9756F89F; Thu, 19 Apr 2018 15:40:58 +0000 (UTC) (envelope-from freebsd@pdx.rh.CN85.dnsmgr.net) Received: from pdx.rh.CN85.dnsmgr.net (localhost [127.0.0.1]) by pdx.rh.CN85.dnsmgr.net (8.13.3/8.13.3) with ESMTP id w3JFesws066489; Thu, 19 Apr 2018 08:40:54 -0700 (PDT) (envelope-from freebsd@pdx.rh.CN85.dnsmgr.net) Received: (from freebsd@localhost) by pdx.rh.CN85.dnsmgr.net (8.13.3/8.13.3/Submit) id w3JFesdQ066488; Thu, 19 Apr 2018 08:40:54 -0700 (PDT) (envelope-from freebsd) From: "Rodney W. Grimes" Message-Id: <201804191540.w3JFesdQ066488@pdx.rh.CN85.dnsmgr.net> Subject: Re: svn commit: r332773 - head/etc/rc.d In-Reply-To: To: Kyle Evans Date: Thu, 19 Apr 2018 08:40:54 -0700 (PDT) CC: Warner Losh , "Rodney W. Grimes" , src-committers , svn-src-all@freebsd.org, svn-src-head@freebsd.org Reply-To: rgrimes@freebsd.org X-Mailer: ELM [version 2.4ME+ PL121h (25)] MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset=US-ASCII X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.25 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 19 Apr 2018 15:40:59 -0000 > On Thu, Apr 19, 2018 at 10:21 AM, Kyle Evans wrote: > > On Thu, Apr 19, 2018 at 10:19 AM, Warner Losh wrote: > >> > >> > >> On Thu, Apr 19, 2018 at 9:17 AM, Kyle Evans wrote: > >>> > >>> On Thu, Apr 19, 2018 at 10:16 AM, Rodney W. Grimes > >>> wrote: > >>> >> Author: kevans > >>> >> Date: Thu Apr 19 15:02:53 2018 > >>> >> New Revision: 332773 > >>> >> URL: https://svnweb.freebsd.org/changeset/base/332773 > >>> >> > >>> >> Log: > >>> >> Fix ddb rc script > >>> >> > >>> >> r288291 added a call to limits(1), which isn't available before > >>> >> partitions > >>> >> are mounted. This broke the ddb rc script, which does not provide its > >>> >> own > >>> >> start_cmd. > >>> >> > >>> >> Alleviate the situation here by providing a start_cmd. We still have > >>> >> other > >>> >> problems with diskless setups that need to be considered, but this is > >>> >> a > >>> >> start. > >>> > > >>> > Thanks, > >>> > Also didn't cy identify a second one of these? > >>> > Or am I confusing yet another issue? > >>> > > >>> > >>> He identified a second early script that didn't specify start_cmd, but > >>> it was a non-issue because it's invoked independently of rc.subr. > >> > >> > >> One would think that it shouldn't invoke limits at all if foo_limits= wasn't > >> specified... Would make the feature much less invasive. I agree. This should be implemented, if it isn't already working that way. > >> > > > > foo_limits was introduced long after the initial invocation, which was > > introduced to enforce consistent limits of daemons run from rc.subr. > > Not doing this due to the lack of foo_flags would certainly kill the > > original intent, I'm afraid. > > I do wonder if some kind of kenv var or something would be appropriate > to disable this whole mess for some setups that it just clearly won't > work in, but maybe that's a terrible thought. I think you miss understood Warner. He is saying that if there is no rc var *_limits there should be no invocation of limits(1) at all, making much of this whole mess for many of us a NOP. I actually believe that is how the code already works, but not sure. -- Rod Grimes rgrimes@freebsd.org