From owner-svn-src-all@freebsd.org  Thu Dec  3 17:14:20 2015
Return-Path: <owner-svn-src-all@freebsd.org>
Delivered-To: svn-src-all@mailman.ysv.freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org
 [IPv6:2001:1900:2254:206a::19:1])
 by mailman.ysv.freebsd.org (Postfix) with ESMTP id 354CEA3FB65;
 Thu,  3 Dec 2015 17:14:20 +0000 (UTC)
 (envelope-from kostikbel@gmail.com)
Received: from kib.kiev.ua (kib.kiev.ua [IPv6:2001:470:d5e7:1::1])
 (using TLSv1 with cipher DHE-RSA-CAMELLIA256-SHA (256/256 bits))
 (Client did not present a certificate)
 by mx1.freebsd.org (Postfix) with ESMTPS id BDFDC1584;
 Thu,  3 Dec 2015 17:14:19 +0000 (UTC)
 (envelope-from kostikbel@gmail.com)
Received: from tom.home (kostik@localhost [127.0.0.1])
 by kib.kiev.ua (8.15.2/8.15.2) with ESMTPS id tB3HEAZR071421
 (version=TLSv1 cipher=DHE-RSA-CAMELLIA256-SHA bits=256 verify=NO);
 Thu, 3 Dec 2015 19:14:11 +0200 (EET)
 (envelope-from kostikbel@gmail.com)
DKIM-Filter: OpenDKIM Filter v2.10.3 kib.kiev.ua tB3HEAZR071421
Received: (from kostik@localhost)
 by tom.home (8.15.2/8.15.2/Submit) id tB3HEA1m071420;
 Thu, 3 Dec 2015 19:14:10 +0200 (EET)
 (envelope-from kostikbel@gmail.com)
X-Authentication-Warning: tom.home: kostik set sender to kostikbel@gmail.com
 using -f
Date: Thu, 3 Dec 2015 19:14:10 +0200
From: Konstantin Belousov <kostikbel@gmail.com>
To: Nathan Whitehorn <nwhitehorn@freebsd.org>
Cc: src-committers@freebsd.org, svn-src-all@freebsd.org,
 svn-src-head@freebsd.org
Subject: Re: svn commit: r291666 - head/libexec/rtld-elf
Message-ID: <20151203171410.GL2405@kib.kiev.ua>
References: <201512030006.tB306xTa074887@repo.freebsd.org>
 <20151203085028.GH2405@kib.kiev.ua> <566062EB.7070200@freebsd.org>
 <566075E4.8090202@freebsd.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <566075E4.8090202@freebsd.org>
User-Agent: Mutt/1.5.24 (2015-08-30)
X-Spam-Status: No, score=-2.0 required=5.0 tests=ALL_TRUSTED,BAYES_00,
 DKIM_ADSP_CUSTOM_MED,FREEMAIL_FROM,NML_ADSP_CUSTOM_MED autolearn=no
 autolearn_force=no version=3.4.1
X-Spam-Checker-Version: SpamAssassin 3.4.1 (2015-04-28) on tom.home
X-BeenThere: svn-src-all@freebsd.org
X-Mailman-Version: 2.1.20
Precedence: list
List-Id: "SVN commit messages for the entire src tree \(except for &quot;
 user&quot; and &quot; projects&quot; \)" <svn-src-all.freebsd.org>
List-Unsubscribe: <https://lists.freebsd.org/mailman/options/svn-src-all>,
 <mailto:svn-src-all-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/svn-src-all/>
List-Post: <mailto:svn-src-all@freebsd.org>
List-Help: <mailto:svn-src-all-request@freebsd.org?subject=help>
List-Subscribe: <https://lists.freebsd.org/mailman/listinfo/svn-src-all>,
 <mailto:svn-src-all-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Thu, 03 Dec 2015 17:14:20 -0000

On Thu, Dec 03, 2015 at 09:03:32AM -0800, Nathan Whitehorn wrote:
> 
> 
> On 12/03/15 07:42, Nathan Whitehorn wrote:
> >
> >
> > On 12/03/15 00:50, Konstantin Belousov wrote:
> >> On Thu, Dec 03, 2015 at 12:06:59AM +0000, Nathan Whitehorn wrote:
> >>> Author: nwhitehorn
> >>> Date: Thu Dec  3 00:06:59 2015
> >>> New Revision: 291666
> >>> URL: https://svnweb.freebsd.org/changeset/base/291666
> >>>
> >>> Log:
> >>>    Fix build on GCC 5.2 where, at least on PPC64, the compiler would 
> >>> "optimize"
> >>>    the malloc() + memset() in the local implementation of calloc() 
> >>> into a call
> >>>    to calloc(), helpfully turning it into an infinite loop. Clean up 
> >>> some
> >>>    unneeded flags on PPC64 while here.
> >>>       MFC after:    1 month
> >>>
> >>> Modified:
> >>>    head/libexec/rtld-elf/Makefile
> >>>
> >>> Modified: head/libexec/rtld-elf/Makefile
> >>> ============================================================================== 
> >>>
> >>> --- head/libexec/rtld-elf/Makefile    Thu Dec  3 00:02:01 2015    
> >>> (r291665)
> >>> +++ head/libexec/rtld-elf/Makefile    Thu Dec  3 00:06:59 2015    
> >>> (r291666)
> >>> @@ -13,7 +13,7 @@ SRCS=        rtld_start.S \
> >>>           malloc.c xmalloc.c debug.c libmap.c
> >>>   MAN=        rtld.1
> >>>   CSTD?=        gnu99
> >>> -CFLAGS+=    -Wall -DFREEBSD_ELF -DIN_RTLD
> >>> +CFLAGS+=    -Wall -DFREEBSD_ELF -DIN_RTLD -fno-builtin
> >>>   CFLAGS+=    -I${SRCTOP}/lib/csu/common
> >>>   .if exists(${.CURDIR}/${MACHINE_ARCH})
> >>>   RTLD_ARCH=    ${MACHINE_ARCH}
> >>> @@ -22,7 +22,6 @@ RTLD_ARCH=    ${MACHINE_CPUARCH}
> >>>   .endif
> >>>   CFLAGS+=    -I${.CURDIR}/${RTLD_ARCH} -I${.CURDIR}
> >>>   .if ${MACHINE_ARCH} == "powerpc64"
> >>> -CFLAGS+=    -mcall-aixdesc
> >> I wanted to set -ffreestanding for rtld compilation, but considered 
> >> it only
> >> a minor issue.  Could you test this instead of -fno-builtin, please ?
> >>
> >
> > Sure, I'll test it today.
> > -Nathan
> >
> >
> 
> -ffreestanding works just as well for this as -fno-builtin. Would you 
> like to make the change?

Please go ahead.