From owner-svn-ports-all@freebsd.org  Wed Jan 13 04:02:25 2016
Return-Path: <owner-svn-ports-all@freebsd.org>
Delivered-To: svn-ports-all@mailman.ysv.freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org
 [IPv6:2001:1900:2254:206a::19:1])
 by mailman.ysv.freebsd.org (Postfix) with ESMTP id 8B99DA800D0;
 Wed, 13 Jan 2016 04:02:25 +0000 (UTC)
 (envelope-from danfe@freebsd.org)
Received: from freefall.freebsd.org (freefall.freebsd.org
 [IPv6:2001:1900:2254:206c::16:87])
 by mx1.freebsd.org (Postfix) with ESMTP id 7A1251D10;
 Wed, 13 Jan 2016 04:02:25 +0000 (UTC)
 (envelope-from danfe@freebsd.org)
Received: by freefall.freebsd.org (Postfix, from userid 1033)
 id 797AD13C5; Wed, 13 Jan 2016 04:02:25 +0000 (UTC)
Date: Wed, 13 Jan 2016 04:02:25 +0000
From: Alexey Dokuchaev <danfe@FreeBSD.org>
To: Marcelo Araujo <araujo@FreeBSD.org>
Cc: ports-committers@freebsd.org, svn-ports-all@freebsd.org,
 svn-ports-head@freebsd.org
Subject: Re: svn commit: r405766 - head/print/abcm2ps
Message-ID: <20160113040225.GB42704@FreeBSD.org>
References: <201601110721.u0B7LJHD048438@repo.freebsd.org>
 <20160111082634.GA7288@FreeBSD.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20160111082634.GA7288@FreeBSD.org>
User-Agent: Mutt/1.5.24 (2015-08-30)
X-BeenThere: svn-ports-all@freebsd.org
X-Mailman-Version: 2.1.20
Precedence: list
List-Id: SVN commit messages for the ports tree <svn-ports-all.freebsd.org>
List-Unsubscribe: <https://lists.freebsd.org/mailman/options/svn-ports-all>,
 <mailto:svn-ports-all-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/svn-ports-all/>
List-Post: <mailto:svn-ports-all@freebsd.org>
List-Help: <mailto:svn-ports-all-request@freebsd.org?subject=help>
List-Subscribe: <https://lists.freebsd.org/mailman/listinfo/svn-ports-all>,
 <mailto:svn-ports-all-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Wed, 13 Jan 2016 04:02:25 -0000

On Mon, Jan 11, 2016 at 08:26:34AM +0000, Alexey Dokuchaev wrote:
> On Mon, Jan 11, 2016 at 07:21:19AM +0000, Marcelo Araujo wrote:
> > New Revision: 405766
> > URL: https://svnweb.freebsd.org/changeset/ports/405766
> > 
> > Log:
> >   - Update to 8.10.0.
> >   - USE_GCC yes.
> 
> There are several problems with this commit.  On the surface, it does not
> explain the reason for USE_GCC.  Secondly, even with USE_GCC=yes it still
> does no build, due to "CC = gcc" line in the $wrksrc/Makefile.  Also, the

Sorry for confusion: apparently it builds with USE_GCC unless `lang/gcc48'
port is installed, which satisfies "depends on executable: gcc48 - found",
but doesn't install unversioned symlink (available since r402352 2015-11-24
in `lang/gcc' itself -- older packages would also fail).

That said, pulling GCC just because it provides `gcc' command looks bogus.

> port does not uphold CFLAGS (and CC, obviously).
> 
> Consider the following pseudo-patch:
> 
>   -USE_GCC=       yes
>   +MAKE_ARGS=     CC="${CC}" CFLAGS="${CFLAGS}"

If you prefer, I can send a real patch.

./danfe