From owner-freebsd-current@FreeBSD.ORG  Tue May 19 19:12:45 2015
Return-Path: <owner-freebsd-current@FreeBSD.ORG>
Delivered-To: current@freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org
 [IPv6:2001:1900:2254:206a::19:1])
 (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))
 (No client certificate requested)
 by hub.freebsd.org (Postfix) with ESMTPS id 06C4461B
 for <current@freebsd.org>; Tue, 19 May 2015 19:12:45 +0000 (UTC)
Received: from smtp.vangyzen.net (hotblack.vangyzen.net
 [IPv6:2607:fc50:1000:7400:216:3eff:fe72:314f])
 by mx1.freebsd.org (Postfix) with ESMTP id E043318EA
 for <current@freebsd.org>; Tue, 19 May 2015 19:12:44 +0000 (UTC)
Received: from marvin.lab.vangyzen.net (c-73-147-253-17.hsd1.va.comcast.net
 [73.147.253.17])
 by smtp.vangyzen.net (Postfix) with ESMTPSA id 79E2356467;
 Tue, 19 May 2015 14:12:37 -0500 (CDT)
Message-ID: <555B8B3F.9030702@vangyzen.net>
Date: Tue, 19 May 2015 15:13:03 -0400
From: Eric van Gyzen <eric@vangyzen.net>
User-Agent: Mozilla/5.0 (X11; FreeBSD amd64;
 rv:31.0) Gecko/20100101 Thunderbird/31.4.0
MIME-Version: 1.0
To: Luigi Rizzo <rizzo@iet.unipi.it>, current@freebsd.org
Subject: Re: pedantic compiler warnings: double semicolons, function to data
 pointers
References: <20150519184252.GB66725@onelab2.iet.unipi.it>
In-Reply-To: <20150519184252.GB66725@onelab2.iet.unipi.it>
Content-Type: text/plain; charset=windows-1252
Content-Transfer-Encoding: 7bit
X-BeenThere: freebsd-current@freebsd.org
X-Mailman-Version: 2.1.20
Precedence: list
List-Id: Discussions about the use of FreeBSD-current
 <freebsd-current.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/options/freebsd-current>, 
 <mailto:freebsd-current-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-current/>
List-Post: <mailto:freebsd-current@freebsd.org>
List-Help: <mailto:freebsd-current-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-current>,
 <mailto:freebsd-current-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Tue, 19 May 2015 19:12:45 -0000

On 05/19/2015 14:42, Luigi Rizzo wrote:
> While trying to compile some of my (kernel) code in different environments,
> i noticed a couple of errors that perhaps might be worth fixing
>
> - extra semicolons. These come either from explicit repetitions in the code
>   (see the output of a grep at the end of this message),
>   or sometimes from the epansion of macros such as BITSET_DEFINE()
>
>
> - conversion between function and data pointers. One is in mbuf.h
>
>   m->m_ext.ext_free = m->m_ext.ext_arg1 = m->m_ext.ext_arg2 = NULL;
>
>
> Shuold we care/bother to fix these as we step through them ?

I would say yes, since that would reduce the noise in the compiler warning output.  I realize the warning could be disabled, but cleaning up the ~50 occurrences [of ;;] seems like the better way.

Eric