From owner-cvs-all Sat Apr 20 18:17:59 2002 Delivered-To: cvs-all@freebsd.org Received: from fledge.watson.org (fledge.watson.org [204.156.12.50]) by hub.freebsd.org (Postfix) with ESMTP id 9903437B416; Sat, 20 Apr 2002 18:17:41 -0700 (PDT) Received: from fledge.watson.org (fledge.pr.watson.org [192.0.2.3]) by fledge.watson.org (8.11.6/8.11.6) with SMTP id g3L1HGw95142; Sat, 20 Apr 2002 21:17:17 -0400 (EDT) (envelope-from robert@fledge.watson.org) Date: Sat, 20 Apr 2002 21:17:16 -0400 (EDT) From: Robert Watson X-Sender: robert@fledge.watson.org To: "Andrey A. Chernov" Cc: "Jacques A. Vidrine" , cvs-committers@FreeBSD.org, cvs-all@FreeBSD.org Subject: Re: cvs commit: src/crypto/openssh servconf.c session.c In-Reply-To: <20020420155843.GB6669@nagual.pp.ru> Message-ID: MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: owner-cvs-all@FreeBSD.ORG Precedence: bulk List-ID: List-Archive: (Web Archive) List-Help: (List Instructions) List-Subscribe: List-Unsubscribe: X-Loop: FreeBSD.ORG On Sat, 20 Apr 2002, Andrey A. Chernov wrote: > On Sat, Apr 20, 2002 at 11:02:10 -0400, Robert Watson wrote: > > > where there have been bugs previously (I haven't had a chance to do tests > > to make sure they didn't recur with the recent upgrades, and need to do > > that actually). On the other hand, we need to find a good balance between > > The test for correct environment after ssh login is very simple, just > compare 'env' output after ssh-ed login and after normal one, look for > missing variables (like FTP_PASSIVE_MODE comes from login.conf). There's actually a lot more to it than that. In the past, sshd has invoked the wrong version of the setusercontext/setlogincontext() call under some circumstances, resulting in some aspects of libutil processing not occurring. I fixed that bug a few months ago, but have't checked to see that it remains fixed. Robert N M Watson FreeBSD Core Team, TrustedBSD Project robert@fledge.watson.org NAI Labs, Safeport Network Services To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe cvs-all" in the body of the message